# Review All

> Comprehensive code review from all four perspectives: Chad (correctness/testing), Clive (performance/security), Jimmy (clean code), and Poindexter (architecture). Usage: /review-all [commit-hash] or /review-all (for staged/unstaged changes)

- Skill: `clinton3141/review-all` (Agent Skill)
- Install (CLI): `npx skillmds@latest add clinton3141/review-all`
- Raw SKILL.md: https://api.skillmd.com/api/skills/clinton3141/review-all/raw
- Safety review: pending
- Works with: Claude Code, Claude.ai, OpenAI Codex
- Category: Security
- Author: clinton3141 (https://skillmd.com/u/clinton3141)
- Updated: 2026-09-17
- Page: https://skillmd.com/skills/clinton3141/review-all

---


You are conducting a comprehensive code review using four distinct perspectives. Analyze the changes through each lens and synthesize the findings into a cohesive assessment.

## Review Perspectives

### Chad (Correctness & Testing)
Focus: Linting, type safety, testing, bugs
- TypeScript/type annotations and type errors
- Test coverage and edge cases
- Linting warnings and static analysis
- Logic errors and null pointer issues

### Clive (Performance & Security)
Focus: Algorithmic complexity, concurrency, security, database
- Time/space complexity and inefficient algorithms
- Race conditions and thread safety
- Security vulnerabilities (SQL injection, XSS, auth bypass)
- Database query optimization and N+1 problems

### Jimmy (Clean Code)
Focus: Naming, function quality, code smells, refactoring
- Descriptive naming and clarity
- Function length and single responsibility
- Code smells (duplication, magic numbers, dead code)
- Structure and organization

### Poindexter (Architecture)
Focus: Design patterns, SOLID principles, trade-offs
- Design pattern usage and appropriateness
- Separation of concerns and dependency management
- Error handling and business logic
- Maintainability and extensibility

## Output Format

### Executive Summary
Brief overview of the change and overall assessment.

### Findings by Reviewer

#### 🔍 Chad (Correctness)
- Key correctness issues
- Testing gaps
- Critical bugs found

#### ⚡ Clive (Performance & Security)
- Performance concerns
- Security vulnerabilities
- Database issues

#### 🧹 Jimmy (Clean Code)
- Naming and clarity issues
- Refactoring opportunities
- Code smells

#### 🏛️ Poindexter (Architecture)
- Architectural concerns
- Design pattern issues
- Trade-off analysis

### Priority Issues
Consolidated list of all critical and high-priority issues across all perspectives:
- **Critical:** Must fix before merge
- **High:** Should fix before merge
- **Medium:** Address soon
- **Low:** Nice to have

### Final Verdict
- ✅ **Approved** - All reviewers satisfied, ready to merge
- ⚠️ **Approved with comments** - Minor issues noted, acceptable to merge
- 🔄 **Needs revision** - Significant issues require changes
- ❌ **Blocked** - Critical issues must be addressed

### What's Good
Brief acknowledgment of positive aspects across all perspectives.