# Code Simplifier > [Code Quality] Use when you need to simplify and refine code for clarity, consistency, and maintainability while preserving all functionality. - Skill: `duc01226/code-simplifier` (Agent Skill) - Install (CLI): `npx skillmds@latest add duc01226/code-simplifier` - Raw SKILL.md: https://api.skillmd.com/api/skills/duc01226/code-simplifier/raw - Safety review: pending - Works with: Claude Code, Claude.ai, OpenAI Codex - Category: Coding & Dev Tools - Author: duc01226 (https://skillmd.com/u/duc01226) - Updated: 2026-09-09 - Page: https://skillmd.com/skills/duc01226/code-simplifier --- > Codex compatibility note: > > - Invoke repository skills with `$skill-name` in Codex; this mirrored copy rewrites legacy Claude `/skill-name` references. > - Task tracker mandate: BEFORE executing any workflow or skill step, create/update task tracking for all steps and keep it synchronized as progress changes. > - User-question prompts mean to ask the user directly in Codex. > - Ignore Claude-specific mode-switch instructions when they appear. > - Strict execution contract: when a user explicitly invokes a skill, execute that skill protocol as written. > - Subagent authorization: when a skill is user-invoked or AI-detected and its protocol requires subagents, that skill activation authorizes use of the required `spawn_agent` subagent(s) for that task. > - Do not skip, reorder, or merge protocol steps unless the user explicitly approves the deviation first. > - For workflow skills, execute each listed child-skill step explicitly and report step-by-step evidence. > - If a required step/tool cannot run in this environment, stop and ask the user before adapting. ## Codex Project-Reference Loading (No Hooks) Codex uses static project-reference loading instead of runtime-injected project docs. When coding, planning, debugging, testing, or reviewing, open project docs explicitly using this routing. **Always read:** - `docs/project-config.json` (project-specific paths, commands, modules, and workflow/test settings) - `docs/project-reference/docs-index-reference.md` (routes to the full `docs/project-reference/*` catalog) - `docs/project-reference/lessons.md` (always-on guardrails and anti-patterns) **Missing/stale context route:** If `docs/project-config.json`, the docs index, `lessons.md`, `CLAUDE.md`, `AGENTS.md`, or any task-required reference doc is missing or stale, auto-run `$project-init` or the narrow setup route (`$project-config`, `$docs-init`, `$scan-all`, `$scan --target=`, `$claude-md-init`) before ordinary project-specific work. If Codex mirrors or `AGENTS.md` are missing/stale, ask the user to run `$sync-codex`; do not auto-run it. **Situation-based docs:** - Project structure/architecture/tech-stack/deployment/setup (any layer — backend, frontend, or infra): `project-structure-reference.md` - Backend/CQRS/API/domain/entity changes: `backend-patterns-reference.md`, `domain-entities-reference.md` - Frontend/UI/styling/design-system: `frontend-patterns-reference.md`, `scss-styling-guide.md`, `design-system/README.md` - Spec authoring, `docs/specs/` pathing, or TC format: `feature-spec-reference.md`, `spec-system-reference.md`, `spec-principles.md` - Behavior/public-contract changes or spec-test-code sync: `workflow-spec-test-code-cycle-reference.md` plus the spec docs above - Derived spec indexes/ERDs/reimplementation guides: `spec-system-reference.md` and source Feature Specs under `docs/specs/` - Integration test implementation/review: `integration-test-reference.md` - E2E test implementation/review: `e2e-test-reference.md` - Code review/audit work: `code-review-rules.md` plus domain docs above based on changed files Do not read all docs blindly. Start from `docs-index-reference.md`, then open only relevant files for the task. > **[BLOCKING]** Execute skill steps in declared order. NEVER skip, reorder, or merge steps without explicit user approval. > **[BLOCKING]** Before each step or sub-skill call, update task tracking: set `in_progress` when step starts, set `completed` when step ends. > **[BLOCKING]** Every completed/skipped step MUST include brief evidence or explicit skip reason. > **[BLOCKING]** If Task tools are unavailable, create and maintain an equivalent step-by-step plan tracker with the same status transitions. ## Quick Summary **Goal:** Lower the cost of the next change — cut coupling, hidden state, duplicated knowledge, unclear intent — by simplifying and refining code for clarity, consistency, and maintainability without altering any observable behavior. — why: every simplification serves future change cost, not aesthetics. **Summary:** (read-this-if-nothing-else digest — purpose + every main step) - **Purpose — skeptical-first MUTATOR, not a suggester:** grep all usages + trace consumers (graph downstream when graph.db exists) and cite `file:line` BEFORE touching anything; apply a simplification ONLY when certain it preserves behavior, never when unsure. — why: an unverified "safe" rewrite silently breaks a downstream consumer. - **Main steps, run in order:** (1) **Phase 0 Detect** artifact type (backend/frontend/test/config) + scope; (2) **Identify Targets** — recent git changes or named files, HARD-SKIP generated/migration/vendor; (3) **Analyze** via the 5 Simplification Dimensions; (4) **Apply** one refactoring type at a time (KISS/DRY/YAGNI, behavior-preserving); (5) **Verify** related tests after EACH change; (6) **Self-Recursive Loop** (analyze→simplify→verify) until zero findings or a no-progress/unsafe/owner-decision stop hits — do NOT spawn a fresh-context reviewer for your own findings; (7) **Self-Review Gate**. - **The 5 Simplification Dimensions (step 3):** readability · DRY/abstraction (≥3 occurrences, YAGNI gate) · right-responsibility-lowest-layer (Entity > Domain Service > App Service > Controller) · complexity reduction (flatten nesting, extract >20-line methods) · DB paging+indexes — every technique answers ONE test: does this make the next change cheaper? - **Self-Review Gate (step 7) — this skill owns review of its own output:** when it changed any file, self-invoke `$code-review` scoped to ONLY those changed files (recursion-safe leaf — NEVER `$changes-review`); skip + log the reason when nothing changed. — why: the simplifier rewrites code after the main review batch, so its output ships unreviewed without this gate. - **Read FIRST:** `docs/project-reference/code-review-rules.md` (anti-patterns/checklists) then `project-structure-reference.md` — before any modification. > **MANDATORY IMPORTANT MUST ATTENTION** Plan task to READ: > > - `docs/project-reference/code-review-rules.md` — anti-patterns, review checklists **(READ FIRST)** > - `project-structure-reference.md` — project patterns/structure > > If not found, search for: project documentation, coding standards, architecture docs. **Workflow:** 1. **Phase 0: Detect** — Classify artifact type (backend/frontend/test/config) and scope 2. **Identify Targets** — Recent git changes or specified files (skip generated/vendor) 3. **Analyze** — Apply simplification dimensions (see below) 4. **Apply** — One refactoring type at a time following KISS/DRY/YAGNI 5. **Verify** — Run related tests, confirm no behavior changes 6. **Self-Recursive Check** — Re-run this skill's simplification analysis until no simplification findings remain 7. **Self-Review Gate (MANDATORY when code changed)** — If this skill modified any files, self-invoke `$code-review` scoped to ONLY those changed files; skip + log if nothing changed **Key Rules:** - Preserve all existing functionality — no behavior changes - Follow the project's documented patterns (entity expressions, fluent helpers, store base, BEM) - Easy to Change is the primary simplification goal for source files; DRY, SOLID, abstraction, and patterns are valid only when they lower future edit sites or cognitive load - Tests pass after every change - Apply simplification only when certain it preserves behavior — NEVER apply when unsure ## Phase 0: Artifact Detection **MUST ATTENTION** classify before simplifying — detection drives focus and optional escalation only: | Artifact Type | Detection | Key Focus | | ---------------- | -------------------------------------------------------------------------- | ----------------------------------------------------------------------------------------------- | | Backend | Backend source files for the current stack (e.g. `.cs`) | Domain-model expressions, fluent API, DRY via OOP, SOLID | | Frontend | Frontend source files for the current stack (e.g. `.ts`, `.html`, `.scss`) | BEM, store base, subscription cleanup, component base | | Tests | Test source files for the current stack (e.g. `*Test.cs`, `*.spec.ts`) | Assertions, async-assertion helpers (e.g. an await-until-condition poll helper), data isolation | | Config/Generated | Migrations, generated/vendor files (e.g. `*.generated.*`) | **SKIP** — NEVER simplify generated/migration code | Optional escalation by artifact: | Artifact | Escalate only when | | -------------------- | -------------------------------------------------------- | | Source code/diffs | Broad review is requested after simplifier loop is clean | | Security-sensitive | Security-specific risk is present | | Performance-critical | Performance behavior is part of the change | | Plans/docs/specs | Artifact review is explicitly requested | ## First Principle — Easy to Change > **The success metric of every coding decision is _future change cost_.** > DRY, SRP, abstraction, design patterns, naming, layering, tests — every > technique exists to serve one goal: **making the next change cheaper**. When evaluating code, a refactor, a test, or an abstraction, ask: **does this make the next change cheaper or more expensive?** - Reject "best practices" that raise change cost (premature abstraction, speculative generality, leaky indirection, ceremony without payoff). - Name the real enemies in findings: **coupling, hidden state, duplicated knowledge, unclear intent, irreversible decisions exposed too early**. - Favor project-owned boundaries around external libraries, for example component/service input-output contracts, when they localize future library changes; reject pass-through wrappers that add ceremony without lowering change cost. - A simpler design that is easy to change beats a sophisticated design that isn't. Apply this lens **before** invoking any specific rule, pattern, or checklist below — if a downstream rule would raise change cost, this principle wins. --- ## Simplification Mindset **Skeptical-first:** Verify before simplifying. Every change needs proof preserving behavior. - NEVER assume code redundant — trace call paths and read implementations first - Before removing/replacing: grep all usages confirming nothing depends on current form - Before flagging convention violation: grep 3+ existing examples — codebase convention wins - Every simplification requires `file:line` evidence of what was verified - Apply simplification only when certain it preserves behavior; if unsure → DO NOT apply ## Simplification Dimensions Dimension-based reasoning replaces fixed checklists. Each dimension has a `Think:` prompt forcing first-principles reasoning. ### Dimension 1: Readability > **Think:** Would a new engineer understand this in 30 seconds? What forces multiple file traces? - Schema visibility: functions computing data structures need output-shape comment - Non-obvious pipelines: A→B→C transformations need brief pipeline explanation - Self-documenting signatures: params explain role; remove unused params - Magic values: replace unexplained numbers/strings with named constants - Naming clarity: names reveal intent without reading implementation ### Dimension 2: DRY & Abstraction > **Think:** Pattern appearing ≥3 places? What base class/generic eliminates duplication? - Same-suffix classes (`*Entity`, `*Dto`, `*Service`) → shared base - Repeated logic blocks → extract to helper/extension method - YAGNI gate: NEVER extract for hypothetical future use — 3+ occurrences required ### Dimension 3: Right Responsibility > **Think:** Logic in lowest layer that can own it? Could moving it down enable reuse? - `Entity/Model → Domain Service → Application Service → Controller` (logic belongs lowest) - Business logic in controllers → move down - Mapping in handlers → move to DTO methods ### Dimension 4: Complexity Reduction > **Think:** What is cognitive load? Can nesting/conditionals flatten? - Nesting >3 → refactor (early returns, extract methods) - Methods >20 lines → extract - Complex conditionals → flatten or Strategy pattern (3+ branching occurrences only) ### Dimension 5: Database Performance > **MANDATORY IMPORTANT MUST ATTENTION** > > 1. **Paging:** ALL list queries MUST use pagination. NEVER unbounded `GetAll()`, `ToList()`, `Find()` without `Skip/Take` or cursor-based paging. > 2. **Indexes:** ALL filter fields, foreign keys, sort columns MUST have database indexes. Entity expressions must match index field order. Collections need index management methods. ## Project Patterns ### Backend - Extract entity static expressions (search: entity expression pattern) - Use fluent helpers (search: fluent helper pattern in `docs/project-reference/backend-patterns-reference.md`) - Move mapping to DTO mapping methods (search: DTO mapping pattern) - Use project validation fluent API (see `docs/project-reference/backend-patterns-reference.md`) - Verify entity expressions have database indexes - Verify document DB collections have index management methods ### Frontend - Use project store base (search: store base class) for state management - Apply subscription cleanup (search: subscription cleanup pattern) to all subscriptions - BEM class naming on ALL template elements - Use the project's base classes (search: base component class, store component base class) ## Graph Intelligence (MANDATORY if graph.db exists) Before simplifying, trace what depends on target: ``` python .claude/scripts/code_graph trace --direction downstream --json ``` Verify simplified code preserves same interface for all traced consumers. Cross-service MESSAGE_BUS consumers are especially fragile — may depend on exact message shape. Additional queries: - Verify no callers break: `python .claude/scripts/code_graph query callers_of --json` - Check dependents: `python .claude/scripts/code_graph query importers_of --json` - Batch analysis: `python .claude/scripts/code_graph batch-query file1 file2 --json` ## Execution ``` spawn_agent(agent_type="code-simplifier", prompt="Review and simplify [target files]") ``` **Example:** ```typescript // Before function getData() { const result = fetchData(); if (result !== null && result !== undefined) { return result; } else { return null; } } // After function getData() { return fetchData() ?? null; } ``` ## Constraints - **Preserve functionality** — no behavior changes - **Tests passing** — verify after every change - **Follow patterns** — use the project's conventions, never invent - **Doc staleness** — cross-ref changed files against feature docs, test specs, READMEs; flag updates needed - **Preserve ALL invariants; never weaken a property/mutation test** — a refactor MUST keep every `[HARD]` §4 rule / §5 invariant intact and MUST NOT delete, relax, or trivialize any property test or mutation test that guards them. If a simplification changes observable behavior, that is NOT a silent change — it is a **Dual-Feedback finding** (feed the spec AND the tests, then re-review), report it and stop, never ship it. After simplifying, the package MUST still pass the SAME property/mutation bar it passed before — green tests on a weakened bar are not a pass. --- ## Self-Recursive Verification (MANDATORY after simplifications) After simplifications applied, verification requires a **self-recursive simplification pass** over the updated diff. Do NOT spawn fresh-context reviewer to re-review this skill's own findings. Repeat analyze → simplify → verify until this skill finds no further simplification opportunities, or stop on unsafe/no-progress/user-decision blocker. ## Self-Review Gate (MANDATORY when this skill changed code) > **This skill is a code MUTATOR. It owns the review of its own output.** Once the self-recursive simplification loop above is clean, gate the result: > > 1. **Did this skill modify any files?** Determine the exact set of files this skill changed (its own edits — not the whole working tree). > - **No files changed** → SKIP this gate and **log the skip reason** ("code-simplifier made no changes — no self-review needed"). Done. > - **Files changed** → continue. > 2. **Self-invoke `$code-review` scoped to ONLY the changed files.** Pass the explicit changed-file set as the review target — not the full diff, not unrelated files. > 3. **Integrate the `$code-review` findings.** If it surfaces blocking issues caused by the simplification, fix them (behavior-preserving only) and re-run the self-recursive loop + this gate. If issues are out of simplification scope, report them up — do not silently drop. > > **Recursion safety:** `$code-review` is a LEAF review skill — it does NOT invoke `$code-simplifier` back, so there is no cycle. Use `$code-review` here, NEVER `$changes-review` (the heavyweight workflow that itself contains `$code-simplifier` and would recurse). > > **Why this gate exists:** `$code-simplifier` rewrites code after the main review batch has already run. Without this gate, the simplifier's output would ship unreviewed. This gate moves that review responsibility into the mutator itself — so the `workflow-review-changes` workflow no longer needs a separate `$code-review` step after `$code-simplifier`. Used standalone (outside a review workflow), this self-review gate is sufficient for the simplifier's own changes; you may still finish with `$changes-review` or the active workflow's review gate for broader, whole-changeset coverage. ## Workflow Recommendation > **MANDATORY — NO EXCEPTIONS:** If NOT already in workflow, use ask the user directly to ask user. Do NOT decide this is "simple enough to skip" — the user decides: > > 1. **Activate `workflow-review-changes` workflow** (Recommended) — full changes-review restart gate → validated fix cycle (plan → plan-review → feature-implement) → re-review → docs > 2. **Execute `$code-simplifier` directly** — run standalone (this skill self-reviews its own changes via the Self-Review Gate) --- ## Next Steps **MANDATORY — NO EXCEPTIONS** after completing, use ask the user directly: - **"$workflow-review-changes (Recommended)"** — Review all changes before commit - **"$code-review"** — Full code review - **"Skip, continue manually"** — user decides ## AI Agent Integrity Gate (NON-NEGOTIABLE) > **Completion ≠ Correctness.** Before reporting work done, prove it: > > 1. **Grep every removed name.** Extraction/rename/delete → grep confirms 0 dangling refs across ALL file types. > 2. **Ask WHY before changing.** Existing values intentional until proven otherwise. No "fix" without traced rationale. > 3. **Verify ALL outputs.** One build passing ≠ all builds passing. Check every affected stack. > 4. **Evaluate pattern fit.** Copying nearby code? Verify preconditions match — same scope, lifetime, base class, constraints. > 5. **New artifact = wired artifact.** Created? Prove registered, imported, reachable by all consumers. > **[IMPORTANT]** Use task tracking to break ALL work into small tasks BEFORE starting — including tasks for each file read. For simple tasks, ask user whether to skip. **Prerequisites:** **MUST ATTENTION READ** before executing: - `docs/project-reference/domain-entities-reference.md` — domain entity catalog, relationships, cross-service sync (read when task involves business entities/models) > **External Memory:** Complex/lengthy work → write findings to `plans/reports/`. Prevents context loss, serves as deliverable. > **Evidence Gate:** MANDATORY — every claim, finding, recommendation requires `file:line` proof or traced evidence (confidence >80% to act, <80% verify first). > **OOP & DRY Enforcement:** MANDATORY — flag duplicated patterns for base class extraction. Same-suffix classes (`*Entity`, `*Dto`, `*Service`) inherit common base. Verify stack has linting/analyzer configured. ## Self-Recursive Simplification Loop **Purpose:** Avoid spending tokens on a fresh-context review of this skill's own findings. The simplifier owns its own convergence loop; broader review workflows can still run after the simplifier reports clean. Loop: 1. Analyze the current target/diff for simplification findings with `file:line` evidence. 2. Apply only behavior-preserving simplifications that satisfy the evidence gate. 3. Run targeted verification after each change set. 4. Re-read the updated diff and re-run this skill's simplification dimensions. 5. Repeat until this skill finds zero simplification findings. Stop conditions: - The same simplification finding repeats for 3 passes with no progress. - A simplification needs product/owner input or has behavior-change risk. - Verification cannot run or cannot prove behavior preservation. Rules: - Do not spawn a fresh-context reviewer just because simplifications were applied. - Do not re-review known findings in a fresh context before fixing them. - Do not hand off as clean until the self-recursive pass finds zero simplification findings. - After the self-recursive loop is clean, run the **Self-Review Gate** — if any files were changed, self-invoke `$code-review` scoped to those files (recursion-safe leaf skill); skip + log if nothing changed. > **Sub-Agent Return Contract** — When this skill spawns a sub-agent, the sub-agent MUST return ONLY this structure. Main agent reads only this summary — NEVER requests full sub-agent output inline. > > ```markdown > ## Sub-Agent Result: [skill-name] > > Status: ✅ PASS | ⚠️ PARTIAL | ❌ FAIL > Confidence: [0-100]% > > ### Findings (Critical/High only — max 10 bullets) > > - [severity] [file:line] [finding] > > ### Actions Taken > > - [file changed] [what changed] > > ### Blockers (if any) > > - [blocker description] > > Full report: plans/reports/[skill-name]-[date]-[slug].md > ``` > > Main agent reads `Full report` file ONLY when: (a) resolving a specific blocker, or (b) building a fix plan. > Sub-agent writes full report incrementally (per SYNC:incremental-persistence) — not held in memory. > > **Context budget** — the return payload is a SUMMARY, not a transcript: ≤10 finding bullets, no raw file contents / full diffs / verbatim logs inline, no re-pasted source. Everything beyond the summary lives in the `Full report` on disk. A sub-agent that would exceed the summary shape MUST write the detail to its report and return only the pointer — the orchestrator's context is the scarce resource the whole map-reduce protects. > **UI System Context** — For ANY task touching `.ts`, `.html`, `.scss`, or `.css` files: > > **MUST ATTENTION READ before implementing:** > > 1. `docs/project-reference/frontend-patterns-reference.md` — component base classes, stores, forms > 2. `docs/project-reference/scss-styling-guide.md` — BEM methodology, SCSS variables, mixins, responsive > 3. `docs/project-reference/design-system/README.md` — design tokens, component inventory, icons > > Reference `docs/project-config.json` for project-specific paths. > **Shared Protocol Duplication Policy** — Inline protocol content in skills (wrapped in ``) is INTENTIONAL duplication. Do NOT extract, deduplicate, or replace with file references. AI compliance drops significantly when protocols are behind file-read indirection. To update: edit `.claude/skills/shared/sync-inline-versions.md` first, then grep `SYNC:protocol-name` and update all occurrences. > **Source/test drift check.** For coding, fix, debug, investigation, test, or review work: when source behavior changes, inspect affected unit/integration/E2E tests and decide from evidence whether tests should change to match intended behavior or the source change is an unintended bug to fix. Do not write tests for migration code; schema/data migrations are one-time execution paths, not core application logic. > **AI Mistake Prevention** — Failure modes to avoid on every task: > > **Re-read files after context changes.** Context compaction, resume, or long-running work can make memory stale; verify current files before acting. > **Verify generated content against source evidence.** AI hallucinates APIs, names, claims, and document facts. Check the relevant source before documenting or referencing. > **Check downstream references before deleting or renaming.** Removing an artifact can stale docs, generated mirrors, configs, and callers; map references first. > **Trace the full impact chain after edits.** Changing a definition can miss derived outputs and consumers. Follow the affected chain before declaring done. > **Verify ALL affected outputs, not just the first.** One green check is not all green checks; validate every output surface the change can affect. > **Assume existing values are intentional — ask WHY before changing OR flagging one as a defect.** Before changing or reporting a constant, limit, flag, cutoff, wording, or pattern, read nearby context and history, the CALLER's ordering, and 2+ sibling call sites of the same convention. A doc stating WHAT without WHY is missing rationale, not proof of a missing guard. > **Surface ambiguity before acting — don't pick silently.** Multiple valid interpretations require an explicit question or stated assumption with risk. > **Assert the outcome your system owns, not the intermediate state your infrastructure owns.** When verifying async work, assert the final business state — never the delivery/retry bookkeeping held in shared infrastructure that any co-running process can write. Such a check passes when run alone and flakes the moment anything else shares that infrastructure. > **Keep shared guidance role-relevant.** Universal guidance must help every receiving skill or agent; code-specific obligations belong only in code-specific protocols. > **Critical Thinking Mindset** — Apply critical thinking, sequential thinking. Every claim needs traced proof, confidence >80% to act. > **Anti-hallucination:** Never present guess as fact — cite sources for every claim, admit uncertainty freely, self-check output for errors, cross-reference independently, stay skeptical of own confidence — certainty without evidence root of all hallucination. > **Understand Code First** — HARD-GATE: Do NOT write, plan, or fix until you READ existing code. > > 1. Search 3+ similar patterns (`grep`/`glob`) — cite `file:line` evidence > 2. Read existing files in target area — understand structure, base classes, conventions > 3. Run `python .claude/scripts/code_graph trace --direction both --json` when `.code-graph/graph.db` exists > 4. Map dependencies via `connections` or `callers_of` — know what depends on your target > 5. Write investigation to `.ai/workspace/analysis/` for non-trivial tasks (3+ files) > 6. Re-read analysis file before implementing — never work from memory alone. — why: long context drifts from the file; the file is ground truth > 7. NEVER invent new patterns when existing ones work — match exactly or document deviation. — why: divergent patterns fragment the codebase and slow every future reader > > **BLOCKED until:** `- [ ]` Read target files `- [ ]` Grep 3+ patterns `- [ ]` Graph trace (if graph.db exists) `- [ ]` Assumptions verified with evidence > **Design Patterns Quality** — Priority checks for every code change: > > 1. **DRY via OOP:** Identify classes/modules with the same purpose, naming pattern, or lifecycle. Apply your knowledge of the project's language/framework to determine the idiomatic abstraction (base class, mixin, trait, protocol, decorator). 3+ similar patterns → extract to shared abstraction. > 2. **Right Responsibility:** Logic in LOWEST layer (Entity > Domain Service > Application Service > Controller). Never business logic in controllers. > 3. **SOLID:** Single responsibility (one reason to change). Open-closed (extend, don't modify). Liskov (subtypes substitutable). Interface segregation (small interfaces). Dependency inversion (depend on abstractions). > 4. **After extraction/move/rename:** Grep ENTIRE scope for dangling references. Zero tolerance. > 5. **YAGNI gate:** NEVER recommend patterns unless 3+ occurrences exist. Don't extract for hypothetical future use. > > **Anti-patterns to flag:** God Object, Copy-Paste inheritance, Circular Dependency, Leaky Abstraction. > > **Serial Attention for Design Quality** — Scan one quality dimension at a time (serial passes), not all concerns at once. — why: split attention misses violations that single-focus passes catch. > > 1. **Identify applicable dimensions** — Based on the code's language, domain, and patterns, determine which quality dimensions apply: DRY, SOLID principles (SRP/OCP/LSP/ISP/DIP), OOP idioms, cohesion/coupling, GRASP, Law of Demeter, CQRS invariants, etc. Your list is NOT fixed — derive from what the code actually does. > 2. **One focused pass per dimension** — Dedicate single-focus attention to EACH dimension in sequence. Do NOT mix concerns across passes. > 3. **Threshold: 3+ similar patterns = MANDATORY extraction** — Not optional suggestion. Flag as mandatory structural fix requiring action. > 4. **2+ violations of same kind = structural finding** — Report as "pattern problem" needing architectural resolution, not a list of individual instances. > **Complexity Prevention (Ousterhout)** — MANDATORY. Measure code by cost of change: one business change should map to one code change. Flag ALL of the following in review: > > 1. **Change amplification** — small business change forces edits in >3 places → structural flaw. Count edit sites for a plausible future change (add variant, add field, add authorization). >3 = reject. > 2. **Cognitive load** — reader must hold too much context to safely modify. Flag deep inheritance, long parameter lists, boolean traps, implicit ordering dependencies. > 3. **Cross-cutting duplication at entry points** — logging, error handling, validation, auth, transactions reimplemented per controller/handler/route. Lift to middleware / interceptor / filter / decorator / aspect. > 4. **Leaked implementation technology** — repos returning `IQueryable`/`QuerySet`/`Criteria`/raw cursors/ORM entities to callers. Return finished results + intent-revealing methods (`GetActiveVipUsers()` not `Query()`). > 5. **Type-switch scattering** — `switch`/`if`-chains on enum/discriminator in >1 place. New variant = new file, not N edits. One factory/registry switch at the boundary OK; scattered switches = reject. > 6. **Anemic models** — domain objects with only getters/setters, logic floats in services. Move invariants/behavior onto the object (`order.Checkout()`, not `order.Status = ...`). > 7. **Primitive obsession** — raw `string`/`int`/`decimal` for account numbers, emails, money, percentages, date ranges, with re-validation at every entry. Wrap in value objects / records / structs that validate once at construction. > 8. **Inline cross-cutting concerns** — authorization/tenant isolation/audit/sanitization hand-written at top of every handler. Flag intent with declarative markers (`@RequirePermission("Order.Delete")`), enforce once centrally. > 9. **Shallow modules** — tiny class, big interface (many public methods, many flags, many ctor params) wrapping little logic. A module is deep when a small interface hides a lot of implementation. If interface ≈ implementation cost to learn → inline. > 10. **Missing base class for repeated component/handler lifecycle** — 3+ forms/CRUD handlers/list views reimplementing loading/dirty/submit/pagination → extract to base class / hook / composable / mixin / trait. > 11. **Premature vs delayed abstraction** — rule-of-three. First occurrence: write it. Second: notice duplication. Third: extract. Don't build generic frameworks before real variation; don't copy-paste for the 4th time. > 12. **Embedded utility logic not extracted to helpers** — inline paging loops (`while (hasMore) { skip += take; ... }`), ad-hoc datetime math, string parsing/formatting, collection partitioning, retry/backoff loops, URL/query-string building. If the algorithm is non-trivial AND stack-generic (not business-specific), extract to `util`/`helper`/`extensions` and let consumers call one line. Inline duplicates → duplicated bug surface. > 13. **Logic in wrong (higher) layer — downshift to callee** — business/derivation logic written in the caller when the callee owns the data. Defaults: Controller code that should be App Service. App Service code that should be Domain Service or Entity. Component code that should be ViewModel/Store/Service. Caller reaching into callee's data shape to compute something → move the computation behind an intent-revealing method on the callee. Lowest responsible layer wins (Entity > Domain Service > App Service > Controller · Model/VM > Store > Component). Higher-layer placement = duplicated logic when a sibling caller needs the same thing. > 14. **Owner owns the rule — extract on first write** — if a caller inlines logic that derives, normalizes, validates, or computes from another type's data, MOVE it to the owning type. Single use is sufficient — the trigger is wrong responsibility, not duplication. Sibling callers always arrive; inline copies drift silently with no compile error and no name to grep. **Common offenders:** _Backend_ — inlined rules in application-layer handlers / commands / queries / services / controllers that belong on the domain entity / value object / domain service. _Frontend_ — inlined derivations / formatting / validation in components that belong on the model / store / view-model / API service. **Fix:** name the rule once as a method (static or instance) on the owning type; callers invoke by name. Future variant → SECOND named method on the owner, never an inline near-duplicate. **Right responsibility first; reuse is the consequence.** > > **Extraction target — where the named rule lives:** > > | Shape of the rule | Goes to | > | --------------------------------------------- | ----------------------------- | > | Pure function over an entity's own data | static method on the entity | > | Behavior that mutates / guards entity state | instance method on the entity | > | Always-true invariant on a primitive value | value object constructor | > | Needs DI (repo / settings / clock) | helper class registered in DI | > | Domain-agnostic algorithm reused across types | util / extension method | > | Pure shape / projection conversion | DTO mapping | > > **Pre-commit edit-site test (reject if answer is "many"):** > > | Change Scenario | Should touch | > | ----------------------------------------------- | ------------------------- | > | Add new variant (customer type, payment method) | 1 new file | > | Change HTTP error response format | 1 middleware/filter | > | Add timestamp field to every persisted entity | 1 base entity/interceptor | > | Add authorization to a new endpoint | 1 declarative marker | > | Swap database/ORM | Data layer only | > | Change business calculation rule | 1 method on owning entity | > | Add loading indicator pattern to forms | 1 base component/hook | > | Add validation rule to a domain primitive | 1 value-object ctor | > | Change paging/retry/datetime algorithm | 1 helper/util function | > | Change a derivation of entity data | 1 method on the entity | > > **Operating heuristics:** > > - Write the call site first. > - Count edit sites for plausible future change. > - Prefer removing code over adding it. > - Surface assumptions at boundaries, hide details inside. > - **Pre-reuse scan** — before writing a non-trivial block, grep for similar algorithms (`while.*skip`, `DateTime.*Add`, `split`/`join` chains, paging loops, retry loops). Match existing helper → call it. None exists but pattern is stack-generic → extract to util before second caller appears. > - **Layer placement test** — ask "if a sibling caller needed this tomorrow, would they re-derive it?" If yes, the logic is in the wrong layer. Move it down. > - **Open-case-for-future-reuse** — if reviewer spots a block that is likely to appear in another feature (domain-agnostic algorithm, shared lifecycle, recurring derivation), do NOT rationalize with pure YAGNI. Either extract now (if cheap) or create a tracked TODO with the exact extraction target so the second caller does not duplicate silently. Silent duplication is the default failure mode. > - When in doubt ask: "What would need to change if the requirement shifts?" > > **The measure of good code is the cost of change.** Not shortest. Not cleverest. Not most abstracted. Cheapest to safely modify having read a small local portion. > **Severity Rubric** — Classify every finding by consequence, not by how easy it is to fix. One scale across all reviews so a "High" means the same thing everywhere. > > | Severity | Action | Definition | > | -------- | ----------- | ------------------------------------------------------------------------- | > | CRITICAL | Block merge | Silent runtime failure, data corruption, validation bypass, security hole | > | HIGH | Must fix | Incorrect behavior, invariant gap, architectural violation | > | MEDIUM | Should fix | Design debt, maintainability, likely future bug | > | LOW | Nice to fix | Convention, documentation, minor clarity | > > **Score-based skills** map their numeric scale onto these tiers — do not invent a parallel vocabulary: > > - **0-2 criterion scoring** (e.g. production-readiness-review): `0` = CRITICAL/HIGH (criterion unmet, blocks production readiness), `1` = MEDIUM (partial, should fix), `2` = pass (no finding). > - **Two-axis scoring** (e.g. performance-review, impact × likelihood): map the resulting cell to the nearest tier — high-impact + high-likelihood → CRITICAL/HIGH; low-impact OR low-likelihood → MEDIUM/LOW. > > A finding's tier drives the gate: CRITICAL/HIGH must be resolved or explicitly accepted by the owner before PASS; MEDIUM/LOW may ship with a tracked follow-up. - **MANDATORY IMPORTANT MUST ATTENTION** cite `file:line` evidence for every claim. Confidence >80% to act, <60% = do NOT recommend. …(truncated)