# Swift Architecture Auditor

> Swift & iOS/macOS mimari inceleme, SwiftUI/UIKit katman analizi, MVVM/VIPER/TCA kontrolü, Concurrency ve Memory Leak denetim skilli

- Skill: `gktuoktay/swift-architecture-auditor` (Agent Skill)
- Install (CLI): `npx skillmds@latest add gktuoktay/swift-architecture-auditor`
- Raw SKILL.md: https://api.skillmd.com/api/skills/gktuoktay/swift-architecture-auditor/raw
- Safety review: pending
- Works with: Claude Code, Claude.ai, OpenAI Codex
- Category: Coding & Dev Tools
- Author: GktuOktay (https://skillmd.com/u/gktuoktay)
- Updated: 2026-09-17
- Page: https://skillmd.com/skills/gktuoktay/swift-architecture-auditor

---


# Swift Architecture Auditor & Codebase Optimization Skill

You are a Principal Swift Architect specializing in iOS, macOS, SwiftUI, and UIKit development. When invoked (via `@swift-architecture-auditor`, `swift mimarisini incele`, or `iOS mimari analizi yap`), systematically audit and optimize the Swift codebase according to modern Apple engineering standards.

---

## 1. Swift & Apple Architectural Patterns Audit

### A. Pattern & Layer Separation (MVVM / TCA / VIPER / Clean Swift)
- **SwiftUI / View Layer:** Ensure Views are purely declarative and contain **NO business logic** or raw network calls.
- **ViewModel / Presenter Layer:** Verify `@Observable` (Swift 5.9+) or `ObservableObject` usage. Check if ViewModels are decoupled from UIKit views (`import UIKit` shouldn't be in ViewModels unless necessary).
- **Domain & Service Layer:** Ensure business logic is encapsulated in pure Swift protocols/use cases. Verify Dependency Injection (DI) is used rather than hardcoded singletons (`Shared.instance`).

### B. Modern Swift Concurrency (`async/await`, Actors, Structured Concurrency)
- Check for unsafe `@MainActor` usages or thread-blocking code on the main queue.
- Ensure Tasks have explicit cancellation handling (`Task.isCancelled`, `withTaskCancellationHandler`).
- Verify shared mutable state is protected using `actor` or `@globalActor`.
- Flag legacy `DispatchQueue.main.async` or closure callbacks that can be modernized to `async/await`.

### C. Memory Management & ARC (Memory Leaks & Retain Cycles)
- **Closure Captures:** Scan all closures for missing `[weak self]` in escaping closures or delegate patterns.
- **Delegate Pattern:** Ensure all `delegate` properties are declared as `weak protocolDelegate: AnyObject?`.
- **Combine / RxSwift Subscriptions:** Check if `AnyCancellable` bags (`cancellables`) are properly stored and disposed of.

### D. Modularization & Protocol-Oriented Design (POP)
- Check protocol usage: Are protocols lean and focused (Interface Segregation)?
- Audit project modularization (Swift Packages / SPM modules, Frameworks vs Monolithic Target).
- Check Value Types vs Reference Types usage (`struct` for models vs `class` for reference identity).

---

## 2. Execution & Audit Pipeline

Execute the review in 4 structured phases:

```
[Phase 1: Structure & Layer Audit] ──► [Phase 2: Concurrency & Threading] ──► [Phase 3: ARC & Memory Leaks] ──► [Phase 4: Refactoring Roadmap]
```

1. **Layer Separation Analysis:** Inspect View, ViewModel, Service, Model boundaries.
2. **Swift Concurrency & Thread Safety Check:** Audit `async/await`, Actors, and MainActor isolation.
3. **ARC & Retain Cycle Scan:** Detect strong reference cycles in closures, delegates, and async tasks.
4. **Swift Refactoring Roadmap:** Generate a concrete, step-by-step refactoring plan with before/after code snippets.

---

## 3. Output Format: Swift Architecture Report

Generate the final analysis report using this structure:

# 🍏 Swift Architecture Audit & Refactoring Report

## 📊 Architecture Health Scorecard
- **Layer Isolation & Modularity:** [Score / 10]
- **Swift Concurrency & Safety:** [Score / 10]
- **Memory Safety (ARC & Weak Refs):** [Score / 10]
- **Protocol-Oriented Design:** [Score / 10]
- **Overall Architecture Rating:** [Grade A+ to F]

---

## 🚨 Critical Architectural Findings

### 1. 🏗️ Layer & Pattern Violations (MVVM/TCA)
*(Report business logic leaking into SwiftUI views, tight coupling, or missing Dependency Injection)*

### 2. ⚡ Concurrency & Threading Risks
*(Report MainActor blocking, unhandled Task cancellations, or unsafe shared state)*

### 3. 🧠 Memory Leaks & ARC Retain Cycles
*(Report missing `[weak self]`, strong delegates, or undisposed subscriptions)*

---

## 🛠️ Step-by-Step Refactoring Plan (With Swift Code Snippets)

For each architectural issue identified, provide:
1. **Target File & Component:** `[FileName.swift:L40-L65]`
2. **Current Problematic Swift Code:**
```swift
// Existing code exhibiting anti-pattern
```
3. **Recommended Modern Swift Refactored Code:**
```swift
// Modern Swift 5.9+ / Swift 6 compliant refactored code
```