# Code Quality

> Project-specific code quality standards and review checklist. Activates when reviewing code, discussing quality, refactoring, or checking for anti-patterns in this Angular 21 DDD project.

- Skill: `majiayu000/code-quality-22` (Agent Skill, multi-file: 2 files)
- Install (CLI): `npx skillmds add majiayu000/code-quality-22`
- Raw SKILL.md: https://api.skillmd.com/api/skills/majiayu000/code-quality-22/raw
- Safety review: pending
- Works with: Claude Code, Claude.ai, OpenAI Codex
- Category: Productivity
- Author: majiayu000 (https://skillmd.com/u/majiayu000)
- Updated: 2026-09-09
- Page: https://skillmd.com/skills/majiayu000/code-quality-22

---


# Code Quality Checklist

For detailed patterns, read the instruction files in `.github/instructions/`.

## Critical Violations (Must Fix)

- [ ] No barrel files (`index.ts`)
- [ ] Components in own subfolders
- [ ] DDD boundaries respected (no cross-domain imports)
- [ ] `standalone: true` + `OnPush` on every component
- [ ] Signal inputs (`input()`) and outputs (`output()`), not decorators
- [ ] `@if`/`@for`/`@switch` control flow, never `*ngIf`/`*ngFor`
- [ ] `inject()` function, not constructor injection
- [ ] No `any` types — strict TypeScript
- [ ] kebab-case files, PascalCase classes without type suffixes

## Warnings (Should Fix)

- [ ] `@for` has `track` expression
- [ ] Heavy computations in `computed()`, not templates
- [ ] Every new file has a `.spec.ts` companion
- [ ] `provideZonelessChangeDetection()` in all tests
- [ ] Store uses `rxMethod` + `tapResponse` for async
- [ ] Loading/error states managed consistently

## Lint & Format

```bash
npm run lint          # ESLint + auto-fix
npx prettier --check . # Check formatting
```