`, then proceed. ## Step 2: Write the review body to a file Write the complete, verbatim `review-pr` report to `/tmp/approve-pr-$PR.md` using the `Write` tool. Never interpolate the report into a shell command — reviews contain backticks, quotes, and `$` characters that break shell quoting. ## Step 3: Post the approval and mark it ready Determine whether GitHub will allow a formal approval before posting: ```bash BODY_FILE="/tmp/approve-pr-$PR.md" if ! IDENTITY_LINE=$(sed -n '1p' "$BODY_FILE") || ! grep -qxE '^Reviewing PR #[0-9]+ at level [0-3], head [0-9a-f]{40}, base [0-9a-f]{40}\.$' <<< "$IDENTITY_LINE"; then echo "The saved review does not begin with a valid full PR/head identity. Run review-pr again." exit 1 fi REVIEWED_PR=$(printf '%s\n' "$IDENTITY_LINE" | sed -E 's/^Reviewing PR #([0-9]+) at level .*/\1/') REVIEWED_HEAD=$(printf '%s\n' "$IDENTITY_LINE" | sed -E 's/^.* head ([0-9a-f]{40}), base .*$/\1/') verify_reviewed_head() { local current_head if ! current_head=$(gh pr view "$PR" --json headRefOid --jq .headRefOid) || [[ ! "$current_head" =~ ^[0-9a-f]{40}$ ]]; then echo "Could not resolve the current head of PR #$PR." return 1 fi if [ "$PR" != "$REVIEWED_PR" ]; then echo "Review target mismatch: report covers PR #$REVIEWED_PR, not PR #$PR." return 1 fi if [ "$current_head" != "$REVIEWED_HEAD" ]; then echo "PR #$PR moved from reviewed head $REVIEWED_HEAD to $current_head. Run review-pr again." return 1 fi return 0 } if ! verify_reviewed_head; then exit 1 fi if ! AUTHOR=$(gh pr view "$PR" --json author --jq .author.login) || [ -z "$AUTHOR" ]; then echo "Could not resolve the author of PR #$PR." exit 1 fi if ! CURRENT_USER=$(gh api user --jq .login) || [ -z "$CURRENT_USER" ]; then echo "Could not resolve the current GitHub user." exit 1 fi if [ "$CURRENT_USER" = "$AUTHOR" ]; then # GitHub forbids approving your own PR. Preserve the review as a normal # comment and make the limitation explicit in the final response. if ! gh pr comment "$PR" --body-file "$BODY_FILE"; then echo "Failed to post the self-review comment on PR #$PR." exit 1 fi REVIEW_RESULT=self-comment else # gh pr review defaults to the latest head. Use the API's explicit commit_id # so a concurrent push cannot attach this decision to an unreviewed commit. if ! gh api --method POST "repos/{owner}/{repo}/pulls/$PR/reviews" \ -f event=APPROVE \ -f commit_id="$REVIEWED_HEAD" \ -F "body=@$BODY_FILE" \ --silent; then echo "Failed to approve reviewed head $REVIEWED_HEAD on PR #$PR." exit 1 fi REVIEW_RESULT=approved fi # Recheck immediately before label handling; stop if the head moved while posting. if ! verify_reviewed_head; then echo "The review was posted, but READY was not changed because the PR head moved." exit 1 fi # Add READY only after the review/comment command succeeds. if ! LABELS=$(gh pr view "$PR" --json labels --jq '.labels[].name'); then echo "Approval succeeded, but reading labels on PR #$PR failed." exit 1 fi if printf '%s\n' "$LABELS" | grep -qx "READY"; then LABEL_RESULT=already-present else if ! verify_reviewed_head; then echo "READY was not added because the PR head moved during label handling." exit 1 fi if ! gh pr edit "$PR" --add-label "READY"; then echo "Approval succeeded, but adding READY to PR #$PR failed." exit 1 fi LABEL_RESULT=added fi ``` Safety rule: if formal approval fails for any reason other than the pre-detected self-review case, STOP. Do not convert an arbitrary permissions, network, or API failure into a comment, and do not add `READY` after a failed review command. Formal reviews must carry `commit_id="$REVIEWED_HEAD"`. Recheck `headRefOid` after posting and again immediately before `gh pr edit`; if either check observes a moved head, leave the label unchanged. The final head check and label mutation are separate GitHub API calls and cannot be atomic. ## Step 4: Confirm Read back the final state: ```bash gh pr view "$PR" --json number,title,url,state,isDraft,headRefOid,reviewDecision,labels ``` If the returned `headRefOid` differs from `REVIEWED_HEAD`, report that the final readiness state raced with a push and do not claim that `READY` applies to the reviewed commit. Report in one or two lines: - PR number + title; - formal approval posted, or the self-authored comment fallback used; - whether `READY` was added or already present;

# Approve Pr > Approve a QuestDB client pull request by posting the most recent approving review verbatim and adding READY. Use only after review-pr clears both gates and the user explicitly asks to approve. - Skill: `questdb/approve-pr-3` (Agent Skill) - Install (CLI): `npx skillmds@latest add questdb/approve-pr-3` - Raw SKILL.md: https://api.skillmd.com/api/skills/questdb/approve-pr-3/raw - Safety review: pending - Works with: Claude Code, Claude.ai, OpenAI Codex - Category: Coding & Dev Tools - Author: questdb (https://skillmd.com/u/questdb) - Updated: 2026-09-17 - Page: https://skillmd.com/skills/questdb/approve-pr-3 --- # Approve a QuestDB client pull request Approve the pull request for the currently checked-out branch. This skill is meant to run **right after `review-pr`** in the same conversation: it takes the review just produced and posts it as an approving review. Do not re-review or rewrite the report here. Actions performed, in order: 1. Post the existing review as the PR review body. 2. Approve the PR (or post the documented self-review fallback). 3. Add the `READY` label. `c-questdb-client` uses `READY` as its merge-readiness label; it does not have the main QuestDB repository's `QUEUED FOR MERGE` label. ## Step 0: Confirm the review clears the gate Use the **most recent `review-pr` report in this conversation**. Approve only when its verdict is **approve** or **approve with comments**, with: - zero open Critical findings; - correctness gate `PASS`; - test gate `PASS`. These are the hard gates defined by this repository's `review-pr` skill. Do not reinterpret admitted Moderate or Minor comments as blocking when that report's verdict explicitly approves. - If no review report exists in this conversation, STOP and tell the user to run `/review-pr` first. Never approve unreviewed code. - If the verdict is `request changes`, STOP and suggest `/reject-pr`. - If the verdict is `needs discussion`, STOP and explain that an architecture, product, or compatibility decision is still required. - Preserve the report verbatim. Do not shorten, summarize, or rewrite it. - Require the report's first line to match exactly: `Reviewing PR # at level , head <40-character headRefOid>, base <40-character baseRefOid>.` Extract that PR number as `REVIEWED_PR` and the full head OID as `REVIEWED_HEAD`. Reject missing, abbreviated, or malformed identities and tell the user to rerun `review-pr`. ## Step 1: Detect and validate the PR An explicit PR number/URL in the arguments overrides branch auto-detection. Normalize either form to the numeric PR number before constructing file paths. ```bash REVIEWED_PR='' REVIEWED_HEAD='' if ! [[ "$REVIEWED_PR" =~ ^[0-9]+$ && "$REVIEWED_HEAD" =~ ^[0-9a-f]{40}$ ]]; then echo "The review report has no valid full PR/head identity. Run review-pr again." exit 1 fi TARGET='' if [ -z "$TARGET" ]; then TARGET=$(gh pr view --json number --jq .number 2>/dev/null) fi if [ -z "$TARGET" ]; then echo "No PR found for the current branch. Run 'gh pr checkout ' or pass a PR number." exit 1 fi PR=$(gh pr view "$TARGET" --json number --jq .number 2>/dev/null) if [ -z "$PR" ]; then echo "Could not resolve PR target: $TARGET" exit 1 fi if ! CURRENT_HEAD=$(gh pr view "$PR" --json headRefOid --jq .headRefOid) || [[ ! "$CURRENT_HEAD" =~ ^[0-9a-f]{40}$ ]]; then echo "Could not resolve the current head of PR #$PR." exit 1 fi if [ "$PR" != "$REVIEWED_PR" ]; then echo "Review target mismatch: report covers PR #$REVIEWED_PR, not PR #$PR." exit 1 fi if [ "$CURRENT_HEAD" != "$REVIEWED_HEAD" ]; then echo "PR #$PR moved from reviewed head $REVIEWED_HEAD to $CURRENT_HEAD. Run review-pr again." exit 1 fi gh pr view "$PR" --json number,title,author,headRefName,headRefOid,url,state,isDraft,labels ``` Before posting anything, verify all of the following: - the PR is open; - it is the same PR reviewed by the most recent `review-pr` report; - its current `headRefOid` exactly matches the report's full `REVIEWED_HEAD`; - if it is a draft, STOP rather than marking it ready; - if it has `DO NOT MERGE`, STOP and ask the user to resolve that label — do not silently remove or override it. A PR or head mismatch is a hard stop: never post a review onto a different PR or commit. State one line to the user: `Approving PR # — `, then proceed. ## Step 2: Write the review body to a file Write the complete, verbatim `review-pr` report to `/tmp/approve-pr-$PR.md` using the `Write` tool. Never interpolate the report into a shell command — reviews contain backticks, quotes, and `$` characters that break shell quoting. ## Step 3: Post the approval and mark it ready Determine whether GitHub will allow a formal approval before posting: ```bash BODY_FILE="/tmp/approve-pr-$PR.md" if ! IDENTITY_LINE=$(sed -n '1p' "$BODY_FILE") || ! grep -qxE '^Reviewing PR #[0-9]+ at level [0-3], head [0-9a-f]{40}, base [0-9a-f]{40}\.$' <<< "$IDENTITY_LINE"; then echo "The saved review does not begin with a valid full PR/head identity. Run review-pr again." exit 1 fi REVIEWED_PR=$(printf '%s\n' "$IDENTITY_LINE" | sed -E 's/^Reviewing PR #([0-9]+) at level .*/\1/') REVIEWED_HEAD=$(printf '%s\n' "$IDENTITY_LINE" | sed -E 's/^.* head ([0-9a-f]{40}), base .*$/\1/') verify_reviewed_head() { local current_head if ! current_head=$(gh pr view "$PR" --json headRefOid --jq .headRefOid) || [[ ! "$current_head" =~ ^[0-9a-f]{40}$ ]]; then echo "Could not resolve the current head of PR #$PR." return 1 fi if [ "$PR" != "$REVIEWED_PR" ]; then echo "Review target mismatch: report covers PR #$REVIEWED_PR, not PR #$PR." return 1 fi if [ "$current_head" != "$REVIEWED_HEAD" ]; then echo "PR #$PR moved from reviewed head $REVIEWED_HEAD to $current_head. Run review-pr again." return 1 fi return 0 } if ! verify_reviewed_head; then exit 1 fi if ! AUTHOR=$(gh pr view "$PR" --json author --jq .author.login) || [ -z "$AUTHOR" ]; then echo "Could not resolve the author of PR #$PR." exit 1 fi if ! CURRENT_USER=$(gh api user --jq .login) || [ -z "$CURRENT_USER" ]; then echo "Could not resolve the current GitHub user." exit 1 fi if [ "$CURRENT_USER" = "$AUTHOR" ]; then # GitHub forbids approving your own PR. Preserve the review as a normal # comment and make the limitation explicit in the final response. if ! gh pr comment "$PR" --body-file "$BODY_FILE"; then echo "Failed to post the self-review comment on PR #$PR." exit 1 fi REVIEW_RESULT=self-comment else # gh pr review defaults to the latest head. Use the API's explicit commit_id # so a concurrent push cannot attach this decision to an unreviewed commit. if ! gh api --method POST "repos/{owner}/{repo}/pulls/$PR/reviews" \ -f event=APPROVE \ -f commit_id="$REVIEWED_HEAD" \ -F "body=@$BODY_FILE" \ --silent; then echo "Failed to approve reviewed head $REVIEWED_HEAD on PR #$PR." exit 1 fi REVIEW_RESULT=approved fi # Recheck immediately before label handling; stop if the head moved while posting. if ! verify_reviewed_head; then echo "The review was posted, but READY was not changed because the PR head moved." exit 1 fi # Add READY only after the review/comment command succeeds. if ! LABELS=$(gh pr view "$PR" --json labels --jq '.labels[].name'); then echo "Approval succeeded, but reading labels on PR #$PR failed." exit 1 fi if printf '%s\n' "$LABELS" | grep -qx "READY"; then LABEL_RESULT=already-present else if ! verify_reviewed_head; then echo "READY was not added because the PR head moved during label handling." exit 1 fi if ! gh pr edit "$PR" --add-label "READY"; then echo "Approval succeeded, but adding READY to PR #$PR failed." exit 1 fi LABEL_RESULT=added fi ``` Safety rule: if formal approval fails for any reason other than the pre-detected self-review case, STOP. Do not convert an arbitrary permissions, network, or API failure into a comment, and do not add `READY` after a failed review command. Formal reviews must carry `commit_id="$REVIEWED_HEAD"`. Recheck `headRefOid` after posting and again immediately before `gh pr edit`; if either check observes a moved head, leave the label unchanged. The final head check and label mutation are separate GitHub API calls and cannot be atomic. ## Step 4: Confirm Read back the final state: ```bash gh pr view "$PR" --json number,title,url,state,isDraft,headRefOid,reviewDecision,labels ``` If the returned `headRefOid` differs from `REVIEWED_HEAD`, report that the final readiness state raced with a push and do not claim that `READY` applies to the reviewed commit. Report in one or two lines: - PR number + title; - formal approval posted, or the self-authored comment fallback used; - whether `READY` was added or already present; - PR URL.