# Code Review

> Review a SolTechnology.Core change against the Tale Code philosophy, ClaudeCodingGuide rules, module conventions, and existing per-module review templates. Use when this capability is needed.

- Skill: `tomevault-io/code-review-291` (Agent Skill, multi-file: 2 files)
- Install (CLI): `npx skillmds@latest add tomevault-io/code-review-291`
- Raw SKILL.md: https://api.skillmd.com/api/skills/tomevault-io/code-review-291/raw
- Safety review: pending
- Works with: Claude Code, Claude.ai, OpenAI Codex
- Category: Coding & Dev Tools
- Author: tomevault-io (https://skillmd.com/u/tomevault-io)
- Updated: 2026-09-17
- Page: https://skillmd.com/skills/tomevault-io/code-review-291

---


# Code Review

Evidence-based review skill for changes inside `src/SolTechnology.Core.*` and the sample apps.

## Documentation references

- [docs/ClaudeCodingGuide.md](../../../docs/ClaudeCodingGuide.md) — binding coding rules
- [docs/reviews/](../../../docs/reviews/) — module-specific review templates
  ([Api](../../../docs/reviews/Api-Review.md),
  [HTTP](../../../docs/reviews/HTTP-Review.md),
  [Logging](../../../docs/reviews/Logging-Review.md),
  [MessageBus](../../../docs/reviews/MessageBus-Review.md),
  [Story](../../../docs/reviews/Story-Framework-Review.md))
- [docs/adr/](../../../docs/adr/) — accepted decisions

## Critical rules

- **Cite file:line** for every finding. No vibe reviews.
- **Reference the rule.** Each finding links to the Coding Guide section, ADR, or module review
  that the change violates.
- **Report what, not why-it-feels-wrong.** Suggested fix must be concrete.
- **Tale Code first.** Readability is a primary criterion, not a nice-to-have.

## Process

### 1. Gather diff

Identify changed files. Group them by module
(`SolTechnology.Core.<Module>`, `sample-tale-code-apps/<App>/`, `tests/`, `docs/`).

### 2. Coding guide compliance

Walk through the relevant sections of
[docs/ClaudeCodingGuide.md](../../../docs/ClaudeCodingGuide.md) for each diff hunk:

- §3 CQRS — handlers return `Result<T>`, registered in `ModuleInstaller`, single responsibility.
- §10 Naming — public symbols follow acronym capitalization
  ([ADR-001](../../../docs/adr/001-acronym-capitalization-refactoring.md)).
- §11 Logging — `logger.Log*` template, level, scope, no PII.
- Class-size budget — flag files exceeding the limit.
- §20 Self-Improvement — if a lesson was learnt, the guide itself or `CLAUDE.md` must be updated
  in the same PR.
- §15 Anti-patterns — if the diff drags an anti-pattern from the surrounding file (or
  introduces one), hand off the fix to [refactor](../refactor/SKILL.md). Do not approve a PR
  that propagates a §15 anti-pattern.

### 3. Module-specific checks

Open the matching template in [docs/reviews/](../../../docs/reviews/) for each touched module and
verify its checklist is satisfied. If a module has no review template, note it as a gap.

### 4. Public API and semver

- Identify added / removed / changed public/protected symbols in `src/SolTechnology.Core.*`.
- Classify semver impact (MAJOR / MINOR / PATCH).
- If MAJOR: require an ADR in [docs/adr/](../../../docs/adr/) and a `BREAKING CHANGE:` footer in
  the commit (see [commit-message](../commit-message/SKILL.md)).

### 5. Tests

- Each behavioural change has a test in `tests/SolTechnology.Core.<Module>.Tests/`.
- No reduction in test count without a stated reason.
- New `Result.Failure` paths have a negative test.
- Missing or freehand tests → hand off to [test-writing](../test-writing/SKILL.md). Do not
  invent ad-hoc layouts here.

### 6. DI and build hygiene

- Every new injectable type is registered in its module's `ModuleInstaller.cs`.
- No new warnings under `TreatWarningsAsErrors=true`
  ([src/Directory.Build.props](../../../src/Directory.Build.props)).
- `Microsoft.Extensions.*` references stay aligned at version `10.0.1`.
- Any `NU1605` / `NU190x` warning surfaced by the diff → hand off to
  [dependency-audit](../dependency-audit/SKILL.md). Do not approve a PR that masks the warning.

### 7. Documentation sync

- Each touched module has a docs file under [docs/](../../../docs/) — verify it is updated when the
  public API changes.
- The module is listed in [README.md](../../../README.md).
- Run [documentation-cleanup](../documentation-cleanup/SKILL.md) if doc changes are non-trivial.

### 8. Premortem hand-off

If the change touches public API, `ModuleInstaller`, or persisted contracts, require a
[premortem](../premortem/SKILL.md) before merge.

## Output format

### Code Review — `<change title>`

#### Files Reviewed
<placeholder>List grouped by module.</placeholder>

#### Findings

| # | Severity | File:Line | Rule (Guide §/ADR/Review) | Finding | Suggested Fix |
|---|---|---|---|---|---|
| 1 | Blocking / Major / Minor / Nit | <placeholder> | <placeholder> | <placeholder> | <placeholder> |

#### Semver Classification
**Impact**: MAJOR / MINOR / PATCH — <placeholder>evidence</placeholder>

#### Required Before Merge
- <placeholder></placeholder>

#### Premortem Required
<placeholder>Yes / No — reason.</placeholder>

#### Summary
**Blocking findings**: <placeholder>count</placeholder>
**Recommendation**: Approve / Approve with comments / Request changes

---
> Source: [AdrianStrugala/SolTechnology.Core](https://github.com/AdrianStrugala/SolTechnology.Core) — distributed by [TomeVault](https://tomevault.io).
<!-- tomevault:4.0:skill_md:2026-07-04 -->