# Pre Pr Review

> Review pass before opening a pull request in this repository. Runs local CI gates and the repo-reviewer subagent on the full branch diff, iterates until the reviewer approves, and records the verdict in the PR description. Use whenever you are about to create a PR.

- Skill: `yuga-hashimoto/pre-pr-review` (Agent Skill)
- Install (CLI): `npx skillmds@latest add yuga-hashimoto/pre-pr-review`
- Raw SKILL.md: https://api.skillmd.com/api/skills/yuga-hashimoto/pre-pr-review/raw
- Safety review: pending
- Works with: Claude Code, Claude.ai, OpenAI Codex
- Category: Coding & Dev Tools
- License: MIT
- Author: yuga-hashimoto (https://skillmd.com/u/yuga-hashimoto)
- Updated: 2026-09-17
- Page: https://skillmd.com/skills/yuga-hashimoto/pre-pr-review

---


# Pre-PR review

This repository expects an approved review BEFORE any pull request is created. The reviewer is
the `repo-reviewer` subagent, which carries the repository's architecture map and hard rules.
Nothing in CI enforces this: the check that used to fail a PR whose description carried no
approved report is gone, so the review is a convention the author keeps, not a gate that keeps
them.

## Workflow

1. **Sync and scope the diff**

   ```bash
   git fetch origin main
   git diff --stat origin/main...HEAD
   ```

   If the branch has no commits ahead of `origin/main`, stop: there is nothing to review.

2. **Run the local gates first** (cheap failures should never reach the reviewer):

   ```bash
   ./gradlew detekt spotlessCheck
   ```

   If `app/src/main/res/values*/strings.xml` changed, also run the key-parity check from
   `.github/workflows/i18n-check.yml` (every source key must exist in every locale file).
   A full Gradle build may be impossible on-device (x86_64 aapt2 on an arm64 device); that is
   expected — CI compiles. Fix everything that can run locally.

3. **Invoke the reviewer** with the task tool, subagent type `repo-reviewer`. Prompt it with:

   ```
   このブランチ（<branch name>、base: origin/main）のPR前レビューをお願いします。
   変更概要: <one or two sentences describing the change and why>
   ```

   The subagent reviews `git diff origin/main...HEAD` itself; do not paste the whole diff into the
   prompt.

4. **Handle the verdict**

   - `REQUEST_CHANGES`: fix every ブロッカー, then re-run from step 3. Repeat until `APPROVE`.
     Never open the PR while a ブロッカー is outstanding.
   - `APPROVE`: proceed. Consider 提案（非ブロッキング） items; apply the cheap, safe ones.

5. **Record the verdict in the PR description.** The PR body should carry the reviewer's report
   verbatim inside the marker block below, so a reader can see the review actually happened:

   ```markdown
   <!-- pre-pr-review: approved -->
   ## Pre-PR review

   <paste the reviewer's final report here>
   ```

   If a later push changes the branch materially, re-run this skill and update the block
   (`pre-pr-review: approved` must stay truthful for the HEAD commit).

## Rules

- Do not skip, summarize away, or forge the reviewer report; the block must be the subagent's
  actual output for the current HEAD. Nothing checks this now, which is exactly why it matters.
- If the `repo-reviewer` subagent is unavailable, say so in the PR — do not open it silently.
- Trivial bot PRs (e.g. Weblate translation sync) are exempt.