45ck overloading-overriding-reviewer
Purpose
Review whether overloading and overriding choices are safe, clear, and consistent with polymorphic intent.
Trigger this skill when
- Method dispatch is surprising or ambiguous.
- Hierarchies override behavior in inconsistent ways.
- There are many overloads with unclear intent.
Expected inputs
- class hierarchy
- method signatures
- dispatch expectations
- language rules
- behavioral contracts
Deliverables
- dispatch findings
- ambiguity risks
- inheritance behavior notes
- signature recommendations
- recommended changes
Operating procedure
- Identify the object-oriented concern this skill is meant to assess.
- Separate facts from inferred design intent.
- Review the current structure against OOP fundamentals: responsibility, invariants, ownership, exposure, abstraction, and lifecycle where relevant.
- Surface concrete risks, tradeoffs, and improvement options.
- Prefer minimal structural change that materially improves clarity or safety.
- Hand off to the next most relevant skill if the issue is broader than this skill alone can resolve.
Quality gates
- Findings are tied to concrete code structure or stated design intent.
- Recommendations explain why, not just what.
- Tradeoffs are stated when multiple designs could work.
- Output avoids style nitpicks unless they affect abstraction or maintainability.
Handoff targets
- inheritance-vs-composition-advisor
- visibility-modifier-reviewer
- naming-and-abstraction-reviewer
Output style
- Be explicit about uncertainty.
- Prefer short, evidence-based findings over long vague critique.
- Distinguish design defects from mere preference.
- End with recommended next actions.
Failure modes to avoid
- Do not invent framework constraints without evidence.
- Do not recommend sweeping refactors without naming the benefit.
- Do not confuse naming/style issues with true design problems unless they affect abstraction.
- Do not force inheritance, immutability, or statics as ideology.
Minimum output skeleton
## Summary
## Findings
## Risks
## Recommendations
## Tradeoffs
## Recommended next skill