Review Skill
Review the current diff for issues before committing.
Steps
Run
git diff HEAD(orgit diff --stagedif changes are staged) to see what changed.For each changed file, check:
- Correctness: Logic errors, off-by-one, wrong assumptions
- Rust conventions: Proper error handling (
?vsunwrap), no unnecessary clones, lifetimes make sense - SOLID / hexagonal: No leaking of infra types into domain, traits used correctly
- Tests: Are new behaviors covered? Are existing tests still valid?
- Security: No hardcoded secrets, no SQL injection, no unvalidated input at boundaries
If in a Rust workspace, run:
cargo clippy --all-targets 2>&1— report any warningscargo test --quiet 2>&1— report any failures
Produce a concise report:
- Issues (must fix before committing)
- Suggestions (optional improvements)
- Verdict: Ready to commit / Fix required
Rules
- Be direct. Lead with issues, not praise.
- Do not make changes unless the user explicitly asks.
- If the diff is clean, say so in one sentence.