Unified review method
Input: variant, target/flags, output root; optional same-snapshot prepared bundle.
Preparation resolves absent shape (light/branch) and target-kind
(changeset/plan/spec/doc). Output: native report and project-result envelope.
Before either shape, verify the Codebase Map prerequisite:
the entire project's map must already be complete.
Shape light: read only references/light.md in this method. Branch uses
team-review, or pr-review for a pull request, through these steps.
Do not delegate execution to another workflow or nested lifecycle scheduler.
Team-review Phase 1 runs in the coordinator's context with the complete run's
Codebase Map tools; it dispatches nothing and starts no analysis.
Keep one review preparation and final report owner; required workers retain isolation.
The isolated-worker binding is senior-review:isolated-worker, five tools and no
host extras: jobs, lenses 1-3, critic, history, hygiene and minimal-fix briefs run
on it. Where the host has not registered it, declare those workers unavailable
and the review incomplete; never substitute the host's generic worker or invent a role.
Dispatch in waves: every worker of one step that depends on no other goes out in a
single turn, and the coordinator waits for that wave's results without spending a
turn per worker. The README section "Esecuzione" gives the reason and an example.
Bind scope, authorization, budget, report path and delivered/failed outcome for
every brief. If no isolated binding exists, declare the missing independence.
- Load
senior-review:review-preparation, unless a prepared bundle exists.
Validate target, run, snapshot, knowledge schema/candidate/fingerprints/scope,
delivery IDs and applicable activation evidence or skip/gap reason. Reprepare
stale or incomplete bindings against this candidate, without another run or
duplicate dispatch.
- Read
references/<variant>.md. Dispatch validated jobs once each, in one wave, under
preparation's references/composition.md, including stack members. The roster
supplies coverage obligations, never another dispatch list. Core inputs remain
canonical in senior-review:review-quality-gates; stack members use their
provider definitions and shared preparation. Preserve knowledge_selection;
assign scoped knowledge_ids, fingerprint and exact catalog load/reference
bindings. Workers read assigned knowledge, apply it against source and return
knowledge_usage with scope, worker, hashes, references and application evidence.
Account for knowledge lenses in the same ledger.
No worker receives peer findings before delivery.
Use isolated contexts and the host's coordination mechanism.
Account for every selected worker before starting consolidation.
Each member retains canonical checks, coverage and finding references.
Context and verification keep separate inputs and deliveries.
- Load
senior-review:review-consolidation with native results. Finish it before
the variant's output/fix tail.
- Code review then reads
references/code-review-delivery.md; team/PR delivery
stays in consolidation. Execute delivery and authorized fixes once. Application
subtraction uses senior-review:application-cleanup-method; significant semantic
refactors return to the caller's development plan, never cleanup.
Read-only review preserves application files and preexisting edits.
Before accepted fixes use the host run-record mechanism for preflight,
authorizations, baseline, candidate gate and owned recovery. If it is absent,
declare those gates unavailable. Commit/publication require separate
authorization; review grants neither.
1---2name: review-method3description: >4 Unified review engine: the light review and the branch review (variants team-review and pr-review, and code-review), including signal-selected stack specialists.5 TRIGGER WHEN: the user asks to review current changes, a commit, a file, a plan, a specification, a document, a branch or a pull request for defects, or a host review entry/lifecycle phase runs a review.6 DO NOT TRIGGER WHEN: establishing the root cause of a reported failure without reviewing an artifact (use investigation-method), or removing dead code (use application-cleanup-method).7metadata:8 source: https://skillmd.com/skills/acaprino/review-method9---1011# Unified review method1213Input: variant, target/flags, output root; optional same-snapshot `prepared` bundle.14Preparation resolves absent `shape` (`light`/`branch`) and `target-kind`15(`changeset`/`plan`/`spec`/`doc`). Output: native report and project-result envelope.1617Before either shape, verify the [Codebase Map prerequisite](../../README.md#prerequisito):18the entire project's map must already be complete.1920**Shape `light`:** read only `references/light.md` in this method. Branch uses21`team-review`, or `pr-review` for a pull request, through these steps.2223Do not delegate execution to another workflow or nested lifecycle scheduler.24Team-review Phase 1 runs in the coordinator's context with the complete run's25Codebase Map tools; it dispatches nothing and starts no analysis.26Keep one review preparation and final report owner; required workers retain isolation.2728The isolated-worker binding is `senior-review:isolated-worker`, five tools and no29host extras: jobs, lenses 1-3, critic, history, hygiene and minimal-fix briefs run30on it. Where the host has not registered it, declare those workers unavailable31and the review incomplete; never substitute the host's generic worker or invent a role.32Dispatch in waves: every worker of one step that depends on no other goes out in a33single turn, and the coordinator waits for that wave's results without spending a34turn per worker. The README section "Esecuzione" gives the reason and an example.35Bind scope, authorization, budget, report path and delivered/failed outcome for36every brief. If no isolated binding exists, declare the missing independence.37381. Load `senior-review:review-preparation`, unless a prepared bundle exists.39 Validate target, run, snapshot, knowledge schema/candidate/fingerprints/scope,40 delivery IDs and applicable activation evidence or skip/gap reason. Reprepare41 stale or incomplete bindings against this candidate, without another run or42 duplicate dispatch.432. Read `references/<variant>.md`. Dispatch validated `jobs` once each, in one wave, under44 preparation's `references/composition.md`, including stack members. The roster45 supplies coverage obligations, never another dispatch list. Core inputs remain46 canonical in `senior-review:review-quality-gates`; stack members use their47 provider definitions and shared preparation. Preserve `knowledge_selection`;48 assign scoped `knowledge_ids`, fingerprint and exact catalog load/reference49 bindings. Workers read assigned knowledge, apply it against source and return50 `knowledge_usage` with scope, worker, hashes, references and application evidence.51 Account for knowledge lenses in the same ledger.52 No worker receives peer findings before delivery.53 Use isolated contexts and the host's coordination mechanism.54 Account for every selected worker before starting consolidation.55 Each member retains canonical checks, coverage and finding references.56 Context and verification keep separate inputs and deliveries.573. Load `senior-review:review-consolidation` with native results. Finish it before58 the variant's output/fix tail.594. Code review then reads `references/code-review-delivery.md`; team/PR delivery60 stays in consolidation. Execute delivery and authorized fixes once. Application61 subtraction uses `senior-review:application-cleanup-method`; significant semantic62 refactors return to the caller's development plan, never cleanup.6364Read-only review preserves application files and preexisting edits.65Before accepted fixes use the host run-record mechanism for preflight,66authorizations, baseline, candidate gate and owned recovery. If it is absent,67declare those gates unavailable. Commit/publication require separate68authorization; review grants neither.