Code Review Skill
Entry Criteria
Use to review a pull request, a local diff/branch, or to provide structured code-quality feedback.
Before Starting
Read root AGENTS.md and the relevant module AGENTS.md.
Review Scope
Evaluate in this order, citing the specific source rule for each finding:
- Correctness — does the code do what it claims (edge cases, error paths)? Check against
INVARIANTS.md(XML naming,S3Exceptionusage, layering). - Convention violations — any
INVARIANTS.mdviolation is Must fix. Also check the "Common Anti-Patterns" tables indocs/SPRING.mdanddocs/KOTLIN.mdfor Spring/Kotlin-specific violations (DI style, testing style,varon public API, etc.). - Test quality — coverage of new/changed paths, correct base class and conventions per
docs/TESTING.md. - Kotlin idioms — per
docs/KOTLIN.md. - Documentation —
CHANGELOG.md/README.md/KDoc updated per thedocumentskill's scenario table.
Output Format
- Must fix — blocks merge: correctness issues,
INVARIANTS.mdviolations, missing tests - Should fix — idiom/doc improvements; suggest the
refactororlintskill for pure style fixes rather than asking the author to add more code - Nit — optional style suggestions
Execution Steps
- Read root + relevant module
AGENTS.md. - Evaluate all five categories above, in order.
- Produce Must fix / Should fix / Nit findings with file/line references, each citing its source rule.
Completion Criteria
- All five categories evaluated
- Must fix / Should fix / Nit structure used, each finding cites its source rule
- CI gate readiness assessed (ktlint, Checkstyle, tests, Docker build)
-
CHANGELOG.mdcheck confirmed
Resources
AGENTS.md,INVARIANTS.md- Relevant module
AGENTS.md docs/KOTLIN.md,docs/SPRING.md,docs/TESTING.md