C#
Language guide. No scripts/.
Process skills that may load with this one: language-router Load-with list.
Iron law
Nullable reference types on. Dispose what you acquire. Async all the way down.
Tooling / verify
dotnet test --nologo
dotnet format --verify-no-changes # when the repo already uses it
Run on the touched project. Read failing tests. Do not add a second test framework.
Idioms a linter misses
- Nullable enabled. Treat warnings as errors if the project already does.
await using/usingforIDisposable/IAsyncDisposable.- Records / required members for values. Do not mutate DTOs in place if the file is already immutable.
- LINQ for clarity. Do not enumerate an expensive
IEnumerabletwice by accident. - Public APIs: properties over public fields.
IReadOnlyList<T>when the caller must not mutate.
Errors
- Throw specific exceptions. Do not swallow.
OperationCanceledExceptionis cancellation, not a generic failure.- Do not use exceptions for ordinary control flow.
Concurrency
async Task. Noasync voidexcept event handlers.- No
.Result/.Wait()on Tasks (deadlock + thread-pool starve). ConfigureAwait(false)only if the project already does in libraries.CancellationTokenis the last parameter and is plumbed.
Testing
- xUnit / NUnit / MSTest as the repo chose.
- Test behavior through the public type.
IHttpClientFactory/ time / RNG are the mock boundaries. async Tasktests. No.Resultin tests either.
PR review
- New
async voidin library code: reject. - New
IDisposablewithoutusingat call sites. - Nullable suppression (
!): local and named, or reject. - Public surface: breaking changes to nullability are breaking.
Security
- Parameterized SQL. No string concat into commands.
- No
BinaryFormatter/ insecure deserializers. Process.Start: argument array, never a concatenated command line.- Secrets not in config committed to git. User-secrets / env as the project already does.
Always
- Dispose / async-dispose.
awaitthe Task.- Tests for the new branch.
Ask first
- Disabling nullable for a file.
- Adding an analyzer package the repo does not have.
- Mixing sync-over-async to "keep this controller sync."
Never
async voidin library code..Result/.Wait()on production paths.- Public fields on API types.
BinaryFormatter.
Red flags
- "I'll .Result it to keep this sync"
- "nullable is too noisy"
- "we dispose it in the finalizer"