Security Review Checklist
When reviewing security-related changes:
- Secrets: Ensure no credentials, tokens, or secrets are hardcoded or logged
- Auth configuration: Verify OIDC/Keycloak config changes are backward-compatible
- Access control: Check role-based access (
sr-admin,sr-developer,sr-readonly) is enforced - Error handling: Confirm no stack traces or internal details leak to API responses
- Dependencies: Flag any new dependencies that handle crypto or auth
- TLS: Verify TLS configuration uses Quarkus config properties, not custom code
- Tests: Ensure auth-related changes have integration tests with Keycloak testcontainer