Performance review
For a full three-pass pre-commit review, start with review. This skill is pass 2 only, in depth.
Full checklist → review/references/code-review-passes.md
Checklist
- Scope — changed files or named hot path; discover-project if stack unclear
- Evidence — prefer traces, slow queries, profiles, or repro metrics over guesses
- Request path — blocking I/O, sync work, N+1, over-fetch, missing pagination
- Data layer — missing filters/indexes (when visible); large payloads
- Caching — redundant computation; cache invalidation risks
- Network — excessive RPC/API calls; chatty clients
- UI — redundant renders, heavy bundles, layout thrash (when frontend)
- Resources — memory leaks; inefficient file/stream handling
Per finding
| Field | Content |
|---|---|
| Severity | Critical / High / Medium / Low |
| File / location | Path + symbol |
| Problem | What is inefficient |
| Impact | Latency, throughput, cost, UX |
| Fix | Minimal change; measure if possible |
Rules
- Do not optimize without a stated problem or measurement
- Do not trade readability for nanoseconds unless the user asked
- Implement fixes only when the user asked → implement
- For production incidents → debug first if cause is unknown
Related skills
- review — three-pass pre-commit including quick performance scan
- debug — unknown slowness or regressions
- implement — apply approved optimizations
- test — benchmarks or load tests when the project has them