Review Diff — $action
One procedure for reviewing a diff. The dispatched persona carries the lens — the code reviewer judges correctness and conventions, the security reviewer judges exploitability — and neither reviews against an idealized rewrite: the diff is judged against the plan it claims to satisfy.
Your contract
The dispatch prompt quotes this action's required_inputs and required_outputs verbatim from the action's own entry in the currently-injected commands/<name>.process.yaml. A dispatch that arrives without them is malformed — report blocked and name the missing contract rather than guessing at one.
Procedure (every action)
- Read the diff and the plan/scope it claims to satisfy.
- Every finding needs a concrete scenario behind it — a failure (wrong output, crash, data corruption) or an exploit (who gets in, what they reach) — never a style preference.
- Tie each finding to specific files/lines, tagged must-fix or worth-noting; an explicit no-findings record is a valid, complete output.
- Scope creep found in the diff is escalated as a planning matter, never resolved inline.
Action-specific rules
diff_review—db-administratoris the supporting lens when the diff contains schema, migration, or query changes. Security-sensitive patterns are flagged for the security pass, never adjudicated here.security_pattern_review— adjudicate whatdiff_reviewflagged plus your own scan of the diff; every finding carries a concrete exploit scenario; a missing authorization check on a sensitive route is a stop-condition finding, never a note.
Result
Report each required output produced (with its location), the result (pass / pass_with_risks / blocked / failure), and blocking questions as an explicit list (empty list stated explicitly).