bsafronov Review Requirements
Determine whether a change delivers the agreed outcome and only that outcome. Keep the review read-only.
- Pin the change scope. Use the supplied comparison point; otherwise infer the current branch's merge base when unambiguous. Confirm the diff is non-empty.
- Pin the requirements source from the user request, linked issue, PR, or named specification. Ask only when no authoritative source can be identified.
- Extract every explicit behavior, constraint, and non-goal. Do not invent requirements from design preference.
- Trace each requirement through changed code, tests, and affected boundaries. Classify it as satisfied, missing, partial, or incorrect. Identify behavior added outside the agreed scope.
- Report actionable gaps first. For each gap, cite the requirement source and the smallest relevant changed location, then state expected behavior, actual behavior, and impact. Verify that every cited source path and one-based line exists; do not substitute diff line numbers for source line numbers.
- If every requirement is satisfied, say so. Report material evidence gaps or unverifiable requirements separately.
Use Missing, Partial, Incorrect, and Scope as finding labels. Keep
the report limited to requirement-conformance gaps. Leave optional design advice
and unrelated defects to their separate review outcomes.
Stop when every explicit requirement and non-goal maps to implementation evidence or an actionable finding, with no code changes made.