You Dont Need React Custom Hooks

You Don't Need React Custom Hooks

Overview

A React custom hook is not the default unit of abstraction; it is the last option. Custom hooks make it easy to add dependencies and side effects, which can give a module too many responsibilities and create tight coupling internally. These hidden dependencies make code harder to trace, so modules that depend on React need stricter responsibility boundaries than ordinary modules.

This skill does not ban custom hooks. Instead, before creating one, first check whether an ordinary module is enough. Use a hook only when its concern, responsibility, role, and dependencies are clear.

When to Use

Use this skill when:

• Evaluating React component or custom hook code
• Designing or implementing a new React component or custom hook
• Refactoring an existing custom hook or extracting a new custom hook from a React component

Do not use this skill when:

• Refactoring ordinary functions or modules unrelated to React
• Only calling an already validated general-purpose hook, without creating or modifying a hook

Core Rules

Before creating or suggesting a custom hook, always ask:

1. Can this logic be expressed as an ordinary function or module without React hooks?
2. Can the custom hook's single responsibility be stated in one sentence?
3. Are this hook's dependencies also dependencies that its callers should be allowed to own?
4. If this hook were deleted and inlined into the caller, would the code become clearer?

Do not print these questions as a mechanical checklist. But when creating, suggesting, or refactoring a custom hook, naturally explain why the code must be a hook instead of being inlined into the component or extracted as an ordinary function/module.

Alternatives to Consider First

Consider smaller alternatives before a custom hook.

The first two alternatives are immediately applicable. The last two should expose a structural problem instead of hiding it behind a hook. If the structural change is in scope, apply Kent Beck's Tidy First principle and make the structural change first. If it is out of scope, propose it as a separate refactoring.

Invalid Reasons for Creating a Hook

The following are not valid reasons to create a custom hook.

Always Good Custom Hooks

React state transitions are the core responsibility

This applies when state values and state transitions are the hook's essential responsibility. These hooks do not directly depend on external data.

Example:

function useDisclosure(initialOpen = false) {
  const [isOpen, setIsOpen] = useState(initialOpen);
  const open = useCallback(() => setIsOpen(true), []);
  const close = useCallback(() => setIsOpen(false), []);
  const toggle = useCallback(() => setIsOpen((current) => !current), []);

  return { isOpen, open, close, toggle };
}

This hook owns one state machine: open or closed. It has no hidden external dependency.

React lifecycle/effects are the core responsibility

This applies when the logic cannot be expressed as an ordinary function and React rendering, subscriptions, cleanup, refs, or DOM integration are central to solving the problem.

Example:

function useOnClickOutside(ref: RefObject<HTMLElement | null>, onOutside: () => void) {
  useEffect(() => {
    function handlePointerDown(event: PointerEvent) {
      if (!ref.current?.contains(event.target as Node)) {
        onOutside();
      }
    }

    document.addEventListener("pointerdown", handlePointerDown);
    return () => document.removeEventListener("pointerdown", handlePointerDown);
  }, [onOutside, ref]);
}

The browser subscription and its cleanup require React lifecycle handling, so an ordinary function cannot replace this hook.

Always Bad Custom Hooks

React-independent calculations

Do not create a hook for calculations that have no React dependency. Use an ordinary function instead.

// Bad
function useCartTotalPrice(items: CartItem[]) {
  return useMemo(
    () => items.reduce((total, item) => total + item.price * item.quantity, 0),
    [items],
  );
}

// Good
function calculateCartTotalPrice(items: CartItem[]) {
  return items.reduce((total, item) => total + item.price * item.quantity, 0);
}

Thin wrappers

Do not create a wrapper that only renames an existing dependency. In these cases, it is usually better to create an ordinary function for the arguments passed into the existing hook or for the value returned from it.

// Bad
function useUserProfileQuery(userId: string) {
  return useQuery(userProfileQueryOptions({ userId }));
}

// Good
const query = useQuery(userProfileQueryOptions({ userId }));

// Bad
function useWorkspaceRouteParams() {
  const params = useParams();
  return useMemo(() => parseWorkspaceRouteState(params), [params]);
}

// Good
const params = useParams();
const { workspaceId } = useMemo(() => parseWorkspaceRouteState(params), [params]);

Custom Hooks That Require Judgment

Business-logic hooks can be acceptable, but they are not always good. Most bad custom hooks happen here.

Examples that can be good or bad:

useUserProfileForm(initialProfile);
useCheckoutPaymentSelection(paymentMethods);
useProductImageCarousel(images);
useCommentComposer(initialText);

Judge them by whether the hook's responsibility is clear, whether it hides dependencies the caller should know about, and whether it traps logic inside the hook in a way that makes the component unable to control the flow.

Bad custom hook smells

These are signs that responsibility boundaries have become blurry.

function useUserProfile({ userId }: { userId: string }) {
  const userQuery = useQuery(userProfileQueryOptions({ userId }));
  const [searchParams, setSearchParams] = useSearchParams();
  const currentTab = parseUserProfileTab(searchParams);
  const form = useForm<UserProfileFormValues>();
  const updateUserProfile = useMutation(updateUserProfileMutationOptions());
  const notify = useNotifier();

  function navigateTab(tab: UserProfileTab) {
    setSearchParams({ tab });
  }

  function submit(values: UserProfileFormValues) {
    updateUserProfile.mutate(
      { userId, ...values },
      { onSuccess: () => notify("Profile saved") },
    );
  }

  return {
    user: userQuery.data,
    isLoading: userQuery.isLoading,
    error: userQuery.error,
    refetch: userQuery.refetch,
    currentTab,
    navigateTab,
    form,
    submit,
    notify,
  };
}

This hook hides dependencies on external data fetching, tab state, routing, form state and submission, and notifications. The component became shorter, but the behavior became harder to predict. It also makes a screen-specific flow appear reusable, exposing other components to dependencies and control flow they should own.

Keep those dependencies visible in the component instead:

function UserProfilePage({ userId }: { userId: string }) {
  const userQuery = useQuery(userProfileQueryOptions({ userId }));
  const [searchParams, setSearchParams] = useSearchParams();
  const currentTab = parseUserProfileTab(searchParams);
  const form = useForm<UserProfileFormValues>();
  const updateUserProfile = useMutation(updateUserProfileMutationOptions());
  const notify = useNotifier();

  return <div>{/* ... */}</div>;
}

This component may still need a split, but its data fetching, routing, form, mutation, and notification dependencies are explicit. The component controls the flow instead of delegating it to an opaque hook.

Better directions:

• Put calculations, validation, and transformation in ordinary functions.
• Keep external data fetching inline in the component with hooks such as useQuery, or make a separate hook only when appropriate.
• Keep form state inline in the component with hooks such as useForm, or make a separate hook only when appropriate.
• Keep routing and notifications inline in the component, and pass handlers as arguments when needed.
• Split the component if its responsibility is too large. But avoid pushing too much state or logic into child components in a way that makes the flow harder to follow.
• Code complexity is bounded by business complexity plus overhead. If the design is sound and the component is only orchestrating behavior but the code is still complex, consider a Controller Pattern Hook only if the project already uses that pattern.

Inlining can be better than abstraction. A component that is longer because it uses lifting state up but still controls the flow is better than a shorter component whose dependencies and flow are hard to understand. An ideal component is composed from small modules, not from one large hook.

When Controller Pattern Hooks Are Acceptable

A Controller Pattern Hook is a project-specific design strategy, not a general recommendation. It is allowed only when the project already uses this pattern. The project may call it by another name, so before introducing it, directly confirm that code similar to the examples already appears repeatedly.

A Controller Pattern Hook separates business logic from UI to improve readability or testing strategy. It always has a 1:1 relationship with a component, and it contains all of that component's code except rendering/markup.

The responsibility of a Controller Pattern Hook is "the target component's functionality/behavior," so its internal logic can be tightly coupled and can perform multiple roles. However, it cannot own responsibilities that the target component itself could not own. In other words, a Controller Pattern Hook is only code separation, so it follows the rules for React components, not special rules for custom hooks.

Example:

export function UserProfilePage({ userId }: { userId: string }) {
  // Its return shape resembles `useUserProfile`, but unlike `useUserProfile`, this controller hook has a 1:1 relationship with UserProfilePage.
  const { ...controller } = useUserProfilePageController({ userId });

  return <div>{/* ... */}</div>;
}

Allowed only when:

• It has a 1:1 relationship with a specific component.
• It is colocated in the same directory.
• Its name clearly says it is a controller.
• It is not intended for reuse.
• It owns only responsibilities that the target component may own.
• This pattern is already used in the project.

If one Controller Pattern Hook starts being used by multiple components, that is a failure signal. If you want to split a Controller Pattern Hook into multiple hooks, the problem is not custom-hook design; revisit the component/layer design.

Common Mistakes

Final Rule

Custom hooks are not a tool for shortening code. Choose a custom hook only when React dependencies such as state, effects, lifecycle, subscriptions, cleanup, or refs are essential to a single responsibility. If existing custom-hook code violates this standard, before splitting it into more hooks, first check whether it can be moved back into ordinary functions, ordinary modules, or component-local logic, and propose that as a separate refactoring when needed.