Plan Review Code Quality

Reviews code organization, maintainability, local patterns, error handling, and diagram freshness.

ChristopherAlphonse 1b7d1e1 1.1 KB Updated

File contents

Plan Review Code Quality

Review whether the plan fits the codebase cleanly.

Guardrails

  • Prefer existing local patterns over new abstractions.
  • Flag overengineering and underengineering with concrete evidence.
  • Do not recommend cleanup outside the plan's changed surface.
  • Tie recommendations to maintainability, correctness, or verification impact.

Evaluate

  • Module boundaries and naming.
  • Reuse of existing helpers, conventions, and patterns.
  • DRY risks and repeated logic.
  • Error handling: named errors, callers, user-visible behavior, and tests.
  • Edge cases: nil/empty inputs, upstream failure, retries, stale state, repeated actions.
  • Technical debt hotspots.
  • Over-engineering and under-engineering.
  • Existing ASCII diagrams in nearby files; flag stale or missing diagrams.

Output

Return code quality findings ordered by severity. For each issue include:

  • Finding
  • Evidence
  • Recommendation
  • Whether the plan needs a TODO, plan edit, test, or implementation change

ChristopherAlphonse/calphonse-skills/tree/main/plan-review-code-quality commit 1b7d1e17aa

Frequently asked questions

npx skillmds@latest add christopheralphonse/plan-review-code-quality