🔍 The Architect's Guide to Code Review: Philosophy & Tactics
When to use
Use this skill when the task is primarily about engineering and this guidance is the most relevant operating rule set.
When not to use
Do not use this skill as the primary guide when another skill has a tighter domain fit for the requested output.
Trigger cues
- Request explicitly references
developer-code-review-rules or this source file.
- Request language includes terms like: developer, code, review, rules.
- Keywords include: implementation, TDD, tests, architecture, performance, web security, code review.
Routing boundary
- Primary for code quality, test strategy, security hardening, and performance engineering.
- Do not use as primary for product positioning or conversion copy strategy.
Inputs required
- Goal or task request
- Current constraints (time, scope, platform, risk)
- Existing artifacts (code, docs, screenshots, metrics) when available
- Source of truth:
subagents/rules/developer/developer-code-review-rules.md
Instructions
- Read references/source.md first.
- Extract the non-negotiable rules and translate them into a short execution checklist.
- Apply the checklist to the current task, produce concrete outputs, and avoid abstract recommendations.
- Validate outcomes with evidence (tests, screenshots, logs, diffs, or written audit findings).
- Record decisions and tradeoffs so another engineer can continue without re-discovery.
Completion gate
Before reporting completion, verify the applicable binary contracts in evals/cases.json: every blocking finding has precise evidence and a complete risk contract, secrets are never reproduced, and style preferences remain non-blocking.
Output format
- Primary decision/output: Implementation approach, test coverage, and risk controls.
- Summary: one-paragraph decision or result
- Actions: compact checklist with owners and status
- Evidence: links/paths to artifacts proving completion
1---2name: developer-code-review-rules3description: Review pull requests or audit repositories for correctness, security, performance, test risk, architecture, dependencies, developer experience, documentation, and grounded product direction. Use for code review, repository audits, evidence-backed findings, false-positive vetting, risk assessment, prioritization, or deciding which improvements should become implementation plans.4---56# 🔍 The Architect's Guide to Code Review: Philosophy & Tactics78## When to use910Use this skill when the task is primarily about engineering and this guidance is the most relevant operating rule set.1112## When not to use1314Do not use this skill as the primary guide when another skill has a tighter domain fit for the requested output.1516## Trigger cues1718- Request explicitly references `developer-code-review-rules` or this source file.19- Request language includes terms like: developer, code, review, rules.20- Keywords include: implementation, TDD, tests, architecture, performance, web security, code review.2122## Routing boundary2324- Primary for code quality, test strategy, security hardening, and performance engineering.25- Do not use as primary for product positioning or conversion copy strategy.2627## Inputs required2829- Goal or task request30- Current constraints (time, scope, platform, risk)31- Existing artifacts (code, docs, screenshots, metrics) when available32- Source of truth: `subagents/rules/developer/developer-code-review-rules.md`3334## Instructions35361. Read [references/source.md](references/source.md) first.372. Extract the non-negotiable rules and translate them into a short execution checklist.383. Apply the checklist to the current task, produce concrete outputs, and avoid abstract recommendations.394. Validate outcomes with evidence (tests, screenshots, logs, diffs, or written audit findings).405. Record decisions and tradeoffs so another engineer can continue without re-discovery.4142## Completion gate4344Before reporting completion, verify the applicable binary contracts in `evals/cases.json`: every blocking finding has precise evidence and a complete risk contract, secrets are never reproduced, and style preferences remain non-blocking.4546## Output format4748- Primary decision/output: Implementation approach, test coverage, and risk controls.49- Summary: one-paragraph decision or result50- Actions: compact checklist with owners and status51- Evidence: links/paths to artifacts proving completion
coreyone