Uncle Bob Craft V2

Uncle Bob Craft

Overview

This public intake copy packages plugins/antigravity-awesome-skills/skills/uncle-bob-craft from https://github.com/sickn33/antigravity-awesome-skills into the native Omni Skills editorial shape without hiding its origin.

Use it when the operator needs the upstream workflow, support files, and repository context to stay intact while the public validator and private enhancer continue their normal downstream flow.

This intake keeps the copied upstream files intact and uses the external_source block in metadata.json plus ORIGIN.md as the provenance anchor for review.

Uncle Bob Craft Apply Robert C. Martin (Uncle Bob) criteria for code review and production: Clean Code, Clean Architecture, The Clean Coder, Clean Agile, and design-pattern discipline. This skill is complementary to the existing @clean-code skill (which focuses on the Clean Code book) and to your project's linter/formatter—it does not replace them.

Imported source sections that did not map cleanly to the public headings are still preserved below or in the support files. Notable imported sections: Aggregators by Source, Design Patterns: Use vs Misuse, Smells and Heuristics (Summary), Review vs Production, How It Works, Common Pitfalls.

When to Use This Skill

Use this section as the trigger filter. It should make the activation boundary explicit before the operator loads files, runs commands, or opens a pull request.

• Code review: Apply Dependency Rule, boundaries, SOLID, and smell heuristics; suggest concrete refactors.
• Refactoring: Decide what to extract, where to draw boundaries, and whether a design pattern is justified.
• Architecture discussion: Check layer boundaries, dependency direction, and separation of concerns.
• Design patterns: Assess correct use vs cargo-cult or overuse before introducing a pattern.
• Estimation and professionalism: Apply Clean Coder ideas (saying no, sustainable pace, three-point estimates).
• Agile practices: Reference Clean Agile (Iron Cross, TDD, refactoring, pair programming) when discussing process.

Operating Table

Workflow

This workflow is intentionally editorial and operational at the same time. It keeps the imported source useful to the operator while still satisfying the public intake standards that feed the downstream enhancer flow.

1. Confirm the user goal, the scope of the imported workflow, and whether this skill is still the right router for the task.
2. Read the overview and provenance files before loading any copied upstream support files.
3. Load only the references, examples, prompts, or scripts that materially change the outcome for the current request.
4. Execute the upstream workflow while keeping provenance and source boundaries explicit in the working notes.
5. Validate the result against the upstream expectations and the evidence you can point to in the copied files.
6. Escalate or hand off to a related skill when the work moves out of this imported workflow's center of gravity.
7. Before merge or closure, record what was used, what changed, and what the reviewer still needs to verify.

Imported Workflow Notes

Imported: Overview

This skill aggregates principles from Uncle Bob's body of work for reviewing and writing code: naming and functions (via @clean-code), architecture and boundaries (Clean Architecture), professionalism and estimation (The Clean Coder), agile values and practices (Clean Agile), and design-pattern use vs misuse. Use it to evaluate structure, dependencies, SOLID in context, code smells, and professional practices. It provides craft and design criteria only—not syntax or style enforcement, which remain the responsibility of your linter and formatter.

Imported: Aggregators by Source

Examples

Example 1: Ask for the upstream workflow directly

Use @uncle-bob-craft-v2 to handle <task>. Start from the copied upstream workflow, load only the files that change the outcome, and keep provenance visible in the answer.

Explanation: This is the safest starting point when the operator needs the imported workflow, but not the entire repository.

Example 2: Ask for a provenance-grounded review

Review @uncle-bob-craft-v2 against metadata.json and ORIGIN.md, then explain which copied upstream files you would load first and why.

Explanation: Use this before review or troubleshooting when you need a precise, auditable explanation of origin and file selection.

Example 3: Narrow the copied support files before execution

Use @uncle-bob-craft-v2 for <task>. Load only the copied references, examples, or scripts that change the outcome, and name the files explicitly before proceeding.

Explanation: This keeps the skill aligned with progressive disclosure instead of loading the whole copied package by default.

Example 4: Build a reviewer packet

Review @uncle-bob-craft-v2 using the copied upstream files plus provenance, then summarize any gaps before merge.

Explanation: This is useful when the PR is waiting for human review and you want a repeatable audit packet.

Imported Usage Notes

Imported: Examples

Example 1: Code review prompt (copy-pasteable)

Use this to ask for an Uncle Bob–oriented review:

Please review this change using Uncle Bob craft criteria (@uncle-bob-craft):
1. Dependency Rule and boundaries — do dependencies point inward?
2. SOLID in context — any violations in the touched code?
3. Smells — list rigidity, fragility, immobility, viscosity, needless complexity/repetition, or opacity.
4. Suggest one or two concrete refactors (e.g., extract function, invert dependency).
Do not duplicate lint/format; focus on structure and design.

Example 2: Before/after (extract and name)

Before (opacity, does more than one thing):

def process(d):
    if d.get("t") == 1:
        d["x"] = d["a"] * 1.1
    elif d.get("t") == 2:
        d["x"] = d["a"] * 1.2
    return d

After (clear intent, single level of abstraction):

def apply_discount(amount: float, discount_type: int) -> float:
    if discount_type == 1:
        return amount * 1.1
    if discount_type == 2:
        return amount * 1.2
    return amount

def process(order: dict) -> dict:
    order["x"] = apply_discount(order["a"], order.get("t", 0))
    return order

Best Practices

Treat the generated public skill as a reviewable packaging layer around the upstream repository. The goal is to keep provenance explicit and load only the copied source material that materially improves execution.

• ✅ Use @clean-code for naming, functions, comments, and formatting; use this skill for architecture, boundaries, SOLID, smells, and process.
• ✅ In review, name the smell or principle (e.g., "Dependency Rule violation: use case imports from the web framework").
• ✅ Suggest at least one concrete refactor per review (extract, rename, invert dependency).
• ✅ Run the project linter and formatter separately; this skill does not replace them.
• ❌ Do not use this skill to enforce syntax or style; that is the linter's job.
• ❌ Do not add design patterns without a clear duplication or variation reason.
• Keep the imported skill grounded in the upstream repository; do not invent steps that the source material cannot support.

Imported Operating Notes

Imported: Best Practices

• ✅ Use @clean-code for naming, functions, comments, and formatting; use this skill for architecture, boundaries, SOLID, smells, and process.
• ✅ In review, name the smell or principle (e.g., "Dependency Rule violation: use case imports from the web framework").
• ✅ Suggest at least one concrete refactor per review (extract, rename, invert dependency).
• ✅ Run the project linter and formatter separately; this skill does not replace them.
• ❌ Do not use this skill to enforce syntax or style; that is the linter's job.
• ❌ Do not add design patterns without a clear duplication or variation reason.

Troubleshooting

Problem: The operator skipped the imported context and answered too generically

Symptoms: The result ignores the upstream workflow in plugins/antigravity-awesome-skills/skills/uncle-bob-craft, fails to mention provenance, or does not use any copied source files at all. Solution: Re-open metadata.json, ORIGIN.md, and the most relevant copied upstream files. Check the external_source block first, then restate the provenance before continuing.

Problem: The imported workflow feels incomplete during review

Symptoms: Reviewers can see the generated SKILL.md, but they cannot quickly tell which references, examples, or scripts matter for the current task. Solution: Point at the exact copied references, examples, scripts, or assets that justify the path you took. If the gap is still real, record it in the PR instead of hiding it.

Problem: The task drifted into a different specialization

Symptoms: The imported skill starts in the right place, but the work turns into debugging, architecture, design, security, or release orchestration that a native skill handles better. Solution: Use the related skills section to hand off deliberately. Keep the imported provenance visible so the next skill inherits the right context instead of starting blind.

Related Skills

• @00-andruia-consultant - Use when the work is better handled by that native specialization after this imported skill establishes context.
• @00-andruia-consultant-v2 - Use when the work is better handled by that native specialization after this imported skill establishes context.
• @10-andruia-skill-smith - Use when the work is better handled by that native specialization after this imported skill establishes context.
• @10-andruia-skill-smith-v2 - Use when the work is better handled by that native specialization after this imported skill establishes context.

Additional Resources

Use this support matrix and the linked files below as the operator packet for this imported skill. They should reflect real copied source material, not generic scaffolding.

• clean-agile.md
• clean-architecture.md
• clean-coder.md
• design-patterns.md
• code-review-checklist.md
• README.md

Imported Reference Notes

Imported: Design Patterns: Use vs Misuse

• Use patterns when they solve a real design problem (e.g., variation in behavior, lifecycle, or cross-cutting concern), not to look "enterprise."
• Avoid cargo cult: Do not add Factory/Strategy/Repository just because the codebase "should" have them; add them when duplication or rigidity justifies the abstraction.
• Signs of misuse: Pattern name in every class name, layers that only delegate without logic, patterns that make simple code harder to follow.
• Rule of thumb: Introduce a pattern when you feel the third duplication or the second reason to change; name the pattern in code or docs so intent is clear.

Imported: Smells and Heuristics (Summary)

Full lists (including heuristics C1–T9-style) are in reference.md. Use these in review to name issues and suggest refactors (extract, move dependency, introduce boundary).

Imported: Review vs Production

Imported: How It Works

When reviewing code

1. Boundaries and Dependency Rule: Check that dependencies point inward (e.g., use cases do not depend on UI or DB details). See references/clean-architecture.md.
2. SOLID in context: Check Single Responsibility, Open/Closed, Liskov, Interface Segregation, Dependency Inversion where they apply to the changed code.
3. Smells: Scan for rigidity, fragility, immobility, viscosity, needless complexity/repetition, opacity; list them with file/area.
4. Concrete suggestions: Propose one or two refactors (e.g., "Extract this into a function named X," "Introduce an interface so this layer does not depend on the concrete DB client").
5. Tests and craft: Note if tests exist and if the change respects sustainable pace (no obvious "we'll fix it later" comments that violate professionalism).

When writing or refactoring code

1. Prefer small, single-purpose functions and classes; use @clean-code for naming and structure.
2. Keep dependencies pointing inward; put business rules in the center, adapters at the edges.
3. Introduce design patterns only when duplication or variation justifies them.
4. Refactor in small steps with tests staying green.

Imported: Common Pitfalls

• Problem: Treating every class as needing a Factory or Strategy. Solution: Introduce patterns only when you have a real design need (third duplication, second axis of change).

• Problem: Review only listing "violates SOLID" without saying where or how. Solution: Point to the file/function and which principle (e.g., "SRP: this function parses and persists; split into parse and persist").

• Problem: Skipping the project linter because "we applied Uncle Bob." Solution: This skill is about craft and design; always run the project's lint and format.

Imported: Limitations

• Does not replace the project linter or formatter. Run lint and format separately; this skill gives design and craft criteria only.
• Does not replace automated tests. It can remind you to write tests (Clean Coder, Clean Agile) but does not run or generate them.
• Complementary to tooling. Use it alongside existing CI, lint, and test suites.
• No syntax or style enforcement. It focuses on structure, dependencies, smells, and professional practice, not on brace style or line length.
• Summaries, not the books. Full Clean Code heuristics, component principles (REP/CCP/CRP, ADP/SDP/SAP), and detailed stories are in the books; we reference the most used parts. See reference.md "Scope and attribution."