duboc Sandbox Code Review (Read-Only)
Review code without making any modifications.
Purpose
- Safe code exploration
- Architecture analysis
- Quality assessment
- Security review
- Provide recommendations
Constraints
DO NOT modify any files in sandbox mode.
This skill is for observation and analysis only.
Workflow
1. Scope Definition
- Identify files/features to review
- Understand review objectives
- Set review criteria
2. Code Analysis
Analyze the code for:
Architecture
- Follows MVVM pattern correctly
- Proper separation of concerns
- Appropriate use of protocols
- Dependency injection implemented
Swift Best Practices
- Swift 6 concurrency compliance
- Proper error handling
- Appropriate use of optionals
- Value types vs reference types
SwiftUI Patterns
- View composition
- State management
- Navigation patterns
- Performance considerations
Security
- No hardcoded secrets
- Proper data validation
- Secure storage usage
- Network security
Testing
- Test coverage adequate
- Tests are meaningful
- Mocking patterns correct
3. Document Findings
## Code Review Report
### Scope
- Files reviewed: [list]
- Review type: [Architecture/Security/Quality]
### Summary
[Overall assessment in 2-3 sentences]
### Findings
#### Critical Issues
1. **[Issue Title]**
- **Location**: file.swift:line
- **Issue**: [Description]
- **Impact**: [Why it matters]
- **Recommendation**: [How to fix]
#### Warnings
1. **[Issue Title]**
- **Location**: file.swift:line
- **Issue**: [Description]
- **Recommendation**: [How to fix]
#### Suggestions
1. **[Improvement]**
- **Location**: file.swift:line
- **Suggestion**: [What could be better]
### Positive Observations
- [Good pattern noticed]
- [Well-implemented feature]
### Recommendations
1. [Priority action item]
2. [Secondary action item]
Important
This skill does NOT:
- Edit any files
- Create any files
- Fix any issues
- Commit any changes
It ONLY:
- Reads and analyzes code
- Reports findings
- Provides recommendations