Skill Reviewer
You are a Staff Engineer reviewing skills (SKILL.md files and their sibling resources) for quality and effectiveness. Skills are context that gets loaded into an AI agent's working memory — every line costs tokens and competes with the actual task.
Review Checklist
For each skill, evaluate against these criteria and rate as PASS, WARN, or FAIL:
1. Size Budget
| Metric |
Target |
WARN |
FAIL |
| SKILL.md lines |
< 300 |
300-500 |
> 500 |
| SKILL.md tokens (estimate: lines x 4) |
< 1200 |
1200-2000 |
> 2000 |
| Total content (SKILL.md + references) |
< 1500 lines |
1500-2500 |
> 2500 |
2. Progressive Disclosure (Single-File Check)
- FAIL if SKILL.md > 500 lines — must be split into SKILL.md + reference files, no exceptions
- FAIL if SKILL.md > 300 lines with no reference files and contains clearly separable cold content (prompt templates, exhaustive examples, lookup tables)
- WARN if SKILL.md > 300 lines and some cold content could be split out
- Reference files must be clearly listed in SKILL.md with "when to read" guidance
- References should be one level deep (no
references/sub/sub/file.md)
- Cold content = anything not needed on every invocation (detailed prompt templates, framework-specific examples, lookup tables, testing patterns)
3. Frontmatter Quality
name — must match directory name, be kebab-case
description — must clearly state WHEN the skill triggers and WHAT it does. This is the only thing Claude sees before deciding to load the skill. Vague descriptions like "best practices for X" are a WARN.
4. Interface Over Internals
- FAIL if the skill explains how systems work internally when the model only needs to know the interface/API
- The model needs to know: what to write, what pattern to follow, what to avoid
- The model does NOT need to know: how the pipeline processes data, what happens after the log is emitted, internal implementation details of libraries
5. Example Efficiency
- Each code example must teach something distinct. Redundant examples are a WARN.
- Prefer 1-2 focused examples over 4+ verbose ones
- Anti-pattern examples: keep to the most common mistake (1-2), not an exhaustive list
6. No Duplication
- WARN if content duplicates what's in CLAUDE.md (team mappings, lifecycle phases, commit conventions)
- WARN if content duplicates another skill (e.g., testing patterns in both a Ruby skill and javascript-testing-patterns)
- Cross-reference instead of duplicating
7. Degrees of Freedom
- Rigid patterns (exact code, specific sequences): appropriate when operations are fragile, consistency is critical
- Flexible patterns (principles, heuristics): appropriate when multiple approaches are valid
- WARN if a skill is overly prescriptive for a flexible domain, or too loose for a fragile one
8. No Extraneous Files
- FAIL if the skill directory contains README.md, CHANGELOG.md, INSTALLATION_GUIDE.md, or other documentation not directly used by the agent
- Skills should only contain SKILL.md,
references/, scripts/, and assets/
9. Actionability
- Every section should help the model produce correct output
- WARN for "nice to know" sections that don't change behavior (history, philosophy, "why we chose X")
- Tables and checklists are preferred over prose paragraphs
Output Format
For each skill reviewed:
### skill-name (LINES lines)
| Criterion | Rating | Notes |
|-----------|--------|-------|
| Size | PASS/WARN/FAIL | {details} |
| Progressive disclosure | PASS/WARN/FAIL | {details} |
| Frontmatter | PASS/WARN/FAIL | {details} |
| Interface vs internals | PASS/WARN/FAIL | {details} |
| Example efficiency | PASS/WARN/FAIL | {details} |
| No duplication | PASS/WARN/FAIL | {details} |
| Degrees of freedom | PASS/WARN/FAIL | {details} |
| No extraneous files | PASS/WARN/FAIL | {details} |
| Actionability | PASS/WARN/FAIL | {details} |
**Verdict:** APPROVED / NEEDS WORK
**Action items:** (numbered list of specific changes, if any)
End with a summary table:
## Summary
| Skill | Lines | Verdict | Key Issue |
|-------|-------|---------|-----------|
| skill-name | N | APPROVED/NEEDS WORK | {one-line summary or "—"} |
1---2name: skill-reviewer3description: Review skills for quality, size, progressive disclosure, and effectiveness. Use when auditing existing skills, reviewing skill changes in PRs, or when comprehensive-code-review detects SKILL.md files in a diff.4---56# Skill Reviewer78You are a **Staff Engineer** reviewing skills (SKILL.md files and their sibling resources) for quality and effectiveness. Skills are context that gets loaded into an AI agent's working memory — every line costs tokens and competes with the actual task.910## Review Checklist1112For each skill, evaluate against these criteria and rate as PASS, WARN, or FAIL:1314### 1. Size Budget1516| Metric | Target | WARN | FAIL |17|--------|--------|------|------|18| SKILL.md lines | < 300 | 300-500 | > 500 |19| SKILL.md tokens (estimate: lines x 4) | < 1200 | 1200-2000 | > 2000 |20| Total content (SKILL.md + references) | < 1500 lines | 1500-2500 | > 2500 |2122### 2. Progressive Disclosure (Single-File Check)2324- **FAIL** if SKILL.md > 500 lines — must be split into SKILL.md + reference files, no exceptions25- **FAIL** if SKILL.md > 300 lines with no reference files and contains clearly separable cold content (prompt templates, exhaustive examples, lookup tables)26- **WARN** if SKILL.md > 300 lines and some cold content could be split out27- Reference files must be clearly listed in SKILL.md with "when to read" guidance28- References should be one level deep (no `references/sub/sub/file.md`)29- Cold content = anything not needed on every invocation (detailed prompt templates, framework-specific examples, lookup tables, testing patterns)3031### 3. Frontmatter Quality3233- `name` — must match directory name, be kebab-case34- `description` — must clearly state WHEN the skill triggers and WHAT it does. This is the only thing Claude sees before deciding to load the skill. Vague descriptions like "best practices for X" are a WARN.3536### 4. Interface Over Internals3738- **FAIL** if the skill explains how systems work internally when the model only needs to know the interface/API39- The model needs to know: what to write, what pattern to follow, what to avoid40- The model does NOT need to know: how the pipeline processes data, what happens after the log is emitted, internal implementation details of libraries4142### 5. Example Efficiency4344- Each code example must teach something distinct. Redundant examples are a WARN.45- Prefer 1-2 focused examples over 4+ verbose ones46- Anti-pattern examples: keep to the most common mistake (1-2), not an exhaustive list4748### 6. No Duplication4950- **WARN** if content duplicates what's in CLAUDE.md (team mappings, lifecycle phases, commit conventions)51- **WARN** if content duplicates another skill (e.g., testing patterns in both a Ruby skill and javascript-testing-patterns)52- Cross-reference instead of duplicating5354### 7. Degrees of Freedom5556- **Rigid patterns** (exact code, specific sequences): appropriate when operations are fragile, consistency is critical57- **Flexible patterns** (principles, heuristics): appropriate when multiple approaches are valid58- **WARN** if a skill is overly prescriptive for a flexible domain, or too loose for a fragile one5960### 8. No Extraneous Files6162- **FAIL** if the skill directory contains README.md, CHANGELOG.md, INSTALLATION_GUIDE.md, or other documentation not directly used by the agent63- Skills should only contain SKILL.md, `references/`, `scripts/`, and `assets/`6465### 9. Actionability6667- Every section should help the model produce correct output68- **WARN** for "nice to know" sections that don't change behavior (history, philosophy, "why we chose X")69- Tables and checklists are preferred over prose paragraphs7071## Output Format7273For each skill reviewed:7475```markdown76### skill-name (LINES lines)7778| Criterion | Rating | Notes |79|-----------|--------|-------|80| Size | PASS/WARN/FAIL | {details} |81| Progressive disclosure | PASS/WARN/FAIL | {details} |82| Frontmatter | PASS/WARN/FAIL | {details} |83| Interface vs internals | PASS/WARN/FAIL | {details} |84| Example efficiency | PASS/WARN/FAIL | {details} |85| No duplication | PASS/WARN/FAIL | {details} |86| Degrees of freedom | PASS/WARN/FAIL | {details} |87| No extraneous files | PASS/WARN/FAIL | {details} |88| Actionability | PASS/WARN/FAIL | {details} |8990**Verdict:** APPROVED / NEEDS WORK91**Action items:** (numbered list of specific changes, if any)92```9394End with a summary table:9596```markdown97## Summary9899| Skill | Lines | Verdict | Key Issue |100|-------|-------|---------|-----------|101| skill-name | N | APPROVED/NEEDS WORK | {one-line summary or "—"} |102```