1 Human SoT
2 FRB PR Review
Use this before treating a non-trivial flutter_rust_bridge PR as ready, especially after CI-driven fixes, Flutter upgrades, generated drift, test changes, workflow changes, or broad merge conflict resolution.
2.1 Review Gate
Run the following review before final readiness:
Review the PR diff against its base:
- Spawn a subagent to review correctness.
- Ask it to inspect the PR diff against the PR base.
- Focus on real behavior bugs, stale generated output, incorrect CI workarounds, coverage-only changes, and unrelated drift.
- Require findings with file paths, line numbers, impact, and suggested fix.
- Spawn a subagent to review test weakening.
- Inspect changed or deleted assertions, relaxed thresholds, new skips, ignored failures, timeout changes, and coverage exclusions.
- Require a concrete justification for each reduction in coverage; restore unjustified weakening and fix the underlying failure.
- If
tom-style-tests is installed, apply its common test principles and weakening gate; use frb-test for FRB execution commands.
- Treat unjustified skipped tests, weaker assertions, broader ignores, fake timeouts, and coverage hiding as blockers.
Write a concise review conclusion.
- Put the conclusion in the PR description or an agent-context draft when the user asks for a Markdown artifact.
- Include the subagents used, accepted findings, dismissed findings, fixes made, and remaining risks.
2.2 Stop Condition
Do not call the PR ready until:
- Correctness review has no unresolved actionable findings and test-weakening review has no unjustified weakening.
- CI status is green, or remaining non-green checks are clearly unrelated and explained.
1---2name: frb-pr-review3description: Review a flutter_rust_bridge PR before treating it as ready, including subagent checks for correctness and test weakening.4---56# 1 Human SoT78# 2 FRB PR Review910Use this before treating a non-trivial `flutter_rust_bridge` PR as ready, especially after CI-driven fixes, Flutter upgrades, generated drift, test changes, workflow changes, or broad merge conflict resolution.1112## 2.1 Review Gate1314Run the following review before final readiness:15161. Review the PR diff against its base:17 - Spawn a subagent to review correctness.18 - Ask it to inspect the PR diff against the PR base.19 - Focus on real behavior bugs, stale generated output, incorrect CI workarounds, coverage-only changes, and unrelated drift.20 - Require findings with file paths, line numbers, impact, and suggested fix.21 - Spawn a subagent to review test weakening.22 - Inspect changed or deleted assertions, relaxed thresholds, new skips, ignored failures, timeout changes, and coverage exclusions.23 - Require a concrete justification for each reduction in coverage; restore unjustified weakening and fix the underlying failure.24 - If `tom-style-tests` is installed, apply its common test principles and weakening gate; use `frb-test` for FRB execution commands.25 - Treat unjustified skipped tests, weaker assertions, broader ignores, fake timeouts, and coverage hiding as blockers.26272. Write a concise review conclusion.28 - Put the conclusion in the PR description or an agent-context draft when the user asks for a Markdown artifact.29 - Include the subagents used, accepted findings, dismissed findings, fixes made, and remaining risks.3031## 2.2 Stop Condition3233Do not call the PR ready until:3435- Correctness review has no unresolved actionable findings and test-weakening review has no unjustified weakening.36- CI status is green, or remaining non-green checks are clearly unrelated and explained.
fzyzcjy