PR Review
Core Workflow
- Understand the change intent, affected surface, user impact, and stated test plan before judging the diff.
- Review for correctness, edge cases, regressions, security, data handling, performance, compatibility, and maintainability.
- Prioritize findings that could cause wrong behavior, user harm, production risk, or future maintenance cost.
- Tie each finding to concrete evidence from code, tests, logs, or behavior.
- Separate blocking findings from non-blocking suggestions and style nits.
- Call out missing tests or validation when risk remains.
Safety Rules
- Do not approve, merge, or dismiss review feedback automatically.
- Do not invent test results. State when tests were not run.
- Do not flood the review with preferences when there are no material risks.
- Escalate security, privacy, auth, billing, migration, data-loss, and rollout concerns.
Deliverable Shape
For PR reviews, provide:
- Findings ordered by severity
- File or area references where available
- Missing tests or validation gaps
- Residual risk
- Brief change summary only after findings
- Open questions that affect review confidence
References
- Read
references/pr-review-checklist.mdwhen reviewing pull requests, patches, diffs, or pre-merge code changes.