Review PR Comments
Handle real review feedback on an existing PR. This is an on-demand, exception
path: most PRs have no comments because cloud auto-review is disabled and the
heavy review already happened locally (ship-it's delivery gate). Do not
summon bot reviews (@codex review, @coderabbitai review), and never treat a
bot's silence as something to wait for.
Process, at most TWO rounds (a round = collect → triage → one batched commit →
push → required CI green on the new head):
- Collect all open feedback: human reviews, bot comments, unresolved and
outdated threads, failing checks.
- Triage each finding against the code:
- Fix in the batch: real correctness, security, or data-integrity
issues, and anything a human reviewer explicitly requested.
- Reply, don't push: style nits, defensive hardening for invariants
that already hold, severity-inflated or duplicate findings. Answer the
thread, resolve it, move on. A nit is never a reason for a push.
- Surface to the user: product/architecture decisions, scope
expansions, conflicting reviewer guidance.
- Validate the complete head (original changes plus fixes), commit and push
once, and wait for required CI (poll at 60–120 s intervals, never tight
loops).
After two rounds, stop pushing: report remaining items with your triage and
recommendation. Feedback arriving after your final push does not reopen the
loop. Success: required checks green on the final head, human-requested
changes addressed, every open thread fixed or answered, and GitHub reports the
PR mergeable — bot re-reviews are never a completion requirement.
Do not merge, force-push, modify main, create follow-up PRs (nit-cleanup
follow-up PRs are explicitly banned), or make product and architecture
decisions without authorization.
1---2name: review-pr-comments3description: Manual-only cleanup of actual feedback on an existing PR: verify comments, batch valid in-scope fixes, respond, and leave the PR merge-ready.4---56# Review PR Comments78Handle real review feedback on an existing PR. This is an on-demand, exception9path: most PRs have no comments because cloud auto-review is disabled and the10heavy review already happened locally (ship-it's delivery gate). Do not11summon bot reviews (`@codex review`, `@coderabbitai review`), and never treat a12bot's silence as something to wait for.1314Process, at most TWO rounds (a round = collect → triage → one batched commit →15push → required CI green on the new head):16171. Collect all open feedback: human reviews, bot comments, unresolved and18 outdated threads, failing checks.192. Triage each finding against the code:20 - **Fix in the batch:** real correctness, security, or data-integrity21 issues, and anything a human reviewer explicitly requested.22 - **Reply, don't push:** style nits, defensive hardening for invariants23 that already hold, severity-inflated or duplicate findings. Answer the24 thread, resolve it, move on. A nit is never a reason for a push.25 - **Surface to the user:** product/architecture decisions, scope26 expansions, conflicting reviewer guidance.273. Validate the complete head (original changes plus fixes), commit and push28 once, and wait for required CI (poll at 60–120 s intervals, never tight29 loops).3031After two rounds, stop pushing: report remaining items with your triage and32recommendation. Feedback arriving after your final push does not reopen the33loop. Success: required checks green on the final head, human-requested34changes addressed, every open thread fixed or answered, and GitHub reports the35PR mergeable — bot re-reviews are never a completion requirement.3637Do not merge, force-push, modify `main`, create follow-up PRs (nit-cleanup38follow-up PRs are explicitly banned), or make product and architecture39decisions without authorization.
hcaiano