jessedegans Ship
Pre-flight
- Confirm you're not on the base branch
- Review staleness check:
- Has the code been reviewed? When?
- How many commits since last review?
- If >5 commits since review: the review is stale. Re-review or acknowledge the risk.
Review gate
Code review should be complete before shipping. Three options when it isn't:
- A) Ship anyway - you accept the risk, document why in the PR description
- B) Stop and review first - the right default
- C) Too small to need review - trivial changes (typos, config, one-liner fixes)
Merge and test
- Fetch and merge base branch; resolve conflicts
- Run the full test suite
- Triage failures: pre-existing vs. introduced by this change. Only your failures block.
Version and changelog
- Auto-detect bump level:
- Patch - bug fixes, small changes
- Minor - new features, non-breaking API changes
- Major - breaking changes (ask explicitly, never auto-bump major)
- Generate changelog from diff: summarize what changed and why
Ship it
- Split large diffs into logical, bisectable commits
- Create PR with clear description
- Push