Convert percent to basis points
Percentages are the most common way a float sneaks into money code: 2.9% becomes 0.029 becomes a float multiplier. Convert the rate to an integer basis-point (or parts-per-million) representation once, at the edge, and do all arithmetic in that integer.
Procedure
- Fix the scales:
1% = 100 bps = 10_000 ppm, so2.9% = 290 bps = 29_000 ppm. bps covers two decimals of a percent, ppm covers four. - Pick the smallest denominator the rates need: a 0.075% fee needs ppm (
750); a 2.9% fee fits in bps (290). - Parse the incoming string with exact decimal, then scale:
int((Decimal(s.rstrip('%')) * 100).to_integral_value())turns"2.9%"into290. - Reject a rate that does not land on an integer at the chosen scale:
7.5 bpsis not representable in bps, so escalate to ppm (750) instead of silently truncating. - Store the integer
rate_bps(orrate_ppm) in the schema; never a floatingratecolumn. - Apply it as
mulDiv(amount, rate_bps, 10_000)— the integer rate is the numerator. - Round-trip for display only: format
rate_bps / 100after all arithmetic, never during it. - Put the denominator in the column name so
rate_bpsandrate_ppmcannot be confused (seereject-currency-mismatch-before-arithmetic). - Store the raw string the user typed next to the parsed bps for an audit trail of the rate's origin.
- Define the rounding when a rate does not land on the scale:
2.005%is 200.5 bps; choose truncate or round explicitly. - Keep a fee-schedule bps table in code with a test that pins each value.
- Assert the field name carries the unit; a bare
ratefield is where fraction/percent confusion starts.
Pitfalls
float("2.9") * 100yields289.99999999999997;round()masks the symptom but the intermediate was wrong.- A column named
rateholding0.029for one row and2.9for another (fraction vs percent) shifts money by 100x on one row; name and document the unit. - Storing
"2.9%"as text and parsing at each use scatters the conversion; do it once at ingest. - Choosing bps for a rate that needs three decimals truncates 0.001% fees to zero.
- Reading
"2,9%"(comma decimal, EU) withfloatfails or misparses; parse locale-aware. - A rate loaded from a config file as YAML gives
0.029as a float; parse it withDecimal(str(value)), notDecimal(value).
Verification
python3 -c "from decimal import Decimal as D; print(int(D('2.9')*100), int(D('0.075')*100*100))" # 290, 750
rg -n 'float\(.*%|parseFloat.*%|/ *100' rates.py # expect no float percent handling
Report the denominator chosen, one parsed example, and the round-trip display value.