Final Review

Use before handing off an implementation to compare the diff against the spec, tests, docs, contracts, and safety rules.

jsuvic fe6b0f6 1.3 KB Updated

File contents

Final Review

Instructions

  1. Compare the implementation against the relevant spec.
  2. Confirm acceptance criteria are met or list the unmet criteria.
  3. Confirm tests and golden tests were run when applicable.
  4. Check generated outputs for deterministic formatting and intentional fixture changes.
  5. Check that no literal secrets, production access, unsafe auto-approval, source upload, or automatic dependency installation were introduced.
  6. Report remaining risks, TODOs, and documentation gaps. When change-risk review applies, validate the closed snapshot-bound ChangeRiskOrchestrationStateV1 handoff from subagent-driven-change; accept a terminal result only when its snapshot matches the final snapshot modulo docs/review-learning/, and do not run another review or interpret prose state.
  7. Confirm debug output added during the change was removed and any new error paths carry a stable event code, per the project's Logging Guidance convention.

Output

Return a concise final review with spec compliance, tests run, contract impact, security impact, and remaining risks.

jsuvic/agent-profile/tree/main/fixtures/logging-enforcement-enabled/expected/.agents/skills/final-review commit fe6b0f6d85

Frequently asked questions

npx skillmds@latest add jsuvic/final-review-4