Abstraction Review

Architecture-alignment code review that detects when a change evades the codebase's existing abstractions instead of extending or correcting them: parallel implementations built beside existing ones, special-case dispatch on identity, semantics carried by naming conventions, runtime rediscovery of statically known facts, workarounds contorted around a guard, contracts shoehorned onto handy mechanisms, and mocks or tests that validate the workaround instead of the requirement. Judges architectural fit only, not correctness or implementation quality. Use when reviewing agent-authored or large-scale changes, or when asked whether a change routes around an abstraction, "eats the vegetables", or aligns with the existing architecture.

jwiegley Updated 6 repo stars

File contents

jwiegley/nix-config commit 27b10bb829

Frequently asked questions

npx get-skill add jwiegley/abstraction-review