kensaurus PR Workflow Skill
full checklist for every pull request.
Phase 1: Before Creating PR
1. Run Validations
JavaScript/TypeScript:
pnpm typecheck && pnpm build && pnpm test
# or: npm run typecheck && npm run build && npm test
Python:
mypy . && python -m pytest && ruff check .
With Makefile:
make typecheck && make build && make test
2. Security Scan
Before committing, verify:
- No hardcoded paths (
/Users/username/...) - No secrets, API keys, or tokens
- No machine-specific values
- Environment variables for sensitive data
3. Create PR
- Search for
pull_request_template.mdin repo - Use template structure for PR description
- Create PR with clear title and description
Phase 2: Monitor PR (REQUIRED)
4. Poll Status
Check every 60-90 seconds until checks complete:
Understanding Check Status:
mergeable: true→ Only means no git conflictsmergeable_state: "clean"→ ALL checks passed, safe to merge
Mergeable State Values:
| State | Meaning | Action |
|---|---|---|
"clean" |
✅ All passed | Safe to merge |
"unstable" |
⚠️ Pending/failing | Wait, poll again |
"blocked" |
❌ Protection rules | Check requirements |
"behind" |
⚠️ Needs update | Update branch |
5. Address Bot Feedback
When reviews complete:
- Read every comment - Track unresolved threads
- For each issue:
- Analyze feedback
- Implement fix
- Commit and push
- Reply confirming fix
- Mark thread resolved
- Never ignore feedback - Every comment must be addressed
6. Wait for Re-validation
After pushing fixes:
- Poll status again
- All checks must show
SUCCESS - Re-fetch comments for NEW feedback
- Repeat until clean
Phase 3: Merge Criteria
7. Final Checklist
Two gates must pass:
| Gate | Check |
|---|---|
| Gate 1 | mergeable_state == "clean" |
| Gate 2 | unresolved_thread_count == 0 |
Both must be TRUE to merge.
8. Execute Merge
Only after both gates pass:
gh pr merge --merge
9. Verify Success
Confirm merge was successful and report status.
Error Handling
| Situation | Action |
|---|---|
| Checks fail 3x | Pause, ask for guidance |
| Unclear feedback | Ask clarifying questions |
| Merge blocked | Check protection rules, report |
| Checks stuck | Run local validation, ask permission |
Common Mistakes
❌ Merging when mergeable_state is "unstable"
Fix: Always check mergeable_state, poll again if unstable
❌ Treating mergeable: true as approval
Fix: mergeable ≠ mergeable_state. Check the latter.
❌ Not re-checking comments after push
Fix: After every push, re-fetch comments for new threads
❌ Not marking threads resolved
Fix: After addressing each comment, mark thread resolved
Quick Reference
# Check PR status
gh pr status
# View checks
gh pr checks <number>
# View comments
gh pr view <number> --comments
# Merge (only when both gates pass)
gh pr merge <number> --merge