Glance Code Review

Review OpenStack Glance, glance_store, python-glanceclient, and glance-tempest-plugin changes for correctness, architecture boundaries, policy impact, and test coverage. Use when user asks for patch review, Gerrit review help, code quality checks, or Glance change analysis.

konan-abhi Updated

File contents

Glance Code Review

Instructions

  1. Read the workflow in skills/glance-code-review.md.
  2. Use docs/baseline_guides/glance_architecture.md for subsystem boundaries.
  3. Apply coding guidance from docs/knowledge_overlays/.
  4. Produce structured output that matches schemas/code_review_schema.json.
  5. If requested, render artifacts:
    • Gerrit payload: tools/json_to_gerrit_comment.py
    • HTML report: tools/json_to_html_report.py

Review checklist

  • Validate style basics (license/import/docstring/line length expectations).
  • Check architecture concerns per touched subsystem.
  • Check test updates and identify gaps.
  • Flag API-impact/spec signals when behavior or contracts change.

Additional resources

  • docs/baseline_guides/glance_architecture.md
  • docs/knowledge_overlays/
  • schemas/code_review_schema.json

konan-abhi/glance-cursor-skills/tree/main/.cursor/skills/glance-code-review commit e72b55b6cc

Frequently asked questions

npx skillmds@latest add konan-abhi/glance-code-review