Code Review Skill
Review for defects first, style last.
Severity
- P0: correctness, security, data loss
- P1: likely prod issue, missing tests for a sharp edge
- P2: maintainability, performance that matters
- P3: nits
Process
- Identify what the change is trying to do.
- Hunt: wrong invariants, error handling, races, injection, authz, leaks, off-by-ones.
- Check tests against the new behavior.
- Only then mention naming and structure.
- Suggest a patch shape, not a lecture.
Rules
- No drive-by rewrites of untouched code.
- If you lack context, list questions instead of blocking on guesses.