Work Gates

Work Gates

Project-specific quality standards for kspec. Supplements the core $kspec-task-work skill with MUST-FIX patterns, test rules, and code quality checks specific to this codebase.

MUST-FIX Patterns

The following are always MUST-FIX in this project — no exceptions, no downgrading:

Stubs and No-ops

• void expressions, empty function bodies, TODO comments, placeholder returns where the spec requires real behavior
• Any code path where the AC's core verb (parse, validate, output, persist, exit) is not actually executed

Test Integrity

• Tests that verify implementation internals (compiled source strings, parser state, AST shape) rather than user-visible behavior
• Tests that pass regardless of whether the feature works
• Tests that mock the thing being tested — if the AC says "CLI outputs JSON," mocking the output formatter proves nothing
• Tests that claim AC coverage at the wrong abstraction layer (parser tests claiming CLI-level coverage)

Code Hygiene

• Imports from unmerged branches — code depending on work not on main must be blocked or rebased
• Hardcoded absolute paths — /home/user/project/... in any file
• Test helpers exported from production code — test-only exports from src/ modules belong in tests/
• Bypassing Zod validation — creating parallel validation instead of using schemas in src/schema/

Build and Verification Config

Any change to tsconfig, oxlint/oxfmt config, or vitest config that makes the pipeline report fewer problems:

• Adding excludes/ignores to suppress errors instead of fixing them
• Loosening compiler strictness, disabling rules, skipping test suites
• Modifying test sharding or timeouts to mask failures

Test Rewrites That Reduce Coverage

• Replacement tests must be a superset of original coverage
• Watch for: E2E tests replaced with unit tests, structural assertions replacing behavioral ones, test names describing old behavior with new assertions

Refactors

• Refactored code must preserve all behavior including error handling, edge cases, and Result<T> chains
• Verify all call sites still get the same behavior after utility extraction

Test Strategy

E2E Preference

Prefer end-to-end tests over unit tests in this project:

// Good: test the CLI as a user would
it('should list tasks', async () => {
  const result = await kspec(['task', 'list'], tempDir);
  expect(result.exitCode).toBe(0);
  expect(result.stdout).toContain('task-slug');
});

// Less good: only unit testing internal functions
it('should format task', () => {
  const formatted = formatTask(mockTask);
  expect(formatted).toBe('...');
});

Unit tests are fine for complex logic, but E2E proves the feature works.

Test Isolation

All tests MUST run in temp directories, not the kspec repo:

let tempDir: string;
beforeEach(async () => {
  tempDir = await createTempDir();
  await initGitRepo(tempDir);
  await setupTempFixtures(tempDir);
});

Test Helpers

Use existing helpers — don't reinvent:

• testUlid() / testUlids() — valid test ULIDs (Crockford base32)
• setupTempFixtures() — copy fixtures to temp dir
• createTempDir() — empty temp dir
• initGitRepo(dir) — git init with test config
• kspec(args, cwd) — run CLI, return result
• kspecJson<T>(args, cwd) — run CLI with --json

Regression Check

npm test  # Always run full suite — never just new tests

Kynetic Quality Gate Commands

The shared $kspec-task-work skill defers to "project-defined" quality gates. In this repository those gates are:

Run every applicable gate before kspec task submit. Treat any red gate as in-scope task work — do not leave hygiene cleanup for plan closure.

Gate semantics:

• npm run format:check — if it fails, run npm run format, commit the formatting changes, and rerun the check.
• npm run lint -- --quiet — must report 0 errors. Repo-wide lint has a pre-existing warning baseline; that baseline is not your responsibility, but new warnings in your changed files are.
• npx oxlint <changed files> — inspect warnings as well as errors in changed TypeScript/test files. New warnings in your diff are review findings even when the repo-wide gate passes.
• npm run typecheck — required for any code change.
• npm test — run the full suite for changes with broad or closure-risk impact; new tests alone are not sufficient evidence.

Generated Artifact Maintenance

Several directories in this repository are regenerated outputs, not hand-edited sources. After modifying their inputs, regenerate and commit the output alongside the source change:

plugin/ is gitignored by default; rebuild locally when verifying that core skill changes still render correctly into the plugin output. Rendered .agents/skills/ and .factory/skills/ outputs ARE committed and must stay in sync with their sources — kspec skill verify should report no drift for the skills you touched.

Code Quality

• Search for existing utilities before creating new ones — kspec has extensive shared helpers
• Match neighboring file style — naming, error handling, imports, Result<T> patterns
• Schema validation — Zod schemas in src/schema/ are the source of truth. Never bypass them.
• Shadow branch integrity — extra scrutiny for changes touching .kspec/ state or worktree operations

Severity Default

Default to MUST-FIX. Only downgrade to SUGGESTION for pure style preferences (naming, comment formatting) with zero correctness implications. If it touches behavior or correctness in any way, it is at minimum SHOULD-FIX.