Newsletter Service Pr Readiness

Newsletter Service PR Readiness

You are checking whether local lfx-v2-newsletter-service commits are shaped correctly to open as a PR. This is a preflight gate for PR hygiene only: branch name, JIRA references, conventional commit subjects, rebase status, DCO + GPG signing, diff size, and protected files touched.

Do not audit implementation quality here. Do not run format, lint, build, or tests here. Run /newsletter-service-preflight after this shape check passes or after any shape issues are addressed.

Output: structured shape report with verdict NOT READY | READY WITH CHANGES | READY. No working-tree mutations, no commits, and no PR side effects. The one exception is the git fetch origin in Phase 2, which is part of the base-branch freshness check (it updates remote-tracking refs only — it does not touch the working tree, local branches, or commits).

Phase 1: Parse Arguments

Args format: [base-branch] [extra instructions].

• First token, if it looks like a ref or branch name, is the base branch.
• Default base: origin/main.
• If the base contains no /, normalize it to origin/<base>.
• Treat everything else as extra context for the report, not as permission to expand scope.

Phase 2: Gather Shape Inputs

Run:

git fetch origin
git rev-parse --abbrev-ref HEAD
git diff --shortstat <base>...HEAD
git diff --name-only <base>...HEAD
git log --format='%H %s' <base>..HEAD
git log --format='%G? %h %s' <base>..HEAD
git log --format=%B <base>..HEAD
git merge-base --is-ancestor <base> HEAD; echo $?

If there are no commits between <base> and HEAD, stop with: No commits to audit against <base>.

Phase 3: Protected Files

Flag protected files by intersecting git diff --name-only <base>...HEAD with this repo-specific list. Protected files are not forbidden, but the PR should call them out explicitly and the reviewer should understand the contract or deployment impact.

Phase 4: Shape Checks

Emit at most one finding per check.

Use this finding shape:

{
  "severity": "CRITICAL | SHOULD_FIX | NIT",
  "rule": "newsletter-service-pr-readiness/<check-id>",
  "message": "...",
  "suggestion": "..."
}

Phase 5: Render Report

# Newsletter Service PR Readiness

**Branch:** `<current-branch>` -> `<base>`
**Commits:** N | **Additions:** +A | **Deletions:** -D
**Verdict:** NOT READY | READY WITH CHANGES | READY

## PR shape

| Check | Status | Detail |
| --- | --- | --- |
| Branch name | PASS | feat/LFXV2-1234-newsletter-drafts |
| JIRA ticket | PASS | Found LFXV2-1234 in commits |
| Conventional commits | PASS | 3/3 commit subjects valid |
| Branch rebased | PASS | origin/main is an ancestor |
| Diff size | PASS | +342 / -41 |
| DCO + GPG signing | PASS | 3/3 commits signed and signed off |
| Protected files | SHOULD_FIX | pkg/api/newsletter.go, docs/newsletter-service-contract.md |

## Findings

<one line per CRITICAL/SHOULD_FIX finding>

Verdict Rules

• NOT READY: any CRITICAL finding.
• READY WITH CHANGES: zero CRITICAL, at least one SHOULD_FIX.
• READY: zero CRITICAL, zero SHOULD_FIX.

Boundaries

• Do not review Go implementation patterns.
• Do not run mechanical checks; /newsletter-service-preflight owns license, format, lint, build, tests, protected-file reporting, commit verification, and PR summary.
• Do not create commits, branches, pushes, or PRs from this skill.