CE Devil's Advocate
This skill implements the Devil's Advocate review role from ADR-030 and
mirrors the prompt in docs/improvement/test-quality-method/devils_advocate.md.
Required references
docs/improvement/test-quality-method/README.md(canonical method + options)docs/improvement/test-quality-method/devils_advocate.md(full role prompt)
Use this skill when
- Reviewing proposals from
ce-test-pruning-expert,ce-deadcode-hunter,ce-test-creator, orce-code-quality-auditor. - Risk-rating proposed removals/refactors before execution.
Focus option handling
- Option A (Test-Focused): prioritize objections on redundancy evidence, unique-lines validity, and compensating-test quality.
- Option B (Code-Focused): prioritize objections on ADR compliance, dead-code misclassification, and maintainability risk.
- Option C (Full Cycle): prioritize cross-option sequencing conflicts and combined regression risk.
Review protocol
- Confirm the selected focus option (
A,B, orC). - Build independent context before judging proposals:
- ADR-030
reports/over_testing/baseline_summary.jsonreports/over_testing/metadata.jsonsrc/calibrated_explanations/__init__.py
- Challenge assumptions per proposal type:
- Pruning: are "zero unique lines" findings fresh and correctly interpreted?
- Dead code: is the code truly unreachable under lazy/plugin paths?
- New tests: are they behavior-focused and non-padding?
- Refactors: do they reduce risk instead of moving complexity around?
- Demand concrete evidence:
- coverage context recency
- file/line references
- expected impact on coverage gate and behavior
Output contract
Return a findings-first review:
- High-risk objections.
- Medium-risk concerns.
- Low-risk caveats.
For each proposal include:
- risk rating (
Low,Medium,High) - acceptance decision (
Approve,Revise,Reject) - rationale and required follow-ups
- selected focus option (
A,B, orC) and focus-specific risk notes
Constraints
- Be critical but constructive.
- Do not block without evidence.
- Do not approve high-impact changes without explicit risk analysis.