Code Review

Code Review Workflow Skill

Context (Input)

• PR has unresolved code review comments
• Need systematic approach to address feedback
• Ready to implement reviewer suggestions
• Need to maintain quality standards during review implementation

Task (Function)

Systematically retrieve, categorize, and address all PR code review comments while maintaining quality standards.

Success Criteria: make pr-comments shows 0 unresolved AND make ci shows "✅ CI checks successfully passed!"

Workflow Overview

PR Comments → Categorize → Apply by Priority → Verify → Run CI → Done

Quick Start

# 1. Get comments
make pr-comments

# 2. Apply each suggestion/fix (one commit per comment)
git commit -m "Apply review suggestion: [description]

Ref: [comment URL]"

# 3. Verify all addressed
make pr-comments  # Should show 0 unresolved

# 4. Run CI
make ci  # Must show "✅ CI checks successfully passed!"

Execution Steps

Step 1: Get PR Comments

make pr-comments              # Auto-detect from current branch
make pr-comments PR=62       # Specify PR number
make pr-comments FORMAT=json  # JSON output

Output: All unresolved comments with file/line, author, timestamp, URL

Step 2: Categorize Comments

Step 3: Verify Architecture & Organization

For code changes (suggestions, prompts, new files), invoke verification skills:

Quick verification: Run make phpcsfixer && make psalm && make deptrac && make unit-tests

Step 4: Apply Changes Systematically

For Committable Suggestions

1. Apply code change exactly as suggested

2. Commit with reference:

   git commit -m "Apply review suggestion: [brief description]
   
   Ref: [comment URL]"
   

For LLM Prompts

1. Copy prompt from comment
2. Execute as instructed
3. Verify output meets requirements
4. Commit with reference

For Architecture/Organization Concerns

1. Invoke appropriate skill (code-organization or implementing-ddd-architecture)
2. Implement recommended changes
3. Verify: make phpcsfixer && make psalm && make deptrac && make unit-tests
4. Commit with reference

For Questions

1. Determine if code change or reply needed
2. If code: implement + commit
3. If reply: respond on GitHub

For General Feedback

1. Evaluate suggestion merit
2. Implement if beneficial
3. Document reasoning if declined

Step 5: Verify All Addressed

make pr-comments  # Should show zero unresolved comments

Step 6: Run Quality Checks

MANDATORY: Run comprehensive CI checks after implementing all changes:

make ci  # Must output "✅ CI checks successfully passed!"

If CI fails, invoke appropriate skill:

DO NOT finish the task until make ci shows: ✅ CI checks successfully passed!

Constraints (Parameters)

NEVER:

• Skip committable suggestions
• Batch unrelated changes in one commit
• Ignore LLM prompts from reviewers
• Commit without running verification
• Leave questions unanswered
• Accept organizational violations (invoke code-organization skill)
• Accept architecture violations (invoke implementing-ddd-architecture skill)
• Finish task before make ci shows success message

ALWAYS:

• Apply suggestions exactly as provided
• Commit each suggestion separately with URL reference
• Invoke code-organization skill for structural issues
• Invoke implementing-ddd-architecture skill for DDD violations
• Run make ci after implementing all changes
• Address ALL CI failures before finishing
• Mark conversations resolved after addressing

Format (Output)

Commit Message Template:

Apply review suggestion: [concise description]

[Optional: explanation if non-obvious]

Ref: https://github.com/owner/repo/pull/XX#discussion_rYYYYYYY

Final Verification:

✅ make pr-comments shows 0 unresolved
✅ make ci shows "CI checks successfully passed!"

Verification Checklist

• All PR comments retrieved via make pr-comments
• Comments categorized by type (suggestion/prompt/architecture/question/feedback)
• Architecture verified using appropriate skills
• make deptrac passes (0 violations)
• Committable suggestions applied and committed separately
• LLM prompts executed and implemented
• Questions answered (code or reply)
• General feedback evaluated and addressed
• make ci shows "✅ CI checks successfully passed!"
• make pr-comments shows zero unresolved
• All conversations marked resolved on GitHub

Quick Reference: When to Use Related Skills

During code review, you may need to invoke other skills:

Related Skills

• code-organization: Enforces "Directory X contains ONLY class type X" and naming conventions
• implementing-ddd-architecture: DDD patterns, layer structure, and boundaries
• deptrac-fixer: Fixes architectural boundary violations
• complexity-management: Reduces cyclomatic complexity
• testing-workflow: Test coverage and mutation testing
• quality-standards: Overall quality metrics and thresholds
• ci-workflow: Comprehensive CI checks

Related Documentation

• Examples: examples/organization-fixes.md - Real-world organization fix examples
• Reference: reference/quality-standards.md - Quality standards integration details