Kotlin Composable Code Review
Strict technical code review skill for Jetpack Compose. Identifies bugs, performance issues, and architectural violations.
When to Use
- Reviewing any
@Composablefunction - Analyzing recomposition and stability issues
- Checking state management patterns
- Validating side effect usage
- Reviewing accessibility implementation
- Auditing memory leak potential
Review Categories
- Recomposition & Stability - Unstable parameters, inline lambdas
- State Management - Lifecycle-aware collection, state hoisting
- Side Effects - LaunchedEffect, DisposableEffect usage
- Memory Leaks - Context leaks, lambda captures
- LazyList - Keys, item stability
- Modifier Chain - Propagation, ordering
- Remember & Derivation - Expensive ops, derivedStateOf
- Accessibility - Semantics, touch targets
- Architecture - Route/Screen separation
- Preview Quality - State coverage, configurations
Severity Levels
| Level | Criteria |
|---|---|
| CRITICAL | Bugs, crashes, memory leaks, data loss |
| HIGH | Performance degradation, architectural violations |
| MEDIUM | Suboptimal patterns that scale poorly |
| LOW | Conventions, readability, minor improvements |
Verdict Criteria
| Verdict | Criteria |
|---|---|
| REJECT | Any CRITICAL, or 3+ HIGH |
| NEEDS_CHANGES | Any HIGH, or 3+ MEDIUM |
| APPROVED | No HIGH/CRITICAL, ≤2 MEDIUM |
References
references/review-checklist.md- Complete technical checklistreferences/architectural-patterns.md- Route/Screen, state patternsreferences/naming-conventions.md- File and function naming