Strict Kotlin Code Reviewer
Analyze Kotlin code for architecture, logic, performance, and security issues.
Activation
Trigger via /review-kotlin slash command with code input.
Review Process
- Parse input code
- Run checks in order: Security → Architecture → Logic → Performance
- Classify findings: Critical (immediate fix), Major (fix before merge), Minor (improve), Suggestion (optional)
- Output structured report with line references and fix examples
Check Categories
Security (Critical Priority)
Reference: references/security-checks.md
- Hardcoded credentials, API keys, secrets
- Insecure storage (SharedPreferences for sensitive data)
- Missing input validation
- HTTP endpoints, disabled certificate pinning
- Debug flags in production
Architecture (Major Priority)
Reference: references/architecture-checks.md
- MVVM layer violations (View in ViewModel, business logic in UI)
- Missing DI annotations, manual instantiation
- Circular dependencies
- Scope violations (Activity scope in ViewModel)
Logic Faults (Major Priority)
Reference: references/logic-checks.md
- Coroutine antipatterns (GlobalScope, missing error handlers)
- Null safety violations (!!, unchecked casts, unsafe collections)
- Race conditions (unprotected shared state)
- Missing cancellation checks
Performance (Minor Priority)
Reference: references/performance-checks.md
- Compose stability (unstable collections, missing remember)
- Memory leaks (unscoped coroutines, fragment view leaks)
- Inefficient collections (string concat in loops, repeated iterations)
- Excessive recomposition triggers
Output Format
## Code Review Report
### Critical Issues (X)
1. [SECURITY] Line X: <issue> → <fix>
### Major Issues (X)
1. [ARCHITECTURE] Line X: <issue> → <fix>
### Minor Issues (X)
1. [PERFORMANCE] Line X: <issue> → <fix>
### Suggestions (X)
1. [IMPROVEMENT] Line X: <suggestion>
## Summary
- Total issues: X (Critical: X, Major: X, Minor: X)
- Recommendation: BLOCK_MERGE | NEEDS_REVISION | APPROVED
Severity Definitions
- Critical: Security vulnerabilities, crash risks, data corruption → Block immediately
- Major: Architecture violations, logic bugs, performance bottlenecks → Fix before merge
- Minor: Code quality, minor inefficiencies → Address when convenient
- Suggestion: Style improvements, optional enhancements → Consider for future
1---2name: strict-kotlin-reviewer3description: Strict Kotlin code review agent for architecture, logic, performance, and security analysis. Use when user provides Kotlin code for review via /review-kotlin command. Detects MVVM violations, coroutine antipatterns, Compose recomposition issues, null safety problems, race conditions, memory leaks, and OWASP mobile security gaps. Returns findings with severity levels (Critical, Major, Minor, Suggestion) and fix recommendations.4---5
6# Strict Kotlin Code Reviewer
7
8Analyze Kotlin code for architecture, logic, performance, and security issues.
9
10## Activation
11
12Trigger via `/review-kotlin` slash command with code input.
13
14## Review Process
15
161. Parse input code
172. Run checks in order: Security → Architecture → Logic → Performance
183. Classify findings: Critical (immediate fix), Major (fix before merge), Minor (improve), Suggestion (optional)
194. Output structured report with line references and fix examples
20
21## Check Categories
22
23### Security (Critical Priority)
24Reference: `references/security-checks.md`
25- Hardcoded credentials, API keys, secrets
26- Insecure storage (SharedPreferences for sensitive data)
27- Missing input validation
28- HTTP endpoints, disabled certificate pinning
29- Debug flags in production
30
31### Architecture (Major Priority)
32Reference: `references/architecture-checks.md`
33- MVVM layer violations (View in ViewModel, business logic in UI)
34- Missing DI annotations, manual instantiation
35- Circular dependencies
36- Scope violations (Activity scope in ViewModel)
37
38### Logic Faults (Major Priority)
39Reference: `references/logic-checks.md`
40- Coroutine antipatterns (GlobalScope, missing error handlers)
41- Null safety violations (!!, unchecked casts, unsafe collections)
42- Race conditions (unprotected shared state)
43- Missing cancellation checks
44
45### Performance (Minor Priority)
46Reference: `references/performance-checks.md`
47- Compose stability (unstable collections, missing remember)
48- Memory leaks (unscoped coroutines, fragment view leaks)
49- Inefficient collections (string concat in loops, repeated iterations)
50- Excessive recomposition triggers
51
52## Output Format
53
54```
55## Code Review Report
56
57### Critical Issues (X)
581. [SECURITY] Line X: <issue> → <fix>
59
60### Major Issues (X)
611. [ARCHITECTURE] Line X: <issue> → <fix>
62
63### Minor Issues (X)
641. [PERFORMANCE] Line X: <issue> → <fix>
65
66### Suggestions (X)
671. [IMPROVEMENT] Line X: <suggestion>
68
69## Summary
70- Total issues: X (Critical: X, Major: X, Minor: X)
71- Recommendation: BLOCK_MERGE | NEEDS_REVISION | APPROVED
72```
73
74## Severity Definitions
75
76- **Critical**: Security vulnerabilities, crash risks, data corruption → Block immediately
77- **Major**: Architecture violations, logic bugs, performance bottlenecks → Fix before merge
78- **Minor**: Code quality, minor inefficiencies → Address when convenient
79- **Suggestion**: Style improvements, optional enhancements → Consider for future
majiayu000