Mcaf Code Review

MCAF: Code Review

Trigger On

• shaping PR review policy
• preparing a change for review
• auditing whether a change is actually review-ready
• tightening reviewer expectations or templates

Value

• produce a concrete project delta: code, docs, config, tests, CI, or review artifact
• reduce ambiguity through explicit planning, verification, and final validation skills
• leave reusable project context so future tasks are faster and safer

Do Not Use For

• implementing the code change itself
• generic team-process work with no PR or review component

Inputs

• the diff or planned PR scope
• tests, docs, and architecture notes affected by the change
• current review template or review policy, if any

Quick Start

1. Read the nearest AGENTS.md and confirm scope and constraints.
2. Run this skill's Workflow through the Ralph Loop until outcomes are acceptable.
3. Return the Required Result Format with concrete artifacts and verification evidence.

Workflow

1. Confirm the change is small enough to review coherently. Split if needed.
2. Apply MCAF-AI-001: the planning model reviews every delegated coding diff against its instruction packet, plan, acceptance criteria, architecture, contracts, and verification duties.
3. Apply MCAF-REQ-001: trace each changed behaviour from REQ-* and AC-* through the required ADR implementation contract, TASK-*, automated tests, and evidence. Reject missing links or an ADR marked Implemented without proof.
4. Apply MCAF-ARCH-001: confirm all solution-owned artifacts remain in this repository and affected backend, frontend, contracts, tests, and docs use the same canonical slice name and convention.
5. Check that tests, docs, and architecture notes moved with the code.
6. Review in this order:
   • behavioural risk
   • design and maintainability
   • test quality
   • operational or security impact
7. If the repo needs review policy or a template, define it in-repo.
8. Keep reviewer guidance concrete. Avoid vague "review carefully" language.

Deliver

• review-ready pull requests
• review guidance that is specific and enforceable
• findings tied to behaviour, design, testing, and risk

Validate

• the review guidance tells reviewers what to check, not just that they should check
• PR scope is understandable without opening the whole repo
• tests and docs are part of review readiness, not afterthoughts
• the PR does not split solution-owned artifacts, introduce layer-first feature ownership, or let slice names and structures drift across technical roots
• the planning model reviewed delegated output and rejected unplanned scope, architecture, contract, or quality changes
• every requirement and acceptance criterion maps to the implemented task, required ADR, automated proof, and integrated verification evidence
• all required worker results were awaited, reached explicit completion states, and were inspected before integration

Ralph Loop

Use the Ralph Loop for every task, including docs, architecture, testing, and tooling work.

1. Brainstorm first (mandatory):
   • analyze current state
   • define the problem, target outcome, constraints, and risks
   • generate options and think through trade-offs before committing
   • capture the recommended direction and open questions
2. Plan second (mandatory):
   • write a detailed execution plan from the chosen direction
   • list final validation skills to run at the end, with order and reason
3. Execute one planned step and produce a concrete delta.
4. Review the result and capture findings with actionable next fixes.
5. Apply fixes in small batches and rerun the relevant checks or review steps.
6. Update the plan after each iteration.
7. Repeat until outcomes are acceptable or only explicit exceptions remain.
8. If a dependency is missing, bootstrap it or return status: not_applicable with explicit reason and fallback path.

Required Result Format

• status: complete | clean | improved | configured | not_applicable | blocked
• plan: concise plan and current iteration step
• actions_taken: concrete changes made
• validation_skills: final skills run, or skipped with reasons
• verification: commands, checks, or review evidence summary
• remaining: top unresolved items or none

For setup-only requests with no execution, return status: configured and exact next commands.

Load References

• read references/code-reviews.md and references/pull-requests.md first
• open references/pull-request-template.md, references/inclusion-in-code-review.md, or references/faq.md only when needed

Example Requests

• "Make our PR template less useless."
• "Is this change actually ready for code review?"
• "Define stricter review expectations for this repo."