soloscrum-review-implementation
Verify DoD, code quality, and make close decision.
Overview
Receives a PR or Figma file, evaluates DoD, AC, and code quality. PRs arrive in draft (per soloscrum-define-pr-lifecycle); the review pipeline runs in that draft window. Makes Pass / Pass with follow-ups / Fail verdict and executes the verdict's post-actions per soloscrum-define-code-review-process. State transitions delegate to the active profile's transition-state operation skill (per soloscrum-define-tracker-profile). The final gh pr merge is always user-gated and never executed by this skill.
Steps
- Read target PR or Figma file and corresponding Issue: $ARGUMENTS
- Verify all items in
soloscrum-define-dod. AC verification operates at the appropriate layer per the DoD's "AC verification" section:
- Subtask PR — slice delivered (per the Subtask's "what" + Checklist) + no regression on the parent's AC.
- Issue-without-Subtasks PR — full Issue AC satisfied, with evidence.
- Parent Issue intent-level sign-off — when all Subtasks close (not at any single Subtask PR); the union of Subtask deliveries must satisfy the parent's AC.
Also: Do tests exist (when applicable)? Does PR body contain the correct Issue number (
Closes #<subtask> for Subtask PRs / Closes #<issue> for Issues without Subtasks)? Zero lint errors?
- Run the automated code review pipeline per
soloscrum-define-code-review-process:
- CodeRabbit CLI (all severities pass through; skip with stated reason or fix each)
- Multi-agent review via
code-review:code-review — bypass that command's step 1 draft check: soloscrum runs /soloscrum:review on a draft PR by design, so treat draft state as eligible and proceed (per soloscrum-define-code-review-process, "Draft-window override"). Apply the <80 confidence filter on agent findings only.
- Apply review perspectives per
soloscrum-define-code-review-process ("Applying review perspectives"): glob ~/.claude/review-perspectives/*/PERSPECTIVE.md, read only each one's frontmatter description, select those whose stated when matches this PR, then read the bodies of the selected ones and apply them as additional lenses. Every finding must cite a diff location and the specific check it instantiates; discard the ungrounded ones (per that skill's grounding requirement). Report the corpus size and how many were selected. An empty or absent corpus is normal — skip silently, and report nothing.
- Manual code review (for PRs), to complement the automated pass:
- Logic correctness
- Security: OWASP Top 10 perspective
- Performance: no obvious bottlenecks
- Readability and maintainability
- Compile all evaluation results into a single report following the format in
soloscrum-define-code-review-process
- On Pass / Pass with follow-ups — run all sub-steps below end-to-end without pausing; the only stop in this entire sequence is at
gh pr merge. Transition state first, then promote to ready so a tracker failure does not leave a ready PR with stale state:
- For Pass with follow-ups only: programmatically check whether a follow-up Issue exists for each out-of-scope skip; create any missing Issue autonomously and record its number in the skip note before proceeding (no user prompt)
- Approve PR review — reversible. In solo-dev contexts this call fails with "Can not approve your own pull request" by design; the verdict comment posted in step 6 is the formal Pass record and steps below still run. Use try-and-fall-through (no probe call):
gh pr review --approve "$PR_URL" \
|| echo "approve skipped (likely self-approve refusal); verdict comment is the formal Pass record"
See soloscrum-define-pr-lifecycle, "Self-approve refusal in solo-dev contexts".
- Resolve active profile, then invoke the matching
transition-state operation skill to move the Subtask to done:
github-only → soloscrum-tracker-github-transition-state
linear+github → soloscrum-tracker-linear-transition-state
- Do not close the parent Issue here. Parent and Subtask Issue closure happens at merge time via the PR body's
Closes # keyword and GitHub's auto-close, not as part of the post-verdict sequence. For parent Issues whose closing event was missed, the /soloscrum:refine janitor cleans them up on the next backlog touch. See soloscrum-define-pr-lifecycle, "Issue close happens at merge".
- Wait for CI to complete before promoting to ready. Invoke
soloscrum-tracker-github-wait-for-pr-checks:skills/soloscrum-tracker-github-wait-for-pr-checks/scripts/wait-for-pr-checks.sh <pr-number>
That path is repo-root-relative, so run it with the main checkout as the working directory — after /soloscrum:develop the agent may still be inside that unit's worktree, where the path does not resolve (see soloscrum-define-worktree, "Paths that stay anchored to the main checkout").
If any conclusion is not SUCCESS / SKIPPED / NEUTRAL, treat the verdict as Fail retroactively: post the failed conclusions on the PR, revert the Subtask to in-progress via the transition-state skill, and skip the remaining Pass actions (do not promote to ready). A green CI is part of the Pass contract — promoting a ready PR with red checks is the failure mode this step exists to prevent. Inline until loops over gh pr view are the anti-pattern this skill replaces.
- Promote the PR to ready (
gh pr ready) — reversible (gh pr ready --undo); per soloscrum-define-pr-lifecycle this runs without pre-confirm
- Stop here. Surface the exact
gh pr merge command for the user to run; merge is irreversible and is the user's gate. Do not run gh pr merge.
- If
transition-state fails after gh pr ready has happened (rare race), surface a clear notice and prompt the user to manually transition before they merge
- On Fail:
- Comment specific issues and improvement suggestions on PR
- Invoke the matching
transition-state operation skill to revert the Subtask to in-progress
- Leave the PR in draft — do not call
gh pr ready. The draft state keeps GitHub-side auto-reviewers suppressed during rework and makes the "needs more work" state externally visible.
Output Format
Follow the comment template defined in soloscrum-define-code-review-process (CodeRabbit findings + filtered agent findings + verdict). The DoD checklist is included alongside.
## Review Result
### DoD Check
- [x] AC verified at the appropriate layer (Subtask PR / Issue-without-Subtasks / parent Issue sign-off)
- [x] Tests exist (when applicable) / N/A documented
- [x] PR body contains Issue number
- [x] Zero lint errors
### CodeRabbit findings
- (per soloscrum-define-code-review-process)
### Agent findings (≥80 confidence)
- (per soloscrum-define-code-review-process)
### Review-perspective findings
- (per soloscrum-define-code-review-process; omitted when the corpus is empty)
### Verdict: Pass / Pass with follow-ups / Fail
Depends On
soloscrum-define-dod
soloscrum-define-code-review-process (verdict + post-action mapping)
soloscrum-define-pr-lifecycle (draft premise, gh pr ready autonomy, merge user-gate)
soloscrum-define-worktree (which checkout each step runs against)
soloscrum-define-review-perspective (the corpus selected from in step 4)
soloscrum-define-tracker-profile (routing)
soloscrum-tracker-{github|linear}-transition-state (delegated)
soloscrum-tracker-github-wait-for-pr-checks (CI gate before gh pr ready)
1---2name: soloscrum-review-implementation3description: Reviews a PR or Figma file against the DoD checklist with layered AC verification per soloscrum-define-dod (Subtask PR = slice + no regression; Issue-without-Subtasks PR = full AC; parent Issue intent-level sign-off = when all Subtasks close). PRs are expected in draft; on Pass the review agent promotes the PR to ready, transitions the Subtask to Done via the active profile's tracker operation skill, and hands the merge command off to the user. Issue close is not part of this sequence — it happens at merge time via the PR body's Closes # keyword (see soloscrum-define-pr-lifecycle, "Issue close happens at merge"). Merge itself is always user-gated.4argument-hint: <pr-url or figma-url>5disable-model-invocation: true6allowed-tools:7 - Read8 - Glob9 - Grep10 - Bash(gh pr:*)11 - Bash(gh issue:*)12 - Bash(gh api:*)13 - Bash(coderabbit:*)14 - Bash(cr:*)15metadata:16 source: https://skillmd.com/skills/mew-ton/soloscrum-review-implementation17---1819# soloscrum-review-implementation2021Verify DoD, code quality, and make close decision.2223## Overview2425Receives a PR or Figma file, evaluates DoD, AC, and code quality. PRs arrive in **draft** (per `soloscrum-define-pr-lifecycle`); the review pipeline runs in that draft window. Makes Pass / Pass with follow-ups / Fail verdict and executes the verdict's post-actions per `soloscrum-define-code-review-process`. State transitions delegate to the active profile's `transition-state` operation skill (per `soloscrum-define-tracker-profile`). The final `gh pr merge` is always user-gated and never executed by this skill.2627## Steps28291. Read target PR or Figma file and corresponding Issue: $ARGUMENTS302. Verify all items in `soloscrum-define-dod`. AC verification operates at the appropriate layer per the DoD's "AC verification" section:31 - **Subtask PR** — slice delivered (per the Subtask's "what" + Checklist) + no regression on the parent's AC.32 - **Issue-without-Subtasks PR** — full Issue AC satisfied, with evidence.33 - **Parent Issue intent-level sign-off** — when all Subtasks close (not at any single Subtask PR); the union of Subtask deliveries must satisfy the parent's AC.34 Also: Do tests exist (when applicable)? Does PR body contain the correct Issue number (`Closes #<subtask>` for Subtask PRs / `Closes #<issue>` for Issues without Subtasks)? Zero lint errors?353. Run the **automated code review pipeline** per `soloscrum-define-code-review-process`:36 - CodeRabbit CLI (all severities pass through; skip with stated reason or fix each)37 - Multi-agent review via `code-review:code-review` — **bypass that command's step 1 draft check**: soloscrum runs `/soloscrum:review` on a draft PR by design, so treat draft state as eligible and proceed (per `soloscrum-define-code-review-process`, "Draft-window override"). Apply the <80 confidence filter on agent findings only.384. Apply **review perspectives** per `soloscrum-define-code-review-process` ("Applying review perspectives"): glob `~/.claude/review-perspectives/*/PERSPECTIVE.md`, read only each one's frontmatter `description`, select those whose stated *when* matches this PR, then read the bodies of the selected ones and apply them as additional lenses. Every finding must cite a diff location and the specific check it instantiates; discard the ungrounded ones (per that skill's grounding requirement). Report the corpus size and how many were selected. An empty or absent corpus is normal — skip silently, and report nothing.395. Manual code review (for PRs), to complement the automated pass:40 - Logic correctness41 - Security: OWASP Top 10 perspective42 - Performance: no obvious bottlenecks43 - Readability and maintainability446. Compile all evaluation results into a single report following the format in `soloscrum-define-code-review-process`457. **On Pass / Pass with follow-ups** — run **all sub-steps below end-to-end without pausing**; the only stop in this entire sequence is at `gh pr merge`. Transition state first, then promote to ready so a tracker failure does not leave a ready PR with stale state:46 - For Pass with follow-ups only: programmatically check whether a follow-up Issue exists for each out-of-scope skip; create any missing Issue autonomously and record its number in the skip note before proceeding (no user prompt)47 - Approve PR review — reversible. In solo-dev contexts this call fails with "Can not approve your own pull request" by design; the verdict comment posted in step 6 is the formal Pass record and steps below still run. Use try-and-fall-through (no probe call):48 ```bash49 gh pr review --approve "$PR_URL" \50 || echo "approve skipped (likely self-approve refusal); verdict comment is the formal Pass record"51 ```52 See `soloscrum-define-pr-lifecycle`, "Self-approve refusal in solo-dev contexts".53 - Resolve active profile, then invoke the matching `transition-state` operation skill to move the Subtask to `done`:54 - `github-only` → `soloscrum-tracker-github-transition-state`55 - `linear+github` → `soloscrum-tracker-linear-transition-state`56 - **Do not close the parent Issue here.** Parent and Subtask Issue closure happens at merge time via the PR body's `Closes #` keyword and GitHub's auto-close, not as part of the post-verdict sequence. For parent Issues whose closing event was missed, the `/soloscrum:refine` janitor cleans them up on the next backlog touch. See `soloscrum-define-pr-lifecycle`, "Issue close happens at merge".57 - **Wait for CI to complete** before promoting to ready. Invoke `soloscrum-tracker-github-wait-for-pr-checks`:58 ```bash59 skills/soloscrum-tracker-github-wait-for-pr-checks/scripts/wait-for-pr-checks.sh <pr-number>60 ```61 That path is repo-root-relative, so run it with the **main checkout** as the working directory — after `/soloscrum:develop` the agent may still be inside that unit's worktree, where the path does not resolve (see `soloscrum-define-worktree`, "Paths that stay anchored to the main checkout").62 If any conclusion is **not** `SUCCESS` / `SKIPPED` / `NEUTRAL`, treat the verdict as **Fail** retroactively: post the failed conclusions on the PR, revert the Subtask to `in-progress` via the `transition-state` skill, and skip the remaining Pass actions (do **not** promote to ready). A green CI is part of the Pass contract — promoting a ready PR with red checks is the failure mode this step exists to prevent. Inline `until` loops over `gh pr view` are the anti-pattern this skill replaces.63 - Promote the PR to ready (`gh pr ready`) — reversible (`gh pr ready --undo`); per `soloscrum-define-pr-lifecycle` this runs without pre-confirm64 - **Stop here.** Surface the exact `gh pr merge` command for the user to run; merge is irreversible and is the user's gate. Do not run `gh pr merge`.65 - If `transition-state` fails after `gh pr ready` has happened (rare race), surface a clear notice and prompt the user to manually transition before they merge668. **On Fail:**67 - Comment specific issues and improvement suggestions on PR68 - Invoke the matching `transition-state` operation skill to revert the Subtask to `in-progress`69 - **Leave the PR in draft** — do not call `gh pr ready`. The draft state keeps GitHub-side auto-reviewers suppressed during rework and makes the "needs more work" state externally visible.7071## Output Format7273Follow the comment template defined in `soloscrum-define-code-review-process` (CodeRabbit findings + filtered agent findings + verdict). The DoD checklist is included alongside.7475```76## Review Result7778### DoD Check79- [x] AC verified at the appropriate layer (Subtask PR / Issue-without-Subtasks / parent Issue sign-off)80- [x] Tests exist (when applicable) / N/A documented81- [x] PR body contains Issue number82- [x] Zero lint errors8384### CodeRabbit findings85- (per soloscrum-define-code-review-process)8687### Agent findings (≥80 confidence)88- (per soloscrum-define-code-review-process)8990### Review-perspective findings91- (per soloscrum-define-code-review-process; omitted when the corpus is empty)9293### Verdict: Pass / Pass with follow-ups / Fail94```9596## Depends On9798- `soloscrum-define-dod`99- `soloscrum-define-code-review-process` (verdict + post-action mapping)100- `soloscrum-define-pr-lifecycle` (draft premise, `gh pr ready` autonomy, merge user-gate)101- `soloscrum-define-worktree` (which checkout each step runs against)102- `soloscrum-define-review-perspective` (the corpus selected from in step 4)103- `soloscrum-define-tracker-profile` (routing)104- `soloscrum-tracker-{github|linear}-transition-state` (delegated)105- `soloscrum-tracker-github-wait-for-pr-checks` (CI gate before `gh pr ready`)