mmcardle Review PR Changes
Perform structured review of PR changes against project quality standards.
Quick Reference
# Get PR files changed
gh pr diff <pr> --name-only
# View specific file diff
gh pr diff <pr> -- path/to/file
# Get PR review status
gh pr view <pr> --json reviews
# Check file statistics
gh pr diff <pr> | diffstat
# Get PR body/description
gh pr view <pr> --json body
Review Checklist
Code Quality:
- Code is readable and well-structured
- Functions/classes have clear purposes
- No code duplication (DRY principle)
- Proper error handling
- No unnecessary complexity
Testing:
- Tests present for new functionality
- Tests are passing (CI shows green)
- Edge cases covered
- Adequate coverage for changes
Documentation:
- Docstrings for public APIs
- Type hints present
- Comments for non-obvious code
Security & Git:
- No hardcoded secrets/tokens
- Input validation present
- PR linked to issue (in description)
- No unintended files included
Review Workflow
- Check context: View PR description and linked issue
- Scan changes: Review file list and statistics
- Read code: Examine actual changes carefully
- Run checklist: Go through each category
- Test locally: Pull and test changes if needed
- Create comments: Flag issues as code comments
- Provide verdict: Approve, request changes, or comment
Output Format
Report review results with exactly these sections:
- Summary — 1-2 sentence overall assessment
- Issues Found — Problems that must be fixed (omit if none)
- Verdict — Approve / Request Changes / Comment
Error Handling
| Problem | Solution |
|---|---|
| Can't access PR | Check gh auth status |
| Can't understand code | Ask clarifying question in comment |
| Needs local testing | Use worktree-create skill to test |
| Multiple issues | Prioritize critical first, optional second |
| Disagreement on style | Refer to CLAUDE.md for standards |
References
- See CLAUDE.md for project standards
- See verify-pr-ready for merge readiness check
- See gh-batch-merge-by-labels for batch review workflow