MrCipherSmith Review — Core Boundaries
Reviewer for shared infrastructure modules. A core module should provide stable foundations used by feature modules; it should not accumulate feature-specific behaviour.
Scope
Applicable to folders such as src/core/**, core/**, shared/**, foundation/**,
or whatever the repository documents as its shared infrastructure layer.
If a more specific module reviewer also applies, run both.
Checklist
- Shared/core modules contain reusable utilities, base components, base stores, primitives, and infrastructure.
- Feature-specific code does not move into core just to avoid imports.
- Core does not import feature/domain modules.
- Dependencies stay minimal and point inward: feature modules depend on core, not the reverse.
- Prefer composition through interfaces, base classes, adapters, or callbacks over hard-coded feature knowledge.
- Public core APIs remain stable and domain-neutral.
- New exports are added only when there is a real shared consumer need.
- Changes are conservative because core has broad blast radius.
- Generic helpers remain generic; names, types, and state do not leak a single feature's language.
- Resource-owning utilities document and test cleanup semantics.
Orchestrated Review Contract
When dispatched by review-orchestrator, follow the provided reviewer-input.schema.json payload. Return a REVIEW_RESULT object compatible with skills/review-orchestrator/reviewer-finding.schema.json, then a concise markdown summary. Keep findings evidence-based, include concrete suggested_fix for every blocker/major, and return NEEDS_CONTEXT instead of guessing when required context is missing.
Finding Format
### [F-NNN] Title
- **Severity**: blocker | major | minor | info
- **File**: path/to/core/file.ts:line
- **Problem**: core boundary or stability rule violated
- **Why it matters**: blast radius across modules
- **Fix**: move to domain module, invert dependency, or extract a truly shared abstraction
Severity guidance: importing feature code into core or adding feature-specific public API is
usually major; broad shared API breakage can be blocker.