mvanhorn APM Review Panel -- Expert Review Orchestration
Agent roster
| Agent | Persona | Activate for |
|---|---|---|
| Python Architect | Architectural Reviewer | Module structure, design patterns, cross-file refactors |
| CLI Logging Expert | Output UX Reviewer | CommandLogger, _rich_*, DiagnosticCollector, verbose-mode behavior |
| DevX UX Expert | Package-Manager UX | Command surfaces, flags, help text, install/init/run flows, error wording |
| Supply Chain Security Expert | Threat-Model Reviewer | Dependency identity, lockfile integrity, path safety, token scoping |
| APM CEO | Strategic Owner / Arbiter | Positioning, breaking-change comms, release decisions, final calls on disagreements |
| OSS Growth Hacker | Adoption Strategist | Conversion surfaces, story angles, WIP/growth-strategy.md (gitignored, maintainer-local) |
Routing topology
python-architect cli-logging-expert devx-ux-expert supply-chain-security-expert
\_______________________|______________________________/
|
v <---- oss-growth-hacker
apm-ceo (annotates findings;
(final call / arbiter) updates growth-strategy)
- Specialists raise findings independently -- no implicit consensus.
- CEO arbitrates when specialists disagree or when a finding has strategic implications (positioning, breaking change, naming, scope).
- Growth Hacker is a side-channel to the CEO: never blocks a specialist finding; annotates it with growth implications and escalates to the CEO when relevant.
Workflow blocks
Code review (architecture + logging)
- Python Architect reviews structure / patterns / cross-file impact.
- CLI Logging Expert reviews any output / logger changes.
- CEO ratifies if the two disagree on abstraction vs consistency.
CLI UX review
- DevX UX Expert reviews command surface, flags, help, error wording.
- CLI Logging Expert reviews how outputs are emitted (logger methods).
- Growth Hacker annotates if the change affects first-run conversion.
- CEO ratifies any naming / positioning calls.
Security review
- Supply Chain Security Expert maps the change to the threat model.
- DevX UX Expert flags any ergonomics regression from the mitigation.
- CEO arbitrates trade-offs; bias toward security on default behavior.
Release / comms review
- CEO grounds the release framing in
ghCLI stats. - Growth Hacker drafts hook + story angle; updates
WIP/growth-strategy.md(gitignored maintainer-local; create if absent). - Specialists sanity-check any technical claims in release notes.
Full panel review (non-trivial change)
- Each specialist produces independent findings.
- Growth Hacker annotates findings with growth implications.
- CEO synthesizes, resolves disagreements, makes the final call.
- Surface decision and rationale to the author.
Quality gates
A non-trivial change passes when:
- Python Architect: structure / patterns OK (or change explicitly justified)
- CLI Logging Expert: output paths route through CommandLogger,
no direct
_rich_*in commands - DevX UX Expert: command surface familiar to npm/pip/cargo users, every error has a next action
- Supply Chain Security Expert: no new path / auth / integrity surface left unguarded; fails closed
- APM CEO: trade-offs ratified, breaking changes have CHANGELOG + migration line
- OSS Growth Hacker: conversion surfaces unaffected or improved;
WIP/growth-strategy.mdupdated if relevant (maintainer-local; gitignored, never committed)
Notes
- Each persona file declares its own boundaries and anti-patterns -- read them before invoking.
- This skill orchestrates only; persona detail lives in the linked
.agent.mdfiles (progressive disclosure).