ncdevshiv Fix Review
Overview
Verify that fix commits properly address audit findings without introducing new bugs or security vulnerabilities.
When to Use This Skill
Use this skill when you need to verify fix commits address audit findings without new bugs.
Use this skill when:
- Reviewing commits that address security audit findings
- Verifying that fixes don't introduce new vulnerabilities
- Ensuring code changes properly resolve identified issues
- Validating that remediation efforts are complete and correct
Instructions
This skill helps verify that fix commits properly address audit findings:
- Review Fix Commits: Analyze commits that claim to fix audit findings
- Verify Resolution: Ensure the original issue is properly addressed
- Check for Regressions: Verify no new bugs or vulnerabilities are introduced
- Validate Completeness: Ensure all aspects of the finding are resolved
Review Process
When reviewing fix commits:
- Compare the fix against the original audit finding
- Verify the fix addresses the root cause, not just symptoms
- Check for potential side effects or new issues
- Validate that tests cover the fixed scenario
- Ensure no similar vulnerabilities exist elsewhere
Best Practices
- Review fixes in context of the full codebase
- Verify test coverage for the fixed issue
- Check for similar patterns that might need fixing
- Ensure fixes follow security best practices
- Document the resolution approach
Resources
For more information, see the source repository.