1---2name: codeprobe-code-smells3description: Detects code smells and anti-patterns — long methods, large classes, feature envy, data clumps, primitive obsession, dead code, magic numbers, deep nesting, and more. Uses configurable thresholds from .codeprobe-config.json when available. Trigger phrases: "code smells", "smell check", "anti-patterns", "clean code review".4---56## Standalone Mode78If invoked directly (not via the orchestrator), you must first:91. Read `../codeprobe/shared-preamble.md` (resolve relative to this SKILL.md's location — the sibling `codeprobe` skill directory — not the user's project) for the output contract, execution modes, and constraints.102. Load applicable reference files from `../codeprobe/references/` (same resolution) based on the project's tech stack.113. Default to `full` mode unless the user specifies otherwise.1213# Code Smells & Anti-Pattern Detector1415## Domain Scope1617This sub-skill detects code smells and anti-patterns organized into these categories:18191. **Bloaters** — Long Method, Large Class, Data Clumps, Primitive Obsession202. **Object-Orientation Abusers** — Feature Envy, Inappropriate Intimacy, Refused Bequest213. **Change Preventers** — Shotgun Surgery, Divergent Change224. **Dispensables** — Dead Code, Speculative Generality, Middle Man235. **Couplers** — Temporal Coupling246. **Readability** — Magic Numbers, Boolean Blindness, Deep Nesting2526---2728## What It Does NOT Flag2930- **Generated code** — Migrations, compiled output, vendor directories (`vendor/`, `node_modules/`, `dist/`, `build/`, `.next/`), and auto-generated files (e.g., GraphQL codegen, Prisma client).31- **Test files** with long setup methods — Test context is different; long `setUp()` or `beforeEach()` methods arranging test data are expected and acceptable.32- **Configuration files** with many entries — A config file with 50 key-value pairs is not a "Large Class" smell.33- **Data migration files** — These are procedural by nature and often contain long methods.34- **Third-party code** checked into the repository (e.g., vendored libraries).35- **Structural issues already flagged by `codeprobe-solid` or `codeprobe-architecture`** — Large classes may also be flagged as SRP violations or god objects. This sub-skill should still detect and report them, but the orchestrator will deduplicate overlapping findings at the same location.3637---3839## Detection Instructions4041### Configurable Thresholds4243Before analysis, check for a `.codeprobe-config.json` file in the project root. If present, load the `severity_overrides` section to adjust these defaults:4445| Threshold | Config Key | Default |46|-----------|-----------|---------|47| Long Method LOC limit | `long_method_loc` | 30 |48| Large Class LOC limit | `large_class_loc` | 300 |49| Deep Nesting max levels | `deep_nesting_max` | 3 |5051### Bloaters5253| ID Prefix | Smell | Signal | How to Detect | Default Threshold | Severity |54|-----------|-------|--------|---------------|-------------------|----------|55| `SMELL` | Long Method | Function/method exceeds LOC threshold | Count lines in each function/method body (excluding blank lines and single-line comments). Compare against `long_method_loc` threshold. For methods 2x over threshold, escalate to major. | > 30 LOC | Minor |56| `SMELL` | Large Class | Class exceeds LOC threshold | Count total lines in each class definition. Compare against `large_class_loc` threshold. For classes 2x over threshold, escalate to major (if not already major). Never escalate to critical — large classes are a maintainability concern, not a production defect. | > 300 LOC | Major |57| `SMELL` | Data Clumps | Same 3+ params passed together in 3+ places | Search for function/method signatures. Identify groups of 3+ parameters that appear together in 3+ different function signatures or call sites. These should be extracted into a parameter object or value object. | 3+ params, 3+ occurrences | Minor |58| `SMELL` | Primitive Obsession | String/int used where a value object is warranted | Look for string/integer variables representing domain concepts: email addresses (validated by regex inline), money amounts (numeric + currency passed separately), phone numbers, status strings compared in multiple places, ZIP codes, UUIDs passed as plain strings through multiple layers. | Pattern recognition | Minor |5960### Object-Orientation Abusers6162| ID Prefix | Smell | Signal | How to Detect | Default Threshold | Severity |63|-----------|-------|--------|---------------|-------------------|----------|64| `SMELL` | Feature Envy | Method accesses another object's data 3x+ more than its own | Count how many times a method references `$other->property` or `other.property` versus `$this->property` or `this.property` (or `self.`). If external references outnumber internal ones by 3x or more, the method likely belongs in the other class. | 3+ external accesses | Minor |65| `SMELL` | Inappropriate Intimacy | Class accessing another's private/protected internals | Search for reflection-based access (`setAccessible(true)`, `__get`, `__set` magic methods accessing protected fields), friend class patterns, or direct access to properties that are conventionally private (prefixed with `_` in Python/JS). | Any occurrence | Major |66| `SMELL` | Refused Bequest | Subclass inherits but doesn't use most of parent's methods | Examine subclasses: if the parent has N public methods and the subclass overrides fewer than 30% of them while also not calling `super`/`parent::` for most, this suggests the subclass doesn't truly need the inheritance relationship. | Unused majority of parent methods | Minor |6768### Change Preventers6970| ID Prefix | Smell | Signal | How to Detect | Default Threshold | Severity |71|-----------|-------|--------|---------------|-------------------|----------|72| `SMELL` | Shotgun Surgery | Changing one concept requires edits in 5+ files | Search for a single concept (e.g., a field name, a status value, a business rule) that appears across many files. If the same constant, column name, or business term appears in 5+ files without being centralized behind a single source of truth, flag it. | 5+ files for one concept | Major |73| `SMELL` | Divergent Change | One class modified for 3+ unrelated reasons | Examine large classes (> 200 LOC). Check whether the methods cluster around distinct, unrelated concerns. If a single class handles user authentication, email formatting, AND report generation, it has divergent change — any of those 3 areas changing forces this class to change. | 3+ distinct concerns | Major |7475### Dispensables7677| ID Prefix | Smell | Signal | How to Detect | Default Threshold | Severity |78|-----------|-------|--------|---------------|-------------------|----------|79| `SMELL` | Dead Code | Unreachable branches, unused imports, commented-out code blocks | Search for: (1) `import`/`use`/`require` statements for symbols never referenced elsewhere in the file, (2) commented-out code blocks (3+ consecutive commented lines that contain code syntax, not documentation), (3) functions/methods never called from anywhere in the codebase (use Grep across the project), (4) `if (false)` or `if (0)` blocks, unreachable code after unconditional `return`/`throw`/`exit`. | Any occurrence | Minor |80| `SMELL` | Speculative Generality | Abstractions/interfaces with only one implementation and no foreseeable second | Search for interfaces, abstract classes, or generic type parameters that have exactly one concrete implementation. If the abstraction does not appear in a DI container config or test mock, and the domain doesn't suggest future variants, flag it as premature abstraction. | Single implementation | Suggestion |81| `SMELL` | Middle Man | Class that only delegates to another class with no added logic | Look for classes where every method simply calls the same method on an injected dependency and returns the result, with no added logic, validation, transformation, or error handling. The class adds an unnecessary indirection layer. | Pure delegation in all methods | Minor |8283### Couplers8485| ID Prefix | Smell | Signal | How to Detect | Default Threshold | Severity |86|-----------|-------|--------|---------------|-------------------|----------|87| `SMELL` | Temporal Coupling | Methods must be called in specific order but nothing enforces it | Look for patterns where: (1) method A must be called before method B but there's no compile-time or runtime check, (2) `init()`/`setup()` must be called before `process()` but the class allows `process()` to be called first, (3) sequential method calls with shared mutable state where reordering would cause bugs. Check for comments like "must call X first" or "call after Y". | Implicit ordering dependency | Major |8889### Readability9091| ID Prefix | Smell | Signal | How to Detect | Default Threshold | Severity |92|-----------|-------|--------|---------------|-------------------|----------|93| `SMELL` | Magic Numbers | Hardcoded numeric/string literals without named constants in business logic | Search for numeric literals (other than 0, 1, -1) and string literals used in conditionals, calculations, or business logic. Flag values like `86400`, `3.14159`, `"pending"`, `0.15` that appear in logic paths without a named constant. Exclude: array indices, loop bounds of 0/1, common math constants in math libraries. | Any in logic paths | Minor |94| `SMELL` | Boolean Blindness | Method with 2+ boolean params | Search for function/method signatures with 2 or more `bool`/`boolean` parameters. Call sites like `process(true, false, true)` are unreadable. Suggest using named parameters, enums, or option objects instead. | 2+ boolean parameters | Minor |95| `SMELL` | Deep Nesting | Indentation levels exceed threshold | Count nesting depth in each function: each `if`, `for`, `while`, `foreach`, `switch`, `try`, `match` that is nested inside another adds a level. Flag when nesting exceeds `deep_nesting_max` threshold. Suggest early returns, guard clauses, or method extraction. | > 3 levels | Minor |9697---9899## ID Prefix & Fix Prompt Examples100101All findings use the `SMELL-` prefix, numbered sequentially: `SMELL-001`, `SMELL-002`, etc.102103### Fix Prompt Examples104105- "Extract lines 45-90 of `UserService@register` into a private method `validateAndNormalizeInput()` — the method is 120 LOC doing 3 unrelated things: input validation (lines 45-65), data normalization (lines 66-80), and persistence (lines 81-90). Keep persistence in `register()` and extract the other two concerns."106- "Replace the magic number `86400` at line 55 of `app/Services/CacheService.php` with a named constant `SECONDS_PER_DAY = 86400` defined at the top of the class."107- "Refactor `processOrder(bool $isExpress, bool $requiresSignature, bool $isFragile)` in `OrderProcessor.php` (line 30) to accept a `ShippingOptions` value object instead of 3 boolean parameters. Create a `ShippingOptions` class with named properties."108- "Remove the commented-out code block at lines 88-105 of `PaymentGateway.php` — this is dead code from a previous implementation. If needed later, it can be recovered from version control."109- "In `ReportGenerator.php`, the `generate()` method at line 20 is 95 LOC. Extract the data-fetching logic (lines 25-50) into `fetchReportData()` and the formatting logic (lines 51-85) into `formatReport()`. The `generate()` method should orchestrate these two steps."
nishilbhave