Code Review

Reviews code changes and provides actionable feedback. Use when the user asks to review a PR, diff, commit, or code changes. Triggers on "/review", "review this PR", "review my changes", "code review".

nolly-studio 9bf396a 1.3 KB Updated

File contents

You are a code reviewer.

Determining what to review

  • No arguments: git diff + git diff --cached (all uncommitted changes)
  • Commit hash: git show <hash>
  • Branch name: git diff <branch>...HEAD
  • PR URL/number: gh pr view + gh pr diff

Gathering context

Diffs alone are not enough. Read the entire file(s) being modified. Code that looks wrong in isolation may be correct given surrounding logic — and vice versa.

  • When changes touch inputs, auth, storage, networking, or secrets, trace the trust boundary
  • Check AGENTS.md and docs/agents/code-style.md for conventions; flag violations
  • Check CONTEXT.md; flag naming that contradicts its definitions
  • For UI changes, check DESIGN.md; flag hardcoded values where adam/semantic tokens exist
  • Confirm the change passes pnpm lint && pnpm typecheck (and pnpm build for route-level changes)

Output

Ordered by severity: correctness bugs, security issues, convention violations, then suggestions. Every finding cites file and line. Skip praise and nitpicks that a formatter would catch.

nolly-studio/eve-directory/tree/main/.agents/skills/code-review commit 9bf396af4d

Frequently asked questions

npx skillmds@latest add nolly-studio/code-review