PR review procedure
A reusable rubric for reviewing a pull request. Works as an orchestrated
flow (via the fanout.submit or flow.submit MCP verbs, or li o fanout /
li o flow from a lionagi checkout) or for a solo reviewer.
When to use
Any time you need a structured PR review — OSS contribution evaluation, internal code review, security sign-off, release gate.
Workflow Phases
| Phase | Action |
|---|---|
| 0. Fetch context | gh pr view + gh pr diff → save to _context/ |
| 1. Discovery | Parallel specialists from closed set (correctness, security, architecture, tests, perf) |
| 2. Discussion | Optional — only if dimensions cross-pollinate |
| 3. Critic synthesis | Reads all findings → critic_final/final_synthesis.md |
| 4. Post comment | ONE consolidated comment per verbosity tier |
Verdict options
APPROVE | APPROVE-WITH-FIXES | REJECT
Verbosity tiers for posting
| Verbosity | Content | Safe for |
|---|---|---|
| none | don't post, synthesis stays local | any |
| brief | ≤10 lines: verdict + top MUST-FIX only | OSS |
| substantive | MUST-FIX + SHOULD-FIX with file:line; omit blind-spots | internal repos |
| full | complete synthesis including blind spots + coverage | private repos only |
Ground rules
- Cite line numbers against committed HEAD of the PR branch.
- Don't invent requirements — only flag if absence is a bug.
- If runtime context is needed that isn't in the diff, say so.
- Graceful degradation — note any tool failures in synthesis.
Related skills
security-review— threat-model rubric for the security dimensionreview— general correctness and quality rubric
See specialist-guide.md for specialist dimensions, severity rubric, synthesis format, MCP and CLI examples, and source code reference.