Code review procedure
A general-purpose review rubric for any code change. Use as the
"correctness" specialist dimension of a multi-perspective review, or as
a standalone checklist when reviewing a diff without a specialization.
Scope
Review ONLY the assigned diff. Cross-module concerns go to architecture;
security-sensitive code goes to security-review.
Checklist summary (9 sections)
- Correctness — logic, control flow, off-by-one, error handling, invariants, concurrency, numeric
- API contract — backward compatibility, type annotations, error types, return value shape
- Tests — coverage of new paths, edge cases, mock fidelity, flaky risk
- Readability & maintainability — names, function length, nesting, comments, dead code
- Consistency — naming convention, error handling pattern, import ordering, abstraction level
- Docs & changelog — public API changes, behavioral changes, new config options
- Dependencies — necessity, maintenance, license, version constraints, lockfile
- Performance (light-touch) — obvious O(n²) regressions, hot-path allocations, N+1 queries
- Over/under-engineering — premature abstraction, speculative flexibility, too-simple cases
See checklist.md for the full detailed checklist with all sub-items.
Output format
Findings table per finding:
| Severity |
Location |
Issue |
Suggested fix |
Confidence |
| MEDIUM |
src/module.py:87 |
Off-by-one in range(len(xs)) |
Use enumerate(xs) |
High |
Verdict line at top: APPROVE | APPROVE-WITH-FIXES | REQUEST CHANGES.
Cite file:line for every finding.
Severity calibration
CRITICAL — will break production on merge
HIGH — correctness bug affecting real use cases
MEDIUM — edge case bug, significant maintainability issue
LOW — style, naming, minor refactor
INFO — future consideration, not blocking
Ground rules
- Describe the bug, propose a fix.
- Don't invent requirements.
- Rank severity honestly.
- Flag assumptions you can't verify from the diff.
- Review against committed HEAD of the PR branch.
1---2name: review3description: >4 General-purpose code review checklist. Use when reviewing any code change5 without a narrower specialization. Complements security-review, pr-review6 (multi-perspective), and the other review skills — pull this when you7 need the standard correctness/quality rubric without a specific angle.8allowed-tools: [Bash, Read, Glob, Grep]9metadata:10 source: https://skillmd.com/skills/ohdearquant/review11---1213# Code review procedure1415A general-purpose review rubric for any code change. Use as the16"correctness" specialist dimension of a multi-perspective review, or as17a standalone checklist when reviewing a diff without a specialization.1819## Scope2021Review ONLY the assigned diff. Cross-module concerns go to architecture;22security-sensitive code goes to security-review.2324## Checklist summary (9 sections)25261. **Correctness** — logic, control flow, off-by-one, error handling, invariants, concurrency, numeric272. **API contract** — backward compatibility, type annotations, error types, return value shape283. **Tests** — coverage of new paths, edge cases, mock fidelity, flaky risk294. **Readability & maintainability** — names, function length, nesting, comments, dead code305. **Consistency** — naming convention, error handling pattern, import ordering, abstraction level316. **Docs & changelog** — public API changes, behavioral changes, new config options327. **Dependencies** — necessity, maintenance, license, version constraints, lockfile338. **Performance (light-touch)** — obvious O(n²) regressions, hot-path allocations, N+1 queries349. **Over/under-engineering** — premature abstraction, speculative flexibility, too-simple cases3536See [checklist.md](checklist.md) for the full detailed checklist with all sub-items.3738## Output format3940Findings table per finding:4142| Severity | Location | Issue | Suggested fix | Confidence |43|---|---|---|---|---|44| MEDIUM | `src/module.py:87` | Off-by-one in `range(len(xs))` | Use `enumerate(xs)` | High |4546Verdict line at top: `APPROVE` | `APPROVE-WITH-FIXES` | `REQUEST CHANGES`.4748Cite `file:line` for every finding.4950## Severity calibration5152- `CRITICAL` — will break production on merge53- `HIGH` — correctness bug affecting real use cases54- `MEDIUM` — edge case bug, significant maintainability issue55- `LOW` — style, naming, minor refactor56- `INFO` — future consideration, not blocking5758## Ground rules59601. Describe the bug, propose a fix.612. Don't invent requirements.623. Rank severity honestly.634. Flag assumptions you can't verify from the diff.645. Review against committed HEAD of the PR branch.