OutlineDriven Perspective complete review
Contract
| Field | Bound contract |
|---|---|
| Trigger | User wants review and fix cycles for one viewpoint until that viewpoint is quiet. |
| Authority | Reversible local: writes only the reviewed artifact, its fix patches, the baseline snapshot, and the review report for this one viewpoint; rollback is restoring the recorded baseline. No remote, VCS-history, credential, paid, published, or deployed mutation. |
| Side effect | Reviewed artifact mutated only by applied in-scope fixes, the baseline snapshot (a file copy when no VCS baseline is supplied), and one review report holding the fix patches and verdict. No file outside the declared review scope is written, and no out-of-scope file is edited to make a fix fit. |
| Done | The chosen viewpoint has no further findings: a complete fresh-reviewer cycle returned zero findings for that viewpoint. Machines own logic, races, panics, and vulnerability checks; humans own taste, architecture, and problem choice. |
Inputs
- Reviewed artifact: one local file, diff, or directory. Required; it must exist and be writable before the run starts.
- Viewpoint: exactly one named seat, for example logic, races, panics, vulnerability, or another single perspective the user names. Required; a run covering two viewpoints is invalid.
- Acceptance checks: commands or test invocations that prove the artifact still works. Optional; when absent, every verdict is reported as reviewer-verified only.
- Cycle budget: maximum review cycles before the run stops. Optional; default 5.
- Baseline: version control state or a file copy taken before the first fix. Optional as a supplied input and mandatory as a step; when the user supplies neither, the run creates a file copy.
Procedure
- Bound scope before mutation. Confirm the artifact is local and writable and that exactly one viewpoint is named. If the artifact is missing, not local, or zero or multiple viewpoints were named, stop without writing anything. Done when: scope is bounded with one local writable artifact and exactly one viewpoint.
- Record the baseline. Capture the artifact state with version control or a file copy, then run the acceptance checks once to record the starting result. Record
no checks suppliedwhen none were given. Done when: the baseline is captured and the starting check result is recorded. - Write the viewpoint charter at the top of the review report: the viewpoint name, what it examines, what it ignores, and the ownership split. Logic, race, panic, and vulnerability findings are machine-owned and fixable. Taste, architecture, and problem-choice findings are human-owned and recorded as questions only. Done when: the viewpoint charter is written with name, scope, ignores, and ownership split.
- Run a review cycle with a fresh reviewer. Each cycle starts from an isolated context: the reviewer sees the current artifact state and the viewpoint charter only, never earlier cycle reports, fix justifications, or debate history. When more than one model family is available, run the reviewer on a different family than the one applying fixes; when only one family exists, keep the isolation and mark the cycle
same-family. Record which family each cycle used. Done when: the reviewer returns findings from an isolated context with the family recorded. - Return each finding as location, concrete defect, evidence, and a minimal fix proposal. Drop findings outside the viewpoint charter or outside the artifact; list out-of-scope ones under human questions instead of fixing them. Done when: every finding is returned with location, defect, evidence, and fix proposal, or listed as a human question.
- Apply fixes one at a time. For each machine-owned finding inside scope, apply the minimal patch, re-run the acceptance checks, and record the patch (file, location, change, check result) in the report. Revert any fix whose checks fail or whose completion would require edits outside the artifact, and record it as unresolved with the evidence. Done when: every machine-owned in-scope finding is applied and check-verified or reverted as unresolved.
- Repeat step 4. The viewpoint is quiet only when a complete fresh-reviewer cycle returns zero findings. Stop with
non-convergedwhen the cycle budget is exhausted without a zero-finding cycle, or earlier when the same defect is re-reported after its fix was applied and check-verified. Done when: a zero-finding cycle is returned or the cycle budget is exhausted.
Failure and recovery
- Invalid input (missing or non-local artifact, zero or multiple viewpoints): stop before any write and return
blockedwith the missing or conflicting input named. - Reviewer unavailable or a review cycle errors out: stop the campaign, keep fixes already applied and check-verified, and return
blockedwith the report showing the last completed cycle. Never substitute an unrun cycle with an assumption of quiet. - A fix fails its acceptance checks or needs out-of-scope edits: revert that patch immediately, record it as unresolved with evidence, and continue the cycle with the remaining findings.
- Non-convergence (cycle budget exhausted, or a defect re-reported after a verified fix): stop, keep check-verified fixes, and return
non-converged. Quiet is claimed only by a zero-finding cycle, never by budget exhaustion. - User rejects the result: restore the baseline so the artifact returns to its pre-run state and mark the report reverted.
- No failure is swallowed: every error, revert, and unresolved finding appears in the report, and the terminal classification reflects the state that actually held at stop time.
Output
One review report next to the reviewed artifact (<artifact-basename>.<viewpoint>-review.md or user-supplied path) containing the viewpoint charter, per-cycle log with model family, every applied fix patch with check result, human-owned questions, unresolved findings, and terminal classification, plus artifact state with check-verified fixes applied or baseline restored on rejection.