Prepare For Review

Prepare for Review

Run this before a PR so repeating review nits are gone, and so an AI reviewer on the other side has less to flag.

Do not ask for clarification. Do not commit or push. Do not run Bugbot or a full architecture redesign unless the user asks.

Do not build, restore, or test the solution (dotnet build, dotnet test, dotnet restore, or equivalent). After pass 2, tell the user to build locally to verify the changes.

The issue catalog is common-issues.md. Keep that file the source of truth. When the user pastes a new repeating PR comment and wants it remembered, append a new item there in the same format.

Triggers

If they invoke the skill and later ask for additional opinion in the same chat, run the opinion pass on the post-fix diff.

Scope of changes

Analyze the current workspace repo:

1. Merge-base of HEAD with the default base branch (main, else master).
2. Include committed, staged, and unstaged changes (git diff <merge-base> plus untracked files that belong to the feature).
3. Skip generated lockfiles, bin/, obj/, and vendor output.

If there is no diff, say so in one sentence and stop.

Pass 1 — Print the checklist (before any analysis)

In the first user-visible reply, print the catalog as a compact list. Use the id and title from common-issues.md, nothing else:

Preparing for review. Checking:

1. `comments` — Unrequested comments
2. `names` — Comment instead of a name
...

Then start analysis. Do not skip this print.

Pass 2 — Analyze and fix

For every item in common-issues.md:

1. Search the diff (and nearby new files) for that issue.
2. If found, fix it in the same pass using that item's fix rule.
3. Do not "improve" unrelated code. Do not apply items from the opinion pass.

After fixes, re-scan once for the same catalog so a fix did not introduce another catalog item (e.g. a rename that left a narration comment).

Report

End with a short report:

## Review prep

**Fixed**
- `comments` — removed XML docs from `Foo.cs`
- `mapping` — replaced manual map in `BarService` with AutoMapper

**Already clean**
- `validation`, `cancellation`, ...

**Skipped**
- `dead-code` — unused `FooHelper`; may be waiting on API — not deleted
- `duplicate-write` — looks like an intentional design; not auto-changed

Skipped is for catalog items marked ask-before-redesign, or for hits that would change behaviour beyond the nit. Do not delete unused members or types without the user confirming — they may be waiting on an API.

After the report, one short line: ask the user to build locally. Do not run the build yourself.

Pass 3 — Additional opinion (only on request)

Run this only when the user asks for additional opinion / AI-reviewer findings.

Role: a strict PR reviewer AI (Copilot / CodeRabbit style) looking at the current diff. Goal: surface what they would comment so the user can decide.

Rules:

• Do not edit code.
• Do not repeat catalog items already fixed or reported in pass 2.
• Be concrete: file:line, what is wrong, what a reviewer would say, suggested fix in one or two sentences.
• Sort by severity: behaviour/correctness → security → missing tests → design → style.
• Skip nits already covered by the catalog even if still present and skipped.
• End with: ask which findings (if any) to apply. Wait for that before changing code.

Typical extra findings (examples, not a checklist to force):

• Extra collection/table that copies fields already on the source document
• Two queries on the happy path where one write would do
• Race / missing transaction / missing idempotency key
• Options/DI: constructed settings object instead of Action<T> / IOptions<T>
• Error type or message that does not match the actual failure
• Public API without tests in a repo that already tests that layer
• Leftover names from a removed design (Request, Queue, …) that mislead

Format:

## Additional opinion (not applied)

| Sev | Location | Reviewer would say |
|-----|----------|--------------------|
| high | `src/Foo.cs:40` | ... |

Maintaining the catalog

When the user says a PR comment keeps coming back, or pastes one and says to remember it:

1. Add a new item to common-issues.md with a short id, title, detect, fix, and auto-fix vs ask-before-redesign.
2. Confirm in one sentence that it was added.
3. Do not re-run the full pass unless they also asked to prepare for review.